Fully convert ExtensionDiscovery to be injectable

- To fix unit tests

Signed-off-by: Sebastian Malton <sebastian@malton.name>

packages/core/src/common/fs/copy.global-override-for-injectable.ts

@@ -1,11 +0,0 @@
-/**
- * Copyright (c) OpenLens Authors. All rights reserved.
- * Licensed under MIT License. See LICENSE in root directory for more information.
- */
-
-import { getGlobalOverride } from "../test-utils/get-global-override";
-import copyInjectable from "./copy.injectable";
-
-export default getGlobalOverride(copyInjectable, () => async () => {
-  throw new Error("tried to copy filepaths without override");
-});

packages/core/src/common/fs/ensure-directory.injectable.ts

@@ -7,12 +7,9 @@ import fsInjectable from "./fs.injectable";
 
 export type EnsureDirectory = (dirPath: string) => Promise<void>;
 
-const ensureDirInjectable = getInjectable({
+const ensureDirectoryInjectable = getInjectable({
   id: "ensure-dir",
-
-  // TODO: Remove usages of ensureDir from business logic.
-  // TODO: Read, Write, Watch etc. operations should do this internally.
   instantiate: (di): EnsureDirectory => di.inject(fsInjectable).ensureDir,
 });
 
-export default ensureDirInjectable;
+export default ensureDirectoryInjectable;

packages/core/src/common/fs/lstat.global-override-for-injectable.ts

@@ -1,11 +0,0 @@
-/**
- * Copyright (c) OpenLens Authors. All rights reserved.
- * Licensed under MIT License. See LICENSE in root directory for more information.
- */
-
-import { getGlobalOverride } from "../test-utils/get-global-override";
-import lstatInjectable from "./lstat.injectable";
-
-export default getGlobalOverride(lstatInjectable, () => async () => {
-  throw new Error("tried to lstat a filepath without override");
-});

packages/core/src/common/fs/read-directory.global-override-for-injectable.ts

@@ -1,11 +0,0 @@
-/**
- * Copyright (c) OpenLens Authors. All rights reserved.
- * Licensed under MIT License. See LICENSE in root directory for more information.
- */
-
-import { getGlobalOverride } from "../test-utils/get-global-override";
-import readDirectoryInjectable from "./read-directory.injectable";
-
-export default getGlobalOverride(readDirectoryInjectable, () => async () => {
-  throw new Error("tried to read a directory's content without override");
-});

packages/core/src/common/fs/remove.global-override-for-injectable.ts

@@ -1,11 +0,0 @@
-/**
- * Copyright (c) OpenLens Authors. All rights reserved.
- * Licensed under MIT License. See LICENSE in root directory for more information.
- */
-
-import { getGlobalOverride } from "../test-utils/get-global-override";
-import removePathInjectable from "./remove.injectable";
-
-export default getGlobalOverride(removePathInjectable, () => async () => {
-  throw new Error("tried to remove path without override");
-});

packages/core/src/common/fs/write-file.global-override-for-injectable.ts

@@ -1,11 +0,0 @@
-/**
- * Copyright (c) OpenLens Authors. All rights reserved.
- * Licensed under MIT License. See LICENSE in root directory for more information.
- */
-
-import { getGlobalOverride } from "../test-utils/get-global-override";
-import writeFileInjectable from "./write-file.injectable";
-
-export default getGlobalOverride(writeFileInjectable, () => async () => {
-  throw new Error("tried to write file without override");
-});

packages/core/src/common/ipc/extension-handling.ts

@@ -1,6 +0,0 @@
-/**
- * Copyright (c) OpenLens Authors. All rights reserved.
- * Licensed under MIT License. See LICENSE in root directory for more information.
- */
-
-export const extensionDiscoveryStateChannel = "extension-discovery:state";

packages/core/src/common/library.ts

@@ -4,4 +4,4 @@
  */
 
 // @experimental
-export { bundledExtensionInjectionToken } from "../extensions/extension-discovery/bundled-extension-token";
+export { bundledExtensionInjectionToken } from "../features/extensions/common/bundled-extension-token";

packages/core/src/common/utils/sync-box/sync-box-injection-token.ts

@@ -5,8 +5,8 @@
 import { getInjectionToken } from "@ogre-tools/injectable";
 import type { IComputedValue } from "mobx";
 export interface SyncBox<Value> {
-  id: string;
-  value: IComputedValue<Value>;
+  readonly id: string;
+  readonly value: IComputedValue<Value>;
   set: (value: Value) => void;
 }
 

packages/core/src/common/vars.ts

@@ -12,6 +12,8 @@ export const defaultFontSize = 12;
 export const defaultTerminalFontFamily = "RobotoMono";
 export const defaultEditorFontFamily = "RobotoMono";
 
+export const manifestFilename = "package.json";
+
 // Apis
 export const apiPrefix = "/api"; // local router apis
 export const apiKubePrefix = "/api-kube"; // k8s cluster apis