hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Fix tests, remove custom testid prop

Browse Source 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
Sebastian Malton 2022-05-30 10:56:12 -04:00
parent 4e765384bb
commit ad2c7dd1e8
6 changed files with 16 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
package.json
View File

@ -72,6 +72,9 @@
"<rootDir>/src/jest.setup.ts", "<rootDir>/src/jest.setup.ts",
"jest-canvas-mock" "jest-canvas-mock"
], ],
"setupFilesAfterEnv": [
"<rootDir>/src/jest-after-env.setup.ts"
],
"globals": { "globals": {
"ts-jest": { "ts-jest": {
"isolatedModules": true "isolatedModules": true

5
src/jest-after-env.setup.ts Normal file
View File

@ -0,0 +1,5 @@
/**
* Copyright (c) OpenLens Authors. All rights reserved.
* Licensed under MIT License. See LICENSE in root directory for more information.
*/
import "@testing-library/jest-dom/extend-expect";

6
src/renderer/components/+workloads-pods/details/volumes/variants/__tests__/__snapshots__/ceph-fs.test.tsx.snap
View File

@ -60,6 +60,7 @@ exports[`<CephFs /> should render 'false' for Readonly when false is provided 1`
</div> </div>
<div <div
class="DrawerItem" class="DrawerItem"
data-testid="cephfs-readonly"
> >
<span <span
class="name" class="name"
@ -68,7 +69,6 @@ exports[`<CephFs /> should render 'false' for Readonly when false is provided 1`
</span> </span>
<span <span
class="value" class="value"
data-testid="cephfs-readonly"
> >
false false
</span> </span>
@ -136,6 +136,7 @@ exports[`<CephFs /> should render 'false' for Readonly when not provided 1`] = `
</div> </div>
<div <div
class="DrawerItem" class="DrawerItem"
data-testid="cephfs-readonly"
> >
<span <span
class="name" class="name"
@ -144,7 +145,6 @@ exports[`<CephFs /> should render 'false' for Readonly when not provided 1`] = `
</span> </span>
<span <span
class="value" class="value"
data-testid="cephfs-readonly"
> >
false false
</span> </span>
@ -212,6 +212,7 @@ exports[`<CephFs /> should render 'true' for Readonly when true is provided 1`]
</div> </div>
<div <div
class="DrawerItem" class="DrawerItem"
data-testid="cephfs-readonly"
> >
<span <span
class="name" class="name"
@ -220,7 +221,6 @@ exports[`<CephFs /> should render 'true' for Readonly when true is provided 1`]
</span> </span>
<span <span
class="value" class="value"
data-testid="cephfs-readonly"
> >
true true
</span> </span>

6
src/renderer/components/+workloads-pods/details/volumes/variants/__tests__/ceph-fs.test.tsx
View File

@ -41,7 +41,7 @@ describe("<CephFs />", () => {
)); ));
expect(result.container).toMatchSnapshot(); expect(result.container).toMatchSnapshot();
expect(result.getByTestId("cephfs-readonly").innerHTML).toBe("false"); expect(result.getByTestId("cephfs-readonly")).toHaveTextContent("false");
}); });
it("should render 'false' for Readonly when false is provided", () => { it("should render 'false' for Readonly when false is provided", () => {
@ -76,7 +76,7 @@ describe("<CephFs />", () => {
)); ));
expect(result.container).toMatchSnapshot(); expect(result.container).toMatchSnapshot();
expect(result.getByTestId("cephfs-readonly").innerHTML).toBe("false"); expect(result.getByTestId("cephfs-readonly")).toHaveTextContent("false");
}); });
it("should render 'true' for Readonly when true is provided", () => { it("should render 'true' for Readonly when true is provided", () => {
@ -111,6 +111,6 @@ describe("<CephFs />", () => {
)); ));
expect(result.container).toMatchSnapshot(); expect(result.container).toMatchSnapshot();
expect(result.getByTestId("cephfs-readonly").innerHTML).toBe("true"); expect(result.getByTestId("cephfs-readonly")).toHaveTextContent("true");
}); });
}); });

2
src/renderer/components/+workloads-pods/details/volumes/variants/ceph-fs.tsx
View File

@ -39,7 +39,7 @@ export const CephFs: VolumeVariantComponent<"cephfs"> = (
</DrawerItem> </DrawerItem>
) )
} }
<DrawerItem name="Readonly" valueTestId="cephfs-readonly"> <DrawerItem name="Readonly" data-testid="cephfs-readonly">
{readOnly.toString()} {readOnly.toString()}
</DrawerItem> </DrawerItem>
</> </>

4
src/renderer/components/drawer/drawer-item.tsx
View File

@ -13,7 +13,6 @@ export interface DrawerItemProps extends React.HTMLAttributes<HTMLDivElement> {
labelsOnly?: boolean; labelsOnly?: boolean;
hidden?: boolean; hidden?: boolean;
renderBoolean?: boolean; // show "true" or "false" for all of the children elements are "typeof boolean" renderBoolean?: boolean; // show "true" or "false" for all of the children elements are "typeof boolean"
valueTestId?: string;
} }
export function DrawerItem({ export function DrawerItem({
@ -24,7 +23,6 @@ export function DrawerItem({
hidden = false, hidden = false,
className, className,
renderBoolean, renderBoolean,
valueTestId,
...elemProps ...elemProps
}: DrawerItemProps) { }: DrawerItemProps) {
if (hidden) { if (hidden) {
@ -38,7 +36,7 @@ export function DrawerItem({
title={title} title={title}
> >
<span className="name">{name}</span> <span className="name">{name}</span>
<span className="value" data-testid={valueTestId}>{displayBooleans(renderBoolean, children)}</span> <span className="value">{displayBooleans(renderBoolean, children)}</span>
</div> </div>
); );
} }