From adbe6cad69d636fc020838d8f15a4899216e7a7e Mon Sep 17 00:00:00 2001 From: Roman Date: Sat, 9 Oct 2021 17:24:43 +0300 Subject: [PATCH] fix: always use string for monaco.editor.setValue(value) / handle `undefined` Signed-off-by: Roman --- src/renderer/components/monaco-editor/monaco-editor.tsx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/renderer/components/monaco-editor/monaco-editor.tsx b/src/renderer/components/monaco-editor/monaco-editor.tsx index ba22f6c0af..933795b8b7 100644 --- a/src/renderer/components/monaco-editor/monaco-editor.tsx +++ b/src/renderer/components/monaco-editor/monaco-editor.tsx @@ -244,15 +244,15 @@ export class MonacoEditor extends React.Component { return editor.createModel(value, language, uri); } - setValue(value: string) { + setValue(value = "") { if (value == this.getValue()) return; this.editor.setValue(value); this.validateOnChange(value); } - getValue(opts?: { preserveBOM: boolean; lineEnding: string; }) { - return this.editor.getValue(opts); + getValue(opts?: { preserveBOM: boolean; lineEnding: string; }): string { + return this.editor?.getValue(opts) ?? ""; } // avoid excessive validations during typing