From aedcded8228ced1a77d84b7e28cf7d512f37fb2d Mon Sep 17 00:00:00 2001 From: Janne Savolainen Date: Mon, 17 Oct 2022 15:49:32 +0300 Subject: [PATCH] Remove duplication from preference pages Signed-off-by: Janne Savolainen --- ...elm-repository-in-preferences.test.ts.snap | 108 ++++++++---------- ...tory-from-list-in-preferences.test.ts.snap | 90 +++++++-------- ...m-repositories-in-preferences.test.ts.snap | 90 +++++++-------- ...ive-repository-in-preferences.test.ts.snap | 36 +++--- .../closing-preferences.test.tsx.snap | 22 ++-- ...nsion-adding-preference-tabs.test.tsx.snap | 9 +- .../hiding-of-empty-branches.test.tsx.snap | 24 ++-- ...on-to-application-preferences.test.ts.snap | 18 ++- ...igation-to-editor-preferences.test.ts.snap | 20 ++-- ...tension-specific-preferences.test.tsx.snap | 18 ++- ...ion-to-kubernetes-preferences.test.ts.snap | 18 ++- ...vigation-to-proxy-preferences.test.ts.snap | 18 ++- ...ion-to-telemetry-preferences.test.tsx.snap | 36 +++--- ...ation-to-terminal-preferences.test.ts.snap | 18 ++- ...gation-using-application-menu.test.ts.snap | 9 +- .../navigation-using-tray.test.ts.snap | 9 +- ...igation-to-application-preferences.test.ts | 4 +- .../navigation-to-editor-preferences.test.ts | 4 +- ...vigation-to-kubernetes-preferences.test.ts | 4 +- .../navigation-to-proxy-preferences.test.ts | 4 +- ...vigation-to-telemetry-preferences.test.tsx | 4 +- ...navigation-to-terminal-preferences.test.ts | 4 +- .../navigation-using-application-menu.test.ts | 4 +- .../preferences/navigation-using-tray.test.ts | 4 +- .../renderer/get-preference-page.tsx | 14 +++ ...application-preference-page.injectable.tsx | 4 +- .../application-preference-page.tsx | 14 --- .../editor-preference-page.injectable.ts | 4 +- .../editor/editor-preference-page.tsx | 14 --- .../kubernetes/kubernetes-page.tsx | 14 --- .../kubernetes-preference-page.injectable.tsx | 4 +- .../preference-item-injection-token.ts | 11 +- .../proxy-preference-page.injectable.tsx | 4 +- .../proxy/proxy-preference-page.tsx | 14 --- .../telemetry/telemetry-page.tsx | 14 --- .../telemetry-preference-page.injectable.tsx | 4 +- ...rminal-page-preference-item.injectable.tsx | 4 +- .../terminal/terminal-page.tsx | 14 --- .../preferences/renderer/preferences.tsx | 34 ++++-- 39 files changed, 314 insertions(+), 428 deletions(-) create mode 100644 src/features/preferences/renderer/get-preference-page.tsx delete mode 100644 src/features/preferences/renderer/preference-items/application/application-preference-page.tsx delete mode 100644 src/features/preferences/renderer/preference-items/editor/editor-preference-page.tsx delete mode 100644 src/features/preferences/renderer/preference-items/kubernetes/kubernetes-page.tsx delete mode 100644 src/features/preferences/renderer/preference-items/proxy/proxy-preference-page.tsx delete mode 100644 src/features/preferences/renderer/preference-items/telemetry/telemetry-page.tsx delete mode 100644 src/features/preferences/renderer/preference-items/terminal/terminal-page.tsx diff --git a/src/features/helm-charts/__snapshots__/add-custom-helm-repository-in-preferences.test.ts.snap b/src/features/helm-charts/__snapshots__/add-custom-helm-repository-in-preferences.test.ts.snap index 4016e3a837..da7e454080 100644 --- a/src/features/helm-charts/__snapshots__/add-custom-helm-repository-in-preferences.test.ts.snap +++ b/src/features/helm-charts/__snapshots__/add-custom-helm-repository-in-preferences.test.ts.snap @@ -87,6 +87,7 @@ exports[`add custom helm repository in preferences when navigating to preference >
Preferences
@@ -162,12 +163,10 @@ exports[`add custom helm repository in preferences when navigating to preference class="content" >
-

+

Kubernetes

Preferences
@@ -760,12 +760,10 @@ exports[`add custom helm repository in preferences when navigating to preference class="content" >
-

+

Kubernetes

Preferences
@@ -1369,12 +1368,10 @@ exports[`add custom helm repository in preferences when navigating to preference class="content" >
-

+

Kubernetes

Preferences
@@ -2089,12 +2087,10 @@ exports[`add custom helm repository in preferences when navigating to preference class="content" >
-

+

Kubernetes

Preferences
@@ -2706,12 +2703,10 @@ exports[`add custom helm repository in preferences when navigating to preference class="content" >
-

+

Kubernetes

Preferences
@@ -3426,12 +3422,10 @@ exports[`add custom helm repository in preferences when navigating to preference class="content" >
-

+

Kubernetes

Preferences
@@ -4328,12 +4323,10 @@ exports[`add custom helm repository in preferences when navigating to preference class="content" >
-

+

Kubernetes

Preferences
@@ -5048,12 +5042,10 @@ exports[`add custom helm repository in preferences when navigating to preference class="content" >
-

+

Kubernetes

Preferences
@@ -5950,12 +5943,10 @@ exports[`add custom helm repository in preferences when navigating to preference class="content" >
-

+

Kubernetes

Preferences
@@ -6671,12 +6663,10 @@ exports[`add custom helm repository in preferences when navigating to preference class="content" >
-

+

Kubernetes

Preferences
@@ -7288,12 +7279,10 @@ exports[`add custom helm repository in preferences when navigating to preference class="content" >
-

+

Kubernetes

Preferences
@@ -7894,12 +7884,10 @@ exports[`add custom helm repository in preferences when navigating to preference class="content" >
-

+

Kubernetes

Preferences
@@ -162,12 +163,10 @@ exports[`add helm repository from list in preferences when navigating to prefere class="content" >
-

+

Kubernetes

Preferences
@@ -760,12 +760,10 @@ exports[`add helm repository from list in preferences when navigating to prefere class="content" >
-

+

Kubernetes

Preferences
@@ -1369,12 +1368,10 @@ exports[`add helm repository from list in preferences when navigating to prefere class="content" >
-

+

Kubernetes

Preferences
@@ -2031,12 +2029,10 @@ exports[`add helm repository from list in preferences when navigating to prefere class="content" >
-

+

Kubernetes

Preferences
@@ -2640,12 +2637,10 @@ exports[`add helm repository from list in preferences when navigating to prefere class="content" >
-

+

Kubernetes

Preferences
@@ -3249,12 +3245,10 @@ exports[`add helm repository from list in preferences when navigating to prefere class="content" >
-

+

Kubernetes

Preferences
@@ -3847,12 +3842,10 @@ exports[`add helm repository from list in preferences when navigating to prefere class="content" >
-

+

Kubernetes

Preferences
@@ -4490,12 +4484,10 @@ exports[`add helm repository from list in preferences when navigating to prefere class="content" >
-

+

Kubernetes

Preferences
@@ -5196,12 +5189,10 @@ exports[`add helm repository from list in preferences when navigating to prefere class="content" >
-

+

Kubernetes

Preferences
@@ -5839,12 +5831,10 @@ exports[`add helm repository from list in preferences when navigating to prefere class="content" >
-

+

Kubernetes

Preferences
@@ -162,12 +163,10 @@ exports[`listing active helm repositories in preferences when navigating to pref class="content" >
-

+

Kubernetes

Preferences
@@ -760,12 +760,10 @@ exports[`listing active helm repositories in preferences when navigating to pref class="content" >
-

+

Kubernetes

Preferences
@@ -1358,12 +1357,10 @@ exports[`listing active helm repositories in preferences when navigating to pref class="content" >
-

+

Kubernetes

Preferences
@@ -1848,12 +1846,10 @@ exports[`listing active helm repositories in preferences when navigating to pref class="content" >
-

+

Kubernetes

Preferences
@@ -2446,12 +2443,10 @@ exports[`listing active helm repositories in preferences when navigating to pref class="content" >
-

+

Kubernetes

Preferences
@@ -2936,12 +2932,10 @@ exports[`listing active helm repositories in preferences when navigating to pref class="content" >
-

+

Kubernetes

Preferences
@@ -3534,12 +3529,10 @@ exports[`listing active helm repositories in preferences when navigating to pref class="content" >
-

+

Kubernetes

Preferences
@@ -4177,12 +4171,10 @@ exports[`listing active helm repositories in preferences when navigating to pref class="content" >
-

+

Kubernetes

Preferences
@@ -4667,12 +4660,10 @@ exports[`listing active helm repositories in preferences when navigating to pref class="content" >
-

+

Kubernetes

Preferences
@@ -5157,12 +5149,10 @@ exports[`listing active helm repositories in preferences when navigating to pref class="content" >
-

+

Kubernetes

Preferences
@@ -162,12 +163,10 @@ exports[`remove helm repository from list of active repositories in preferences class="content" >
-

+

Kubernetes

Preferences
@@ -760,12 +760,10 @@ exports[`remove helm repository from list of active repositories in preferences class="content" >
-

+

Kubernetes

Preferences
@@ -1369,12 +1368,10 @@ exports[`remove helm repository from list of active repositories in preferences class="content" >
-

+

Kubernetes

Preferences
@@ -1978,12 +1976,10 @@ exports[`remove helm repository from list of active repositories in preferences class="content" >
-

+

Kubernetes

Preferences
@@ -173,12 +174,10 @@ exports[`preferences - closing-preferences given accessing preferences directly class="content" >
-

+

Application