From af368985a850d8147688e709397e25bf8f7d8545 Mon Sep 17 00:00:00 2001 From: Sebastian Malton Date: Mon, 9 Jan 2023 10:51:27 -0500 Subject: [PATCH] Fix reactively-hide-kube-object-detail-item tests Signed-off-by: Sebastian Malton --- src/common/k8s-api/api-manager/api-manager.ts | 6 +++++- .../reactively-hide-kube-object-detail-item.test.tsx | 5 +++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/src/common/k8s-api/api-manager/api-manager.ts b/src/common/k8s-api/api-manager/api-manager.ts index 48c470da68..81b59ef9c2 100644 --- a/src/common/k8s-api/api-manager/api-manager.ts +++ b/src/common/k8s-api/api-manager/api-manager.ts @@ -123,9 +123,13 @@ export class ApiManager { : apiOrBase; const api = this.getApi(apiBase); + if (!api) { + return undefined; + } + return chain(this.dependencies.stores.get().values()) .concat(this.externalStores.values()) - .find(store => store.api === api); + .find(store => store.api.apiBase === api.apiBase); } lookupApiLink(ref: ObjectReference, parentObject?: KubeObject): string { diff --git a/src/features/cluster/kube-object-details/extension-api/reactively-hide-kube-object-detail-item.test.tsx b/src/features/cluster/kube-object-details/extension-api/reactively-hide-kube-object-detail-item.test.tsx index 1a22d5d0b0..847ad3ed11 100644 --- a/src/features/cluster/kube-object-details/extension-api/reactively-hide-kube-object-detail-item.test.tsx +++ b/src/features/cluster/kube-object-details/extension-api/reactively-hide-kube-object-detail-item.test.tsx @@ -13,6 +13,7 @@ import apiManagerInjectable from "../../../../common/k8s-api/api-manager/manager import type { KubeObjectStore } from "../../../../common/k8s-api/kube-object.store"; import type { KubeApi } from "../../../../common/k8s-api/kube-api"; import showDetailsInjectable from "../../../../renderer/components/kube-detail-params/show-details.injectable"; +import assert from "assert"; describe("reactively hide kube object detail item", () => { let builder: ApplicationBuilder; @@ -89,6 +90,10 @@ describe("reactively hide kube object detail item", () => { runInAction(() => { someObservable.set(true); }); + + const apiManager = builder.applicationWindow.only.di.inject(apiManagerInjectable); + + assert(apiManager.getStore("/apis/some-api-version/some-kind")); }); it("renders", () => {