hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Review fixes

Browse Source 
Signed-off-by: Panu Horsmalahti <phorsmalahti@mirantis.com>
This commit is contained in:
Panu Horsmalahti 2020-12-11 15:45:24 +02:00
parent aa67a3429d
commit aff7c61e8c
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/extensions/extension-discovery.ts
View File

@ -266,9 +266,9 @@ export class ExtensionDiscovery {
logger.info(`${logModule} loading extensions from ${extensionInstaller.extensionPackagesRoot}`); logger.info(`${logModule} loading extensions from ${extensionInstaller.extensionPackagesRoot}`);
if (await fs.pathExists(path.join(extensionInstaller.extensionPackagesRoot, "package-lock.json"))) { // fs.remove won't throw if path is missing
await fs.remove(path.join(extensionInstaller.extensionPackagesRoot, "package-lock.json")); await fs.remove(path.join(extensionInstaller.extensionPackagesRoot, "package-lock.json"));
}
try { try {
// Verify write access to static/extensions, which is needed for symlinking // Verify write access to static/extensions, which is needed for symlinking

6
src/main/index.ts
View File

@ -83,8 +83,8 @@ app.on("ready", async () => {
// eslint-disable-next-line unused-imports/no-unused-vars-ts // eslint-disable-next-line unused-imports/no-unused-vars-ts
proxyServer = LensProxy.create(proxyPort, clusterManager); proxyServer = LensProxy.create(proxyPort, clusterManager);
} catch (error) { } catch (error) {
logger.error(`Could not start proxy (127.0.0:${proxyPort}): ${error.message}`); logger.error(`Could not start proxy (127.0.0:${proxyPort}): ${error?.message}`);
dialog.showErrorBox("Lens Error", `Could not start proxy (127.0.0:${proxyPort}): ${error.message || "unknown error"}`); dialog.showErrorBox("Lens Error", `Could not start proxy (127.0.0:${proxyPort}): ${error?.message || "unknown error"}`);
app.exit(); app.exit();
} }
@ -107,7 +107,7 @@ app.on("ready", async () => {
extensionLoader.initExtensions(extensions); extensionLoader.initExtensions(extensions);
} catch (error) { } catch (error) {
dialog.showErrorBox("Lens Error", `Could not load extensions: ${error?.message || ""}`); dialog.showErrorBox("Lens Error", `Could not load extensions${error?.message ? `: ${error.message}` : ""}`);
} }
setTimeout(() => { setTimeout(() => {