cleanup Lens repo with tighter linting

Signed-off-by: Sebastian Malton <smalton@mirantis.com>

dashboard/client/components/+config-maps/config-map-details.tsx

@@ -23,7 +23,7 @@ export class ConfigMapDetails extends React.Component<Props> {
   @observable isSaving = false;
   @observable data = observable.map();
 
-  async componentDidMount() {
+  componentDidMount(): void {
     disposeOnUnmount(this, [
       autorun(() => {
         const { object: configMap } = this.props;
@@ -31,10 +31,10 @@ export class ConfigMapDetails extends React.Component<Props> {
           this.data.replace(configMap.data); // refresh
         }
       })
-    ])
+    ]);
   }
 
-  save = async () => {
+  save = async (): Promise<void> => {
     const { object: configMap } = this.props;
     try {
       this.isSaving = true;
@@ -49,9 +49,11 @@ export class ConfigMapDetails extends React.Component<Props> {
     }
   }
 
-  render() {
+  render(): JSX.Element {
     const { object: configMap } = this.props;
-    if (!configMap) return null;
+    if (!configMap) {
+      return null;
+    }
     const data = Object.entries(this.data.toJSON());
     return (
       <div className="ConfigMapDetails">
@@ -71,11 +73,13 @@ export class ConfigMapDetails extends React.Component<Props> {
                           theme="round-black"
                           className="box grow"
                           value={value}
-                          onChange={v => this.data.set(name, v)}
+                          onChange={(v): void => {
+                            this.data.set(name, v);
+                          }}
                         />
                       </div>
                     </div>
-                  )
+                  );
                 })
               }
               <Button
@@ -96,4 +100,4 @@ export class ConfigMapDetails extends React.Component<Props> {
 
 apiManager.registerViews(configMapApi, {
   Details: ConfigMapDetails
-})
+});

dashboard/client/components/+config-maps/config-maps.route.ts

@@ -3,9 +3,9 @@ import { buildURL } from "../../navigation";
 
 export const configMapsRoute: RouteProps = {
   path: "/configmaps"
+};
+
+export interface ConfigMapsRouteParams {
 }
 
-export interface IConfigMapsRouteParams {
-}
-
-export const configMapsURL = buildURL<IConfigMapsRouteParams>(configMapsRoute.path);
+export const configMapsURL = buildURL<ConfigMapsRouteParams>(configMapsRoute.path);

dashboard/client/components/+config-maps/config-maps.tsx

@@ -1,4 +1,4 @@
-import "./config-maps.scss"
+import "./config-maps.scss";
 
 import * as React from "react";
 import { observer } from "mobx-react";
@@ -8,7 +8,7 @@ import { configMapsStore } from "./config-maps.store";
 import { ConfigMap, configMapApi } from "../../api/endpoints/configmap.api";
 import { KubeObjectMenu, KubeObjectMenuProps } from "../kube-object/kube-object-menu";
 import { KubeObjectListLayout } from "../kube-object";
-import { IConfigMapsRouteParams } from "./config-maps.route";
+import { ConfigMapsRouteParams } from "./config-maps.route";
 import { apiManager } from "../../api/api-manager";
 
 enum sortBy {
@@ -18,24 +18,24 @@ enum sortBy {
   age = "age",
 }
 
-interface Props extends RouteComponentProps<IConfigMapsRouteParams> {
+interface Props extends RouteComponentProps<ConfigMapsRouteParams> {
 }
 
 @observer
 export class ConfigMaps extends React.Component<Props> {
-  render() {
+  render(): JSX.Element {
     return (
       <KubeObjectListLayout
         className="ConfigMaps" store={configMapsStore}
         sortingCallbacks={{
-          [sortBy.name]: (item: ConfigMap) => item.getName(),
-          [sortBy.namespace]: (item: ConfigMap) => item.getNs(),
-          [sortBy.keys]: (item: ConfigMap) => item.getKeys(),
-          [sortBy.age]: (item: ConfigMap) => item.metadata.creationTimestamp,
+          [sortBy.name]: (item: ConfigMap): string => item.getName(),
+          [sortBy.namespace]: (item: ConfigMap): string => item.getNs(),
+          [sortBy.keys]: (item: ConfigMap): string[] => item.getKeys(),
+          [sortBy.age]: (item: ConfigMap): string => item.metadata.creationTimestamp,
         }}
         searchFilters={[
-          (item: ConfigMap) => item.getSearchFields(),
-          (item: ConfigMap) => item.getKeys()
+          (item: ConfigMap): string[] => item.getSearchFields(),
+          (item: ConfigMap): string[] => item.getKeys()
         ]}
         renderHeaderTitle={<Trans>Config Maps</Trans>}
         renderTableHeader={[
@@ -44,26 +44,26 @@ export class ConfigMaps extends React.Component<Props> {
           { title: <Trans>Keys</Trans>, className: "keys", sortBy: sortBy.keys },
           { title: <Trans>Age</Trans>, className: "age", sortBy: sortBy.age },
         ]}
-        renderTableContents={(configMap: ConfigMap) => [
+        renderTableContents={(configMap: ConfigMap): (string | number)[] => [
           configMap.getName(),
           configMap.getNs(),
           configMap.getKeys().join(", "),
           configMap.getAge(),
         ]}
-        renderItemMenu={(item: ConfigMap) => {
-          return <ConfigMapMenu object={item}/>
+        renderItemMenu={(item: ConfigMap): JSX.Element => {
+          return <ConfigMapMenu object={item}/>;
         }}
       />
     );
   }
 }
 
-export function ConfigMapMenu(props: KubeObjectMenuProps<ConfigMap>) {
+export function ConfigMapMenu(props: KubeObjectMenuProps<ConfigMap>): JSX.Element {
   return (
     <KubeObjectMenu {...props}/>
-  )
+  );
 }
 
 apiManager.registerViews(configMapApi, {
   Menu: ConfigMapMenu,
-})
+});

dashboard/client/components/+config-maps/index.ts

@@ -1,3 +1,3 @@
-export * from "./config-maps.route"
-export * from "./config-maps"
-export * from "./config-map-details"
+export * from "./config-maps.route";
+export * from "./config-maps";
+export * from "./config-map-details";