cleanup Lens repo with tighter linting

Signed-off-by: Sebastian Malton <smalton@mirantis.com>

dashboard/client/components/+network-policies/index.ts

@@ -1,3 +1,3 @@
-export * from "./network-policies.route"
-export * from "./network-policies"
-export * from "./network-policy-details"
+export * from "./network-policies.route";
+export * from "./network-policies";
+export * from "./network-policy-details";

dashboard/client/components/+network-policies/network-policies.route.ts

@@ -1,11 +1,11 @@
-import { RouteProps } from "react-router"
+import { RouteProps } from "react-router";
 import { buildURL } from "../../navigation";
 
 export const networkPoliciesRoute: RouteProps = {
   path: "/network-policies"
+};
+
+export interface NetworkPoliciesRouteParams {
 }
 
-export interface INetworkPoliciesRouteParams {
-}
-
-export const networkPoliciesURL = buildURL<INetworkPoliciesRouteParams>(networkPoliciesRoute.path);
+export const networkPoliciesURL = buildURL<NetworkPoliciesRouteParams>(networkPoliciesRoute.path);

dashboard/client/components/+network-policies/network-policies.tsx

@@ -1,4 +1,4 @@
-import "./network-policies.scss"
+import "./network-policies.scss";
 
 import * as React from "react";
 import { observer } from "mobx-react";
@@ -7,7 +7,7 @@ import { RouteComponentProps } from "react-router-dom";
 import { NetworkPolicy, networkPolicyApi } from "../../api/endpoints/network-policy.api";
 import { KubeObjectMenu, KubeObjectMenuProps } from "../kube-object/kube-object-menu";
 import { KubeObjectListLayout } from "../kube-object";
-import { INetworkPoliciesRouteParams } from "./network-policies.route";
+import { NetworkPoliciesRouteParams } from "./network-policies.route";
 import { networkPolicyStore } from "./network-policy.store";
 import { apiManager } from "../../api/api-manager";
 
@@ -17,22 +17,22 @@ enum sortBy {
   age = "age",
 }
 
-interface Props extends RouteComponentProps<INetworkPoliciesRouteParams> {
+interface Props extends RouteComponentProps<NetworkPoliciesRouteParams> {
 }
 
 @observer
 export class NetworkPolicies extends React.Component<Props> {
-  render() {
+  render(): JSX.Element {
     return (
       <KubeObjectListLayout
         className="NetworkPolicies" store={networkPolicyStore}
         sortingCallbacks={{
-          [sortBy.name]: (item: NetworkPolicy) => item.getName(),
-          [sortBy.namespace]: (item: NetworkPolicy) => item.getNs(),
-          [sortBy.age]: (item: NetworkPolicy) => item.metadata.creationTimestamp,
+          [sortBy.name]: (item: NetworkPolicy): string => item.getName(),
+          [sortBy.namespace]: (item: NetworkPolicy): string => item.getNs(),
+          [sortBy.age]: (item: NetworkPolicy): string => item.metadata.creationTimestamp,
         }}
         searchFilters={[
-          (item: NetworkPolicy) => item.getSearchFields(),
+          (item: NetworkPolicy): string[] => item.getSearchFields(),
         ]}
         renderHeaderTitle={<Trans>Network Policies</Trans>}
         renderTableHeader={[
@@ -41,26 +41,26 @@ export class NetworkPolicies extends React.Component<Props> {
           { title: <Trans>Policy Types</Trans>, className: "type" },
           { title: <Trans>Age</Trans>, className: "age", sortBy: sortBy.age },
         ]}
-        renderTableContents={(item: NetworkPolicy) => [
+        renderTableContents={(item: NetworkPolicy): (string | number)[] => [
           item.getName(),
           item.getNs(),
           item.getTypes().join(", "),
           item.getAge(),
         ]}
-        renderItemMenu={(item: NetworkPolicy) => {
-          return <NetworkPolicyMenu object={item}/>
+        renderItemMenu={(item: NetworkPolicy): JSX.Element => {
+          return <NetworkPolicyMenu object={item}/>;
         }}
       />
-    )
+    );
   }
 }
 
-export function NetworkPolicyMenu(props: KubeObjectMenuProps<NetworkPolicy>) {
+export function NetworkPolicyMenu(props: KubeObjectMenuProps<NetworkPolicy>): JSX.Element {
   return (
     <KubeObjectMenu {...props}/>
-  )
+  );
 }
 
 apiManager.registerViews(networkPolicyApi, {
   Menu: NetworkPolicyMenu,
-})
+});

dashboard/client/components/+network-policies/network-policy-details.tsx

@@ -1,10 +1,10 @@
-import "./network-policy-details.scss"
+import "./network-policy-details.scss";
 
 import get from "lodash/get";
 import React, { Fragment } from "react";
 import { t, Trans } from "@lingui/macro";
 import { DrawerItem, DrawerTitle } from "../drawer";
-import { IPolicyEgress, IPolicyIngress, IPolicyIpBlock, IPolicySelector, NetworkPolicy, networkPolicyApi } from "../../api/endpoints/network-policy.api";
+import { PolicyEgress, PolicyIngress, PolicyIpBlock, PolicySelector, NetworkPolicy, networkPolicyApi } from "../../api/endpoints/network-policy.api";
 import { Badge } from "../badge";
 import { SubTitle } from "../layout/sub-title";
 import { KubeEventDetails } from "../+events/kube-event-details";
@@ -19,18 +19,22 @@ interface Props extends KubeObjectDetailsProps<NetworkPolicy> {
 
 @observer
 export class NetworkPolicyDetails extends React.Component<Props> {
-  renderIngressFrom(ingress: IPolicyIngress) {
+  renderIngressFrom(ingress: PolicyIngress): JSX.Element {
     const { from } = ingress;
-    if (!from) return null;
+    if (!from) {
+      return null;
+    }
     return (
       <>
         <SubTitle title={<Trans>From</Trans>}/>
         {from.map(item =>
           Object.keys(item).map(key => {
-            const data = get(item, key)
+            const data = get(item, key);
             if (key === "ipBlock") {
-              const { cidr, except } = data as IPolicyIpBlock;
-              if (!cidr) return
+              const { cidr, except } = data as PolicyIpBlock;
+              if (!cidr) {
+                return;
+              }
               return (
                 <DrawerItem name={key} key={key}>
                   cidr: {cidr}, {" "}
@@ -38,9 +42,9 @@ export class NetworkPolicyDetails extends React.Component<Props> {
                   `except: ${except.join(", ")}`
                   }
                 </DrawerItem>
-              )
+              );
             }
-            const selector: IPolicySelector = data
+            const selector: PolicySelector = data;
             if (selector.matchLabels) {
               return (
                 <DrawerItem name={key} key={key}>
@@ -51,9 +55,8 @@ export class NetworkPolicyDetails extends React.Component<Props> {
                       .join(", ")
                   }
                 </DrawerItem>
-              )
-            }
-            else {
+              );
+            } else {
               return (<DrawerItem name={key} key={key}>(empty)</DrawerItem>);
             }
           })
@@ -62,17 +65,23 @@ export class NetworkPolicyDetails extends React.Component<Props> {
     );
   }
 
-  renderEgressTo(egress: IPolicyEgress) {
+  renderEgressTo(egress: PolicyEgress): JSX.Element | null {
     const { to } = egress;
-    if (!to) return null;
+    if (!to) {
+      return null;
+    }
     return (
       <>
         <SubTitle title={<Trans>To</Trans>}/>
         {to.map(item => {
-          const { ipBlock } = item
-          if (!ipBlock) return
-          const { cidr, except } = ipBlock
-          if (!cidr) return
+          const { ipBlock } = item;
+          if (!ipBlock) {
+            return;
+          }
+          const { cidr, except } = ipBlock;
+          if (!cidr) {
+            return;
+          }
           return (
             <DrawerItem name="ipBlock" key={cidr}>
               cidr: {cidr}, {" "}
@@ -80,13 +89,13 @@ export class NetworkPolicyDetails extends React.Component<Props> {
               `except: ${except.join(", ")}`
               }
             </DrawerItem>
-          )
+          );
         })}
       </>
     );
   }
 
-  render() {
+  render(): JSX.Element | null {
     const { object: policy } = this.props;
     if (!policy) {
       return null;
@@ -116,7 +125,7 @@ export class NetworkPolicyDetails extends React.Component<Props> {
                   </DrawerItem>
                   {this.renderIngressFrom(ingress)}
                 </Fragment>
-              )
+              );
             })}
           </>
         )}
@@ -133,7 +142,7 @@ export class NetworkPolicyDetails extends React.Component<Props> {
                   </DrawerItem>
                   {this.renderEgressTo(egress)}
                 </Fragment>
-              )
+              );
             })}
           </>
         )}
@@ -146,4 +155,4 @@ export class NetworkPolicyDetails extends React.Component<Props> {
 
 apiManager.registerViews(networkPolicyApi, {
   Details: NetworkPolicyDetails
-})
+});