hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

fix: Add check in release-tool for no relevant PRs (#7478)

Browse Source 
* fix: Add check in release-tool for no relevant PRs

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* fix: Change wording of message while picking PRs

Signed-off-by: Sebastian Malton <sebastian@malton.name>

---------

Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
Sebastian Malton 2023-04-03 13:05:04 -04:00 committed by GitHub
parent fef9443064
commit b22d7af291
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packages/release-tool/src/index.ts
View File

@ -316,6 +316,10 @@ async function cherryPickCommits(prs: ExtendedGithubPrData[]): Promise<void> {
} }
async function pickRelevantPrs(prs: ExtendedGithubPrData[], isMasterBranch: boolean): Promise<ExtendedGithubPrData[]> { async function pickRelevantPrs(prs: ExtendedGithubPrData[], isMasterBranch: boolean): Promise<ExtendedGithubPrData[]> {
if (prs.length === 0) {
throw new Error("Cannot pick relevant PRs for release if there are none. Are the milestones on github correct?");
}
if (isMasterBranch) { if (isMasterBranch) {
return prs; return prs;
} }
@ -324,7 +328,7 @@ async function pickRelevantPrs(prs: ExtendedGithubPrData[], isMasterBranch: bool
do { do {
selectedPrs = await pickWhichPRsToUse(prs); selectedPrs = await pickWhichPRsToUse(prs);
} while (selectedPrs.length === 0 && (console.warn("[WARNING]: must pick at least once commit"), true)); } while (selectedPrs.length === 0 && (console.warn("[WARNING]: must pick at least one commit"), true));
await cherryPickCommits(selectedPrs); await cherryPickCommits(selectedPrs);