From b2b9d021c79277c71349a82bfe9ced3819f4c93d Mon Sep 17 00:00:00 2001 From: Janne Savolainen Date: Tue, 19 Jul 2022 08:19:14 +0300 Subject: [PATCH] Mark functions causing side effects Signed-off-by: Janne Savolainen --- .../details/readme/call-for-helm-chart-readme.injectable.ts | 2 ++ .../details/versions/call-for-helm-chart-versions.injectable.ts | 2 ++ .../+helm-charts/helm-charts/call-for-helm-charts.injectable.ts | 2 +- .../chart-data/call-for-helm-chart-values.injectable.ts | 1 + 4 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/renderer/components/+helm-charts/details/readme/call-for-helm-chart-readme.injectable.ts b/src/renderer/components/+helm-charts/details/readme/call-for-helm-chart-readme.injectable.ts index aedbea79d1..ae9c99edeb 100644 --- a/src/renderer/components/+helm-charts/details/readme/call-for-helm-chart-readme.injectable.ts +++ b/src/renderer/components/+helm-charts/details/readme/call-for-helm-chart-readme.injectable.ts @@ -22,6 +22,8 @@ const callForHelmChartReadmeInjectable = getInjectable({ return details.readme; }, + + causesSideEffects: true, }); export default callForHelmChartReadmeInjectable; diff --git a/src/renderer/components/+helm-charts/details/versions/call-for-helm-chart-versions.injectable.ts b/src/renderer/components/+helm-charts/details/versions/call-for-helm-chart-versions.injectable.ts index 0648948ca8..a20f5b60e9 100644 --- a/src/renderer/components/+helm-charts/details/versions/call-for-helm-chart-versions.injectable.ts +++ b/src/renderer/components/+helm-charts/details/versions/call-for-helm-chart-versions.injectable.ts @@ -21,6 +21,8 @@ const callForHelmChartVersionsInjectable = getInjectable({ return details.versions; }, + + causesSideEffects: true, }); export default callForHelmChartVersionsInjectable; diff --git a/src/renderer/components/+helm-charts/helm-charts/call-for-helm-charts.injectable.ts b/src/renderer/components/+helm-charts/helm-charts/call-for-helm-charts.injectable.ts index 42fc9a4709..5edc0d7bea 100644 --- a/src/renderer/components/+helm-charts/helm-charts/call-for-helm-charts.injectable.ts +++ b/src/renderer/components/+helm-charts/helm-charts/call-for-helm-charts.injectable.ts @@ -10,8 +10,8 @@ export type CallForHelmCharts = () => Promise; const callForHelmChartsInjectable = getInjectable({ id: "call-for-helm-charts", - instantiate: (): CallForHelmCharts => async () => await listCharts(), + causesSideEffects: true, }); export default callForHelmChartsInjectable; diff --git a/src/renderer/components/dock/install-chart/chart-data/call-for-helm-chart-values.injectable.ts b/src/renderer/components/dock/install-chart/chart-data/call-for-helm-chart-values.injectable.ts index 78b18765f7..1c379b56e5 100644 --- a/src/renderer/components/dock/install-chart/chart-data/call-for-helm-chart-values.injectable.ts +++ b/src/renderer/components/dock/install-chart/chart-data/call-for-helm-chart-values.injectable.ts @@ -14,6 +14,7 @@ export type CallForHelmChartValues = ( const callForHelmChartValuesInjectable = getInjectable({ id: "call-for-helm-chart-values", instantiate: (): CallForHelmChartValues => getChartValues, + causesSideEffects: true, }); export default callForHelmChartValuesInjectable;