hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

fix lint, refactor a bit, not sure why it close() doesn't log (close not getting called?)

Browse Source 
Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>
This commit is contained in:
Jim Ehrismann 2023-04-05 17:14:02 -04:00
parent 30796eccff
commit b362e9ab44
3 changed files with 11 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/core/src/renderer/components/dock/create-resource/create-resource-templates.injectable.ts
View File

@ -15,7 +15,7 @@ const createResourceTemplatesInjectable = getInjectable({
instantiate: async (di) => {
const lensResourceTemplates = await di.inject(lensCreateResourceTemplatesInjectable);
const [ userResourceTemplates, ] = di.inject(userCreateResourceTemplatesInjectable);
const [ userResourceTemplates ] = di.inject(userCreateResourceTemplatesInjectable);
return computed((): GroupBase<{ label: string; value: string }>[] => {
const res = [

10
packages/core/src/renderer/components/dock/create-resource/stop-watching-user-templates-on-quit.injectable.ts
View File

@ -5,6 +5,7 @@
import { getInjectable } from "@ogre-tools/injectable";
import { beforeQuitOfBackEndInjectionToken } from "../../../../main/start-main-application/runnable-tokens/before-quit-of-back-end-injection-token";
import userTemplatesInjectable from "./user-templates.injectable";
import loggerInjectable from "../../../../common/logger.injectable";
const stopWatchingUserTemplatesOnQuitInjectable = getInjectable({
id: "stop-watching-user-templates-on-quit",
@ -14,10 +15,13 @@ const stopWatchingUserTemplatesOnQuitInjectable = getInjectable({
return {
id: "stop-watching-user-templates-on-quit",
run: () => {
const [, disposer] = di.inject(userTemplatesInjectable);
run: async () => {
const [, watcher] = di.inject(userTemplatesInjectable);
const logger = di.inject(loggerInjectable);
disposer();
logger.info("[USER-CREATE-RESOURCE-TEMPLATES]: stopping watch");
await watcher?.close();
},
};
},

11
packages/core/src/renderer/components/dock/create-resource/user-templates.injectable.ts
View File

@ -17,9 +17,8 @@ import homeDirectoryPathInjectable from "../../../../common/os/home-directory-pa
import getDirnameOfPathInjectable from "../../../../common/path/get-dirname.injectable";
import loggerInjectable from "../../../../common/logger.injectable";
import parsePathInjectable from "../../../../common/path/parse.injectable";
import type { Disposer } from "../../../../common/utils";
export type ResourceTemplates = [IComputedValue<RawTemplates[]>, Disposer];
export type ResourceTemplates = [IComputedValue<RawTemplates[]>, Watcher<false>|undefined];
const userCreateResourceTemplatesInjectable = getInjectable({
id: "user-create-resource-templates",
@ -101,7 +100,7 @@ const userCreateResourceTemplatesInjectable = getInjectable({
},
ignoreInitial: false,
atomic: 150, // for "atomic writes"
})
});
watcher
.on("add", onAddOrChange)
@ -112,11 +111,7 @@ const userCreateResourceTemplatesInjectable = getInjectable({
});
})();
return [computed(() => groupTemplates(templates)), () => {
logger.info("[USER-CREATE-RESOURCE-TEMPLATES]: stopping watch");
watcher?.close()
}];
return [computed(() => groupTemplates(templates)), watcher];
},
});