hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

chore!: Make linkable-push opt-in for shared build scripts

Browse Source 
This is because linkable-push is a non-deterministic side-effect, and
thus breaks fundamentals of nx-cacheing. Running it elsewhere in later
commit will give us best-of-both-worlds, where builds get cached, and
linkable-push still gets run automatically when required.

BREAKING CHANGE: Add "new LinkablePushPlugin()" in your
"plugins" of webpack.config to restore automatic linkable-push when
using "lens-webpack-build", "lens-webpack-build --watch" or just
"webpack".

Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Mikko Aspiala <mikko.aspiala@gmail.com>
This commit is contained in:
Iku-turso 2023-06-06 11:08:39 +03:00
parent aac6245e8c
commit b408d5693d
4 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
packages/infrastructure/webpack/index.ts
View File

@ -2,3 +2,4 @@ export { configForNode } from "./src/node-config";
export { configForReact } from "./src/react-config"; export { configForReact } from "./src/react-config";
export { getMultiExportConfig } from "./src/get-multi-export-config"; export { getMultiExportConfig } from "./src/get-multi-export-config";
export { doWebpackBuild } from "./do-webpack-build"; export { doWebpackBuild } from "./do-webpack-build";
export { LinkablePushPlugin } from "./src/plugins/linkable-push-plugin";

7
packages/infrastructure/webpack/src/__snapshots__/get-multi-export-config.test.ts.snap
View File

@ -26,8 +26,7 @@ exports[`get-multi-export-config given maximal package.json, when creating confi
} }
} }
} }
}, }
LinkablePushPlugin {}
], ],
output: { output: {
path: '/some-working-directory/dist', path: '/some-working-directory/dist',
@ -62,8 +61,7 @@ exports[`get-multi-export-config given maximal package.json, when creating confi
} }
} }
} }
}, }
LinkablePushPlugin {}
], ],
output: { output: {
path: '/some-working-directory/dist/some-entrypoint', path: '/some-working-directory/dist/some-entrypoint',
@ -99,7 +97,6 @@ exports[`get-multi-export-config given maximal package.json, when creating confi
} }
} }
}, },
LinkablePushPlugin {},
MiniCssExtractPlugin { MiniCssExtractPlugin {
_sortedModulesCache: WeakMap { <items unknown> }, _sortedModulesCache: WeakMap { <items unknown> },
options: { options: {

1
packages/infrastructure/webpack/src/__snapshots__/get-node-config.test.ts.snap
View File

@ -53,7 +53,6 @@ exports[`get-node-config given an environment, works 1`] = `
}, },
}, },
}, },
LinkablePushPlugin {},
], ],
"resolve": { "resolve": {
"extensions": [ "extensions": [

3
packages/infrastructure/webpack/src/get-node-config.ts
View File

@ -2,7 +2,6 @@ import ForkTsCheckerPlugin from "fork-ts-checker-webpack-plugin";
import type { Configuration } from "webpack"; import type { Configuration } from "webpack";
import { MakePeerDependenciesExternalPlugin } from "./plugins/make-peer-dependencies-external"; import { MakePeerDependenciesExternalPlugin } from "./plugins/make-peer-dependencies-external";
import { ProtectFromImportingNonDependencies } from "./plugins/protect-from-importing-non-dependencies"; import { ProtectFromImportingNonDependencies } from "./plugins/protect-from-importing-non-dependencies";
import { LinkablePushPlugin } from "./plugins/linkable-push-plugin";
import type { Environment } from "./runtime-values/environment"; import type { Environment } from "./runtime-values/environment";
export type GetNodeConfigParams = { export type GetNodeConfigParams = {
@ -49,8 +48,6 @@ export const getNodeConfig = ({
}, },
}, },
}), }),
new LinkablePushPlugin(),
], ],
output: { output: {