Refactor runnables (#6528)

* Convert runManyFor to use composite

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Convert runManySyncFor to use composite and to enfore sync-ness

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Remove dead code

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Convert getStartableStoppable to be always sync as it is never used in an async fashion

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Convert all sync runnables to comply with new checks for sync-ness

Signed-off-by: Sebastian Malton <sebastian@malton.name>

Signed-off-by: Sebastian Malton <sebastian@malton.name>

src/features/application-menu/main/application-menu-reactivity.injectable.ts

@@ -15,8 +15,9 @@ const applicationMenuReactivityInjectable = getInjectable({
     const applicationMenuItemComposite = di.inject(applicationMenuItemCompositeInjectable);
     const populateApplicationMenu = di.inject(populateApplicationMenuInjectable);
 
-    return getStartableStoppable("application-menu-reactivity", () =>
-      autorun(() => populateApplicationMenu(applicationMenuItemComposite.get()), {
+    return getStartableStoppable(
+      "application-menu-reactivity",
+      () => autorun(() => populateApplicationMenu(applicationMenuItemComposite.get()), {
         delay: 100,
       }),
     );

src/features/application-menu/main/stop-application-menu.injectable.ts

@@ -10,15 +10,11 @@ const stopApplicationMenuInjectable = getInjectable({
   id: "stop-application-menu",
 
   instantiate: (di) => {
-    const applicationMenu = di.inject(
-      applicationMenuReactivityInjectable,
-    );
+    const applicationMenu = di.inject(applicationMenuReactivityInjectable);
 
     return {
       id: "stop-application-menu",
-      run: async () => {
-        await applicationMenu.stop();
-      },
+      run: () => void applicationMenu.stop(),
     };
   },