Refactor runnables (#6528)

* Convert runManyFor to use composite

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Convert runManySyncFor to use composite and to enfore sync-ness

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Remove dead code

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Convert getStartableStoppable to be always sync as it is never used in an async fashion

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Convert all sync runnables to comply with new checks for sync-ness

Signed-off-by: Sebastian Malton <sebastian@malton.name>

Signed-off-by: Sebastian Malton <sebastian@malton.name>

src/main/start-main-application/runnable-tokens/before-electron-is-ready-injection-token.ts

@@ -5,7 +5,6 @@
 import { getInjectionToken } from "@ogre-tools/injectable";
 import type { RunnableSync } from "../../../common/runnable/run-many-sync-for";
 
-export const beforeElectronIsReadyInjectionToken =
-  getInjectionToken<RunnableSync>({
-    id: "before-electron-is-ready",
-  });
+export const beforeElectronIsReadyInjectionToken = getInjectionToken<RunnableSync>({
+  id: "before-electron-is-ready",
+});

src/main/start-main-application/runnable-tokens/before-quit-of-back-end-injection-token.ts

@@ -5,7 +5,6 @@
 import { getInjectionToken } from "@ogre-tools/injectable";
 import type { RunnableSync } from "../../../common/runnable/run-many-sync-for";
 
-export const beforeQuitOfBackEndInjectionToken =
-  getInjectionToken<RunnableSync>({
-    id: "before-quit-of-back-end",
-  });
+export const beforeQuitOfBackEndInjectionToken = getInjectionToken<RunnableSync>({
+  id: "before-quit-of-back-end",
+});

src/main/start-main-application/runnable-tokens/before-quit-of-front-end-injection-token.ts

@@ -5,7 +5,6 @@
 import { getInjectionToken } from "@ogre-tools/injectable";
 import type { RunnableSync } from "../../../common/runnable/run-many-sync-for";
 
-export const beforeQuitOfFrontEndInjectionToken =
-  getInjectionToken<RunnableSync>({
-    id: "before-quit-of-front-end",
-  });
+export const beforeQuitOfFrontEndInjectionToken = getInjectionToken<RunnableSync>({
+  id: "before-quit-of-front-end",
+});

src/main/start-main-application/runnables/clean-up-shell-sessions.injectable.ts

@@ -11,9 +11,7 @@ const cleanUpShellSessionsInjectable = getInjectable({
 
   instantiate: () => ({
     id: "clean-up-shell-sessions",
-    run: () => {
-      ShellSession.cleanup();
-    },
+    run: () => void ShellSession.cleanup(),
   }),
 
   injectionToken: beforeQuitOfBackEndInjectionToken,

src/main/start-main-application/runnables/emit-close-to-event-bus.injectable.ts

@@ -16,6 +16,8 @@ const emitCloseToEventBusInjectable = getInjectable({
       id: "emit-close-to-event-bus",
       run: () => {
         emitAppEvent({ name: "app", action: "close" });
+
+        return undefined;
       },
     };
   },

src/main/start-main-application/runnables/flag-renderer/flag-renderer-as-not-loaded.injectable.ts

@@ -20,6 +20,8 @@ const flagRendererAsNotLoadedInjectable = getInjectable({
           // Todo: remove this kludge which enables out-of-place temporal dependency.
           lensProtocolRouterMain.rendererLoaded = false;
         });
+
+        return undefined;
       },
     };
   },

src/main/start-main-application/runnables/kube-config-sync/stop-kube-config-sync.injectable.ts

@@ -14,9 +14,7 @@ const stopKubeConfigSyncInjectable = getInjectable({
 
     return {
       id: "stop-kube-config-sync",
-      run: () => {
-        kubeConfigSyncManager.stopSync();
-      },
+      run: () => void kubeConfigSyncManager.stopSync(),
     };
   },
 

src/main/start-main-application/runnables/sentry/setup.injectable.ts

@@ -15,7 +15,7 @@ const setupSentryInjectable = getInjectable({
 
     return {
       id: "setup-sentry",
-      run: () => initializeSentryReportingWith(initializeSentryOnMain),
+      run: () => void initializeSentryReportingWith(initializeSentryOnMain),
     };
   },
   injectionToken: beforeElectronIsReadyInjectionToken,

src/main/start-main-application/runnables/setup-hardware-acceleration.injectable.ts

@@ -20,6 +20,8 @@ const setupHardwareAccelerationInjectable = getInjectable({
         if (hardwareAccelerationShouldBeDisabled) {
           disableHardwareAcceleration();
         }
+
+        return undefined;
       },
     };
   },

src/main/start-main-application/runnables/setup-immer.injectable.ts

@@ -16,6 +16,8 @@ const setupImmerInjectable = getInjectable({
       // Required in `utils/storage-helper.ts`
       Immer.setAutoFreeze(false); // allow to merge mobx observables
       Immer.enableMapSet(); // allow to merge maps and sets
+
+      return undefined;
     },
   }),
 

src/main/start-main-application/runnables/setup-mobx.injectable.ts

@@ -21,6 +21,8 @@ const setupMobxInjectable = getInjectable({
         // reactionRequiresObservable: true,
         // observableRequiresReaction: true,
       });
+
+      return undefined;
     },
   }),
 

src/main/start-main-application/runnables/setup-proxy-env.injectable.ts

@@ -34,6 +34,8 @@ const setupProxyEnvInjectable = getInjectable({
         if (getCommandLineSwitch("proxy-server") !== "") {
           process.env.HTTPS_PROXY = getCommandLineSwitch("proxy-server");
         }
+
+        return undefined;
       },
     };
   },

src/main/start-main-application/runnables/stop-cluster-manager.injectable.ts

@@ -16,13 +16,13 @@ const stopClusterManagerInjectable = getInjectable({
       id: "stop-cluster-manager",
       run: () => {
         clusterManager.stop();
+
+        return undefined;
       },
     };
   },
 
   injectionToken: beforeQuitOfFrontEndInjectionToken,
-
-  causesSideEffects: true,
 });
 
 export default stopClusterManagerInjectable;