Correctly handle empty string valued secrets in SecretDetails (#4079)

This commit is contained in:
Sebastian Malton authored and GitHub committed 2021-10-20 08:51:03 -04:00
1 parent 38276bbbff
commit b4a4cc6be4
4 files changed
+125 -58

No files matched your search

@@ -0,0 +1,49 @@
/**
* Copyright (c) 2021 OpenLens Authors
*
* Permission is hereby granted, free of charge, to any person obtaining a copy of
* this software and associated documentation files (the "Software"), to deal in
* the Software without restriction, including without limitation the rights to
* use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of
* the Software, and to permit persons to whom the Software is furnished to do so,
* subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in all
* copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
* FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
* COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
* IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
* CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
*/
import React from "react";
import { render } from "@testing-library/react";
import { SecretDetails } from "../secret-details";
import { Secret, SecretType } from "../../../../common/k8s-api/endpoints";
jest.mock("../../kube-object-meta/kube-object-meta");
describe("SecretDetails tests", () => {
it("should show the visibility toggle when the secret value is ''", () => {
const secret = new Secret({
apiVersion: "v1",
kind: "secret",
metadata: {
name: "test",
resourceVersion: "1",
uid: "uid"
},
data: {
foobar: "",
},
type: SecretType.Opaque,
});
const result = render(<SecretDetails object={secret}/>);
expect(result.getByTestId("foobar-secret-entry").querySelector(".Icon")).toBeDefined();
});
});