1
0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00

chore: Use new typings of metrics components

Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
Sebastian Malton 2023-04-27 10:38:08 -04:00
parent 8f8f77550f
commit b4d5732071
2 changed files with 31 additions and 19 deletions

View File

@ -6,17 +6,25 @@ import type { KubeObjectDetailMetrics } from "@k8slens/metrics";
import type { IComputedValue } from "mobx"; import type { IComputedValue } from "mobx";
import { observer } from "mobx-react"; import { observer } from "mobx-react";
import React from "react"; import React from "react";
import type { KubeObject } from "../../../../../common/k8s-api/kube-object"; import type { KubeObject } from "@k8slens/kube-object";
interface DetailsMetricsContainerProps<Kube extends KubeObject = KubeObject> { export interface DetailsMetricsContainerProps<K extends KubeObject> {
metrics: IComputedValue<KubeObjectDetailMetrics[]>; metrics: IComputedValue<KubeObjectDetailMetrics<K>[]>;
object?: Kube; object?: K;
} }
export const DetailsMetricsContainer = observer(({ metrics, object }: DetailsMetricsContainerProps) => ( function NonObservingDetailsMetricsContainer<K extends KubeObject>({ metrics, object }: DetailsMetricsContainerProps<K>) {
<> if (!object) {
{metrics.get().map((metrics) => ( return null;
<metrics.Component object={object} key={metrics.id} /> }
))}
</> return (
)); <>
{metrics.get().map((metrics) => (
<metrics.Component object={object} key={metrics.id} />
))}
</>
);
}
export const DetailsMetricsContainer = observer(NonObservingDetailsMetricsContainer);

View File

@ -12,20 +12,24 @@ import type { KubeObjectDetailItem } from "../kube-object-detail-item-injection-
import { DetailsMetricsContainer } from "./details-metrics-container"; import { DetailsMetricsContainer } from "./details-metrics-container";
import { computedInjectManyInjectable } from "@ogre-tools/injectable-extension-for-mobx"; import { computedInjectManyInjectable } from "@ogre-tools/injectable-extension-for-mobx";
import type { KubeObjectDetailsProps } from "../../kube-object-details"; import type { KubeObjectDetailsProps } from "../../kube-object-details";
import type { KubeObject } from "@k8slens/kube-object";
type GetMetricsKubeObjectDetailItem = (token: InjectionToken<KubeObjectDetailMetrics, void>, metricResourceType: ClusterMetricsResourceType) => KubeObjectDetailItem; export type GetMetricsKubeObjectDetailItem = <K extends KubeObject>(token: InjectionToken<KubeObjectDetailMetrics<K>, void>, metricResourceType: ClusterMetricsResourceType) => KubeObjectDetailItem;
export const getMetricsKubeObjectDetailItemInjectable = getInjectable({ export const getMetricsKubeObjectDetailItemInjectable = getInjectable({
id: "get-metrics-kube-object-detail-item", id: "get-metrics-kube-object-detail-item",
instantiate: (di) : GetMetricsKubeObjectDetailItem => (token, metricResourceType) => { instantiate: (di): GetMetricsKubeObjectDetailItem => {
const computedInjectedMany = di.inject(computedInjectManyInjectable); const computedInjectedMany = di.inject(computedInjectManyInjectable);
const metrics = computedInjectedMany(token);
const Component = (props: KubeObjectDetailsProps<any>) => <DetailsMetricsContainer metrics={metrics} {...props} />;
return { return <K extends KubeObject>(token: InjectionToken<KubeObjectDetailMetrics<K>, void>, metricResourceType: ClusterMetricsResourceType) => {
Component, const metrics = computedInjectedMany(token);
enabled: di.inject(metricsDetailsComponentEnabledInjectable, metricResourceType), const Component = (props: KubeObjectDetailsProps<K>) => <DetailsMetricsContainer<K> metrics={metrics} {...props} />;
orderNumber: -1,
return {
Component,
enabled: di.inject(metricsDetailsComponentEnabledInjectable, metricResourceType),
orderNumber: -1,
};
}; };
}, },
}); });