Improve documentation of Singleton functions, change to createInstance (#2585)

Signed-off-by: Sebastian Malton <sebastian@malton.name>

src/extensions/__tests__/extension-discovery.test.ts

@@ -21,7 +21,7 @@ describe("ExtensionDiscovery", () => {
   beforeEach(() => {
     ExtensionDiscovery.resetInstance();
     ExtensionsStore.resetInstance();
-    ExtensionsStore.getInstanceOrCreate();
+    ExtensionsStore.createInstance();
   });
 
   it("emits add for added extension", async done => {
@@ -43,7 +43,7 @@ describe("ExtensionDiscovery", () => {
     mockedWatch.mockImplementationOnce(() =>
       (mockWatchInstance) as any
     );
-    const extensionDiscovery = ExtensionDiscovery.getInstanceOrCreate();
+    const extensionDiscovery = ExtensionDiscovery.createInstance();
 
     // Need to force isLoaded to be true so that the file watching is started
     extensionDiscovery.isLoaded = true;
@@ -83,7 +83,7 @@ describe("ExtensionDiscovery", () => {
     mockedWatch.mockImplementationOnce(() =>
       (mockWatchInstance) as any
     );
-    const extensionDiscovery = ExtensionDiscovery.getInstanceOrCreate();
+    const extensionDiscovery = ExtensionDiscovery.createInstance();
 
     // Need to force isLoaded to be true so that the file watching is started
     extensionDiscovery.isLoaded = true;

src/extensions/__tests__/extension-loader.test.ts

@@ -110,7 +110,7 @@ describe("ExtensionLoader", () => {
   });
 
   it.only("renderer updates extension after ipc broadcast", async (done) => {
-    const extensionLoader = ExtensionLoader.getInstanceOrCreate();
+    const extensionLoader = ExtensionLoader.createInstance();
 
     expect(extensionLoader.userExtensions).toMatchInlineSnapshot(`Map {}`);
 
@@ -155,7 +155,7 @@ describe("ExtensionLoader", () => {
     // Disable sending events in this test
     (ipcRenderer.on as any).mockImplementation();
 
-    const extensionLoader = ExtensionLoader.getInstanceOrCreate();
+    const extensionLoader = ExtensionLoader.createInstance();
 
     await extensionLoader.init();