Improve documentation of Singleton functions, change to createInstance (#2585)

Signed-off-by: Sebastian Malton <sebastian@malton.name>

src/renderer/bootstrap.tsx

@@ -51,16 +51,16 @@ export async function bootstrap(App: AppComponent) {
   await attachChromeDebugger();
   rootElem.classList.toggle("is-mac", isMac);
 
-  ExtensionLoader.getInstanceOrCreate().init();
-  ExtensionDiscovery.getInstanceOrCreate().init();
+  ExtensionLoader.createInstance().init();
+  ExtensionDiscovery.createInstance().init();
 
-  const userStore = UserStore.getInstanceOrCreate();
-  const clusterStore = ClusterStore.getInstanceOrCreate();
-  const extensionsStore = ExtensionsStore.getInstanceOrCreate();
-  const filesystemStore = FilesystemProvisionerStore.getInstanceOrCreate();
-  const themeStore = ThemeStore.getInstanceOrCreate();
-  const hotbarStore = HotbarStore.getInstanceOrCreate();
-  const helmRepoManager = HelmRepoManager.getInstanceOrCreate();
+  const userStore = UserStore.createInstance();
+  const clusterStore = ClusterStore.createInstance();
+  const extensionsStore = ExtensionsStore.createInstance();
+  const filesystemStore = FilesystemProvisionerStore.createInstance();
+  const themeStore = ThemeStore.createInstance();
+  const hotbarStore = HotbarStore.createInstance();
+  const helmRepoManager = HelmRepoManager.createInstance();
 
   // preload common stores
   await Promise.all([

src/renderer/components/+extensions/__tests__/extensions.test.tsx

@@ -42,16 +42,16 @@ describe("Extensions", () => {
     UserStore.resetInstance();
     ThemeStore.resetInstance();
 
-    await UserStore.getInstanceOrCreate().load();
-    await ThemeStore.getInstanceOrCreate().init();
+    await UserStore.createInstance().load();
+    await ThemeStore.createInstance().init();
 
     ExtensionLoader.resetInstance();
     ExtensionDiscovery.resetInstance();
     Extensions.installStates.clear();
 
-    ExtensionDiscovery.getInstanceOrCreate().uninstallExtension = jest.fn(() => Promise.resolve());
+    ExtensionDiscovery.createInstance().uninstallExtension = jest.fn(() => Promise.resolve());
 
-    ExtensionLoader.getInstanceOrCreate().addExtension({
+    ExtensionLoader.createInstance().addExtension({
       id: "extensionId",
       manifest: {
         name: "test",

src/renderer/components/dock/__test__/log-resource-selector.test.tsx

@@ -44,8 +44,8 @@ const getFewPodsTabData = (): LogTabData => {
 
 describe("<LogResourceSelector />", () => {
   beforeEach(() => {
-    UserStore.getInstanceOrCreate();
-    ThemeStore.getInstanceOrCreate();
+    UserStore.createInstance();
+    ThemeStore.createInstance();
   });
 
   afterEach(() => {

src/renderer/components/layout/__test__/main-layout-header.test.tsx

@@ -16,7 +16,7 @@ const cluster: Cluster = new Cluster({
 
 describe("<MainLayoutHeader />", () => {
   beforeEach(() => {
-    ClusterStore.getInstanceOrCreate();
+    ClusterStore.createInstance();
   });
 
   afterEach(() => {

src/renderer/lens-app.tsx

@@ -25,7 +25,7 @@ export class LensApp extends React.Component {
   static async init() {
     catalogEntityRegistry.init();
     ExtensionLoader.getInstance().loadOnClusterManagerRenderer();
-    LensProtocolRouterRenderer.getInstanceOrCreate().init();
+    LensProtocolRouterRenderer.createInstance().init();
     bindProtocolAddRouteHandlers();
 
     window.addEventListener("offline", () => broadcastMessage("network:offline"));

src/renderer/utils/__tests__/storageHelper.test.ts

@@ -5,7 +5,7 @@ import { ClusterStore } from "../../../common/cluster-store";
 
 describe("renderer/utils/StorageHelper", () => {
   beforeEach(() => {
-    ClusterStore.getInstanceOrCreate();
+    ClusterStore.createInstance();
   });
 
   afterEach(() => {