From b6f6094e3e16def514518049560777982f0fabdc Mon Sep 17 00:00:00 2001 From: Roman Date: Fri, 4 Sep 2020 16:19:19 +0300 Subject: [PATCH] extensions-api -- fix: activating extensions only in mainFrame (cluster-manager scope view) Signed-off-by: Roman --- .../example-extension/example-extension.ts | 7 +------ src/extensions/extension-store.ts | 12 +++++++----- 2 files changed, 8 insertions(+), 11 deletions(-) diff --git a/src/extensions/example-extension/example-extension.ts b/src/extensions/example-extension/example-extension.ts index e100eb85be..fa9409bd17 100644 --- a/src/extensions/example-extension/example-extension.ts +++ b/src/extensions/example-extension/example-extension.ts @@ -6,11 +6,6 @@ import { LensExtension } from "@lens/extensions"; // fixme: map to generated typ export default class ExampleExtension extends LensExtension { async activate(): Promise { await super.activate(); - console.warn('EXAMPLE EXTENSION: ACTIVATE'.padStart(10, "-")); - } - - async deactivate(): Promise { - console.warn('EXAMPLE EXTENSION: DEACTIVATE'.padStart(10, "-")) - await super.deactivate(); + console.warn('EXAMPLE EXTENSION: ACTIVATE'); } } diff --git a/src/extensions/extension-store.ts b/src/extensions/extension-store.ts index 8f561b7a89..3cd965654f 100644 --- a/src/extensions/extension-store.ts +++ b/src/extensions/extension-store.ts @@ -77,11 +77,13 @@ export class ExtensionStore extends BaseStore { this.installed.replace(extensions.map(ext => [ext.manifestPath, ext])); // todo: remove - extensions.forEach(({ extensionModule, manifest }) => { - const LensExtension = extensionModule.default; - const instance = new LensExtension({ ...manifest }, manifest); - instance.activate(); - }) + if (process.isMainFrame) { + extensions.forEach(({ extensionModule, manifest }) => { + const LensExtension = extensionModule.default; + const instance = new LensExtension({ ...manifest }, manifest); + instance.activate(); + }) + } } async loadExtensions(folderPath: string): Promise {