From b756eb33237fb45b3845e62abf629cfbb3ab7581 Mon Sep 17 00:00:00 2001 From: Jim Ehrismann Date: Fri, 5 Feb 2021 14:20:04 -0500 Subject: [PATCH] more review comment addressing, added overview to workspace command palette Signed-off-by: Jim Ehrismann --- .../+landing-page/workspace-cluster.store.ts | 2 +- .../components/+landing-page/workspace-overview.scss | 2 ++ src/renderer/components/+workspaces/workspaces.tsx | 10 ++++++++++ 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/src/renderer/components/+landing-page/workspace-cluster.store.ts b/src/renderer/components/+landing-page/workspace-cluster.store.ts index a6260f3d2a..dcecd63d31 100644 --- a/src/renderer/components/+landing-page/workspace-cluster.store.ts +++ b/src/renderer/components/+landing-page/workspace-cluster.store.ts @@ -46,7 +46,7 @@ export class WorkspaceClusterStore extends ItemStore { const clusterId = cluster.id; - return super.removeItem(clusterItem, async () => clusterStore.removeById(clusterId)); + return super.removeItem(clusterItem, () => clusterStore.removeById(clusterId)); } async removeSelectedItems() { diff --git a/src/renderer/components/+landing-page/workspace-overview.scss b/src/renderer/components/+landing-page/workspace-overview.scss index 1d6e16a383..8b341e62a7 100644 --- a/src/renderer/components/+landing-page/workspace-overview.scss +++ b/src/renderer/components/+landing-page/workspace-overview.scss @@ -1,4 +1,6 @@ .WorkspaceOverview { + background-color: var(--mainBackground); + .TableCell { display: flex; align-items: left; diff --git a/src/renderer/components/+workspaces/workspaces.tsx b/src/renderer/components/+workspaces/workspaces.tsx index 7e3b9647f2..9c7167a826 100644 --- a/src/renderer/components/+workspaces/workspaces.tsx +++ b/src/renderer/components/+workspaces/workspaces.tsx @@ -14,6 +14,7 @@ import { clusterViewURL } from "../cluster-manager/cluster-view.route"; @observer export class ChooseWorkspace extends React.Component { + private static overviewActionId = "__overview__"; private static addActionId = "__add__"; private static removeActionId = "__remove__"; private static editActionId = "__edit__"; @@ -23,6 +24,8 @@ export class ChooseWorkspace extends React.Component { return { value: workspace.id, label: workspace.name }; }); + options.push({ value: ChooseWorkspace.overviewActionId, label: "Workspace: Overview" }); + options.push({ value: ChooseWorkspace.addActionId, label: "Add workspace ..." }); if (options.length > 1) { @@ -37,6 +40,13 @@ export class ChooseWorkspace extends React.Component { } onChange(id: string) { + if (id === ChooseWorkspace.overviewActionId) { + navigate(landingURL()); // overview of active workspace. TODO: change name from landing + CommandOverlay.close(); + + return; + } + if (id === ChooseWorkspace.addActionId) { CommandOverlay.open();