From b9450fe1bd8af3384511e6f8727471f2beb564b7 Mon Sep 17 00:00:00 2001 From: Marc Bachmann Date: Wed, 21 Apr 2021 14:51:46 +0200 Subject: [PATCH] Fix chart upgrade screen by coercing the chart version to semver Without that fix, I'm seeing such an errors when upgrading a chart: ``` semver.js:41 Uncaught (in promise) TypeError: Invalid Version: 1.9-dev at new A (semver.js:41) at Object.e.exports [as compare] (compare.js:3) at helm-chart.store.ts:37 at Array.sort () at QR.sortVersions (helm-chart.store.ts:36) at async QR.getVersions (helm-chart.store.ts:64) at async XD.loadVersions (upgrade-chart.tsx:57) ``` Signed-off-by: Marc Bachmann --- .../components/+apps-helm-charts/helm-chart.store.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/renderer/components/+apps-helm-charts/helm-chart.store.ts b/src/renderer/components/+apps-helm-charts/helm-chart.store.ts index 70c130dca5..25559a9711 100644 --- a/src/renderer/components/+apps-helm-charts/helm-chart.store.ts +++ b/src/renderer/components/+apps-helm-charts/helm-chart.store.ts @@ -34,7 +34,10 @@ export class HelmChartStore extends ItemStore { protected sortVersions = (versions: IChartVersion[]) => { return versions.sort((first, second) => { - return semver.compare(second.version, first.version); + const firstVersion = semver.coerce(first.version || 0); + const secondVersion = semver.coerce(second.version || 0); + + return semver.compare(secondVersion, firstVersion); }); };