hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Fix light theme pin icon visibility (#4477)

Browse Source 
* Remove what-input dependency

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>

* Use focus-visible prop and color fix in Icon

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
This commit is contained in:
Alex Andreev 2021-12-02 11:12:16 +03:00 committed by Sebastian Malton
parent 521e2f635c
commit b96be04586
5 changed files with 2 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
package.json
View File

@ -380,7 +380,6 @@
"webpack-cli": "^3.3.12", "webpack-cli": "^3.3.12",
"webpack-dev-server": "^3.11.2", "webpack-dev-server": "^3.11.2",
"webpack-node-externals": "^1.7.2", "webpack-node-externals": "^1.7.2",
"what-input": "^5.2.10",
"xterm": "^4.14.1", "xterm": "^4.14.1",
"xterm-addon-fit": "^0.5.0" "xterm-addon-fit": "^0.5.0"
} }

3
src/renderer/cluster-frame.tsx
View File

@ -38,7 +38,6 @@ import { ClusterPageRegistry, getExtensionPageUrl } from "../extensions/registri
import { ExtensionLoader } from "../extensions/extension-loader"; import { ExtensionLoader } from "../extensions/extension-loader";
import { appEventBus } from "../common/event-bus"; import { appEventBus } from "../common/event-bus";
import { requestMain } from "../common/ipc"; import { requestMain } from "../common/ipc";
import whatInput from "what-input";
import { clusterSetFrameIdHandler } from "../common/cluster-ipc"; import { clusterSetFrameIdHandler } from "../common/cluster-ipc";
import { ClusterPageMenuRegistration, ClusterPageMenuRegistry } from "../extensions/registries"; import { ClusterPageMenuRegistration, ClusterPageMenuRegistry } from "../extensions/registries";
import { StatefulSetScaleDialog } from "./components/+workloads-statefulsets/statefulset-scale-dialog"; import { StatefulSetScaleDialog } from "./components/+workloads-statefulsets/statefulset-scale-dialog";
@ -122,8 +121,6 @@ export class ClusterFrame extends React.Component {
unmountComponentAtNode(rootElem); unmountComponentAtNode(rootElem);
}; };
whatInput.ask(); // Start to monitor user input device
const clusterContext = new FrameContext(cluster); const clusterContext = new FrameContext(cluster);
// Setup hosted cluster context // Setup hosted cluster context

12
src/renderer/components/icon/icon.scss
View File

@ -127,7 +127,7 @@
} }
&.active { &.active {
color: var(--color-active); color: var(--textColorAccent);
box-shadow: 0 0 0 2px var(--iconActiveBackground); box-shadow: 0 0 0 2px var(--iconActiveBackground);
background-color: var(--iconActiveBackground); background-color: var(--iconActiveBackground);
} }
@ -137,16 +137,8 @@
transition: 250ms color, 250ms opacity, 150ms background-color, 150ms box-shadow; transition: 250ms color, 250ms opacity, 150ms background-color, 150ms box-shadow;
border-radius: var(--border-radius); border-radius: var(--border-radius);
&.focusable:focus:not(:hover) { &.focusable:focus-visible {
box-shadow: 0 0 0 2px var(--focus-color); box-shadow: 0 0 0 2px var(--focus-color);
[data-whatintent='mouse'] & {
box-shadow: none;
&.active {
box-shadow: 0 0 0 2px var(--iconActiveBackground);
}
}
} }
&:hover { &:hover {

1
src/renderer/components/layout/sidebar-cluster.module.css
View File

@ -32,7 +32,6 @@
&:focus-visible { &:focus-visible {
.dropdown { .dropdown {
box-shadow: 0 0 0 2px var(--focus-color); box-shadow: 0 0 0 2px var(--focus-color);
color: white;
} }
} }

5
yarn.lock
View File

@ -14370,11 +14370,6 @@ websocket-extensions@>=0.1.1:
resolved "https://registry.yarnpkg.com/websocket-extensions/-/websocket-extensions-0.1.4.tgz#7f8473bc839dfd87608adb95d7eb075211578a42" resolved "https://registry.yarnpkg.com/websocket-extensions/-/websocket-extensions-0.1.4.tgz#7f8473bc839dfd87608adb95d7eb075211578a42"
integrity sha512-OqedPIGOfsDlo31UNwYbCFMSaO9m9G/0faIHj5/dZFDMFqPTcx6UwqyOy3COEaEOg/9VsGIpdqn62W5KhoKSpg== integrity sha512-OqedPIGOfsDlo31UNwYbCFMSaO9m9G/0faIHj5/dZFDMFqPTcx6UwqyOy3COEaEOg/9VsGIpdqn62W5KhoKSpg==
what-input@^5.2.10:
version "5.2.10"
resolved "https://registry.yarnpkg.com/what-input/-/what-input-5.2.10.tgz#f79f5b65cf95d75e55e6d580bb0a6b98174cad4e"
integrity sha512-7AQoIMGq7uU8esmKniOtZG3A+pzlwgeyFpkS3f/yzRbxknSL68tvn5gjE6bZ4OMFxCPjpaBd2udUTqlZ0HwrXQ==
whatwg-encoding@^1.0.5: whatwg-encoding@^1.0.5:
version "1.0.5" version "1.0.5"
resolved "https://registry.yarnpkg.com/whatwg-encoding/-/whatwg-encoding-1.0.5.tgz#5abacf777c32166a51d085d6b4f3e7d27113ddb0" resolved "https://registry.yarnpkg.com/whatwg-encoding/-/whatwg-encoding-1.0.5.tgz#5abacf777c32166a51d085d6b4f3e7d27113ddb0"