From 96ce8bbdb990e630c00948aa8a291fc8ed32418c Mon Sep 17 00:00:00 2001 From: Alex Andreev Date: Fri, 17 Feb 2023 11:06:03 +0300 Subject: [PATCH] Remove async from instantiating LogTabViewModel Signed-off-by: Alex Andreev --- .../components/dock/logs/logs-view-model.injectable.ts | 2 +- packages/core/src/renderer/components/dock/logs/view.tsx | 7 ++----- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/packages/core/src/renderer/components/dock/logs/logs-view-model.injectable.ts b/packages/core/src/renderer/components/dock/logs/logs-view-model.injectable.ts index e174d6dc4d..4f02ea7eb6 100644 --- a/packages/core/src/renderer/components/dock/logs/logs-view-model.injectable.ts +++ b/packages/core/src/renderer/components/dock/logs/logs-view-model.injectable.ts @@ -28,7 +28,7 @@ export interface InstantiateArgs { const logsViewModelInjectable = getInjectable({ id: "logs-view-model", - instantiate: async (di, tabId: TabId) => new LogTabViewModel(tabId, { + instantiate: (di, tabId) => new LogTabViewModel(tabId, { getLogs: di.inject(getLogsInjectable), getLogsWithoutTimestamps: di.inject(getLogsWithoutTimestampsInjectable), getTimestampSplitLogs: di.inject(getTimestampSplitLogsInjectable), diff --git a/packages/core/src/renderer/components/dock/logs/view.tsx b/packages/core/src/renderer/components/dock/logs/view.tsx index 03f9cb9cc0..228c3dd922 100644 --- a/packages/core/src/renderer/components/dock/logs/view.tsx +++ b/packages/core/src/renderer/components/dock/logs/view.tsx @@ -20,7 +20,6 @@ import type { SubscribeStores } from "../../../kube-watch-api/kube-watch-api"; import subscribeStoresInjectable from "../../../kube-watch-api/subscribe-stores.injectable"; import type { PodStore } from "../../+workloads-pods/store"; import podStoreInjectable from "../../+workloads-pods/store.injectable"; -import { Spinner } from "../../spinner"; export interface LogsDockTabProps { className?: string; @@ -100,11 +99,9 @@ const NonInjectedLogsDockTab = observer(({ export const LogsDockTab = withInjectables(NonInjectedLogsDockTab, { - getPlaceholder: () => , - - getProps: async (di, props) => ({ + getProps: (di, props) => ({ ...props, - model: await di.inject(logsViewModelInjectable, props.tab.id), + model: di.inject(logsViewModelInjectable, props.tab.id), subscribeStores: di.inject(subscribeStoresInjectable), podStore: di.inject(podStoreInjectable), }),