From bc3a8794cc46452370e5e12b6d4833212ffa0115 Mon Sep 17 00:00:00 2001 From: Mikko Aspiala Date: Fri, 5 Nov 2021 14:07:39 +0200 Subject: [PATCH] Add unit test for missing namespace when removing a kube object We almost forgot to test this, because we started without TDD. Co-authored-by: Janne Savolainen Signed-off-by: Mikko Aspiala --- .../kube-object-menu.test.tsx.snap | 204 ++++++++++++++++++ .../kube-object-menu.test.tsx | 79 +++++++ 2 files changed, 283 insertions(+) diff --git a/src/renderer/components/kube-object-menu/__snapshots__/kube-object-menu.test.tsx.snap b/src/renderer/components/kube-object-menu/__snapshots__/kube-object-menu.test.tsx.snap index 0836ac62ab..8993dfbd16 100644 --- a/src/renderer/components/kube-object-menu/__snapshots__/kube-object-menu.test.tsx.snap +++ b/src/renderer/components/kube-object-menu/__snapshots__/kube-object-menu.test.tsx.snap @@ -108,6 +108,210 @@ exports[`kube-object-menu given kube object when removing kube object renders 1` +
+

+ Remove + some-kind + + + some-namespace/some-name + + from + + Some cluster name + + ? +

+
+ +
+ + +
+ + + + +`; + +exports[`kube-object-menu given kube object with namespace when removing kube object, renders confirmation dialog with namespace 1`] = ` + +
+
+
    +
    + Some menu item +
    +
  • + + + delete + +
    + + + Remove + +
    • +
+
+
+
+
+
+ + + warning + + + +
+

+ Remove + some-kind + + + some-namespace/some-name + + from + + Some cluster name + + ? +

+
+
+
+ + +
+
+
+ + +`; + +exports[`kube-object-menu given kube object without namespace when removing kube object, renders confirmation dialog without namespace 1`] = ` + +
+
+
    +
    + Some menu item +
    +
  • + + + delete + +
    + + + Remove + +
    • +
+
+
+
+
+
+ + + warning + + +

Remove diff --git a/src/renderer/components/kube-object-menu/kube-object-menu.test.tsx b/src/renderer/components/kube-object-menu/kube-object-menu.test.tsx index 2097baea05..7ca3ef6a44 100644 --- a/src/renderer/components/kube-object-menu/kube-object-menu.test.tsx +++ b/src/renderer/components/kube-object-menu/kube-object-menu.test.tsx @@ -117,6 +117,7 @@ describe("kube-object-menu", () => { uid: "some-uid", name: "some-name", resourceVersion: "some-resource-version", + namespace: "some-namespace", }, }); @@ -181,4 +182,82 @@ describe("kube-object-menu", () => { }); }); }); + + describe("given kube object with namespace", () => { + let baseElement: Element; + let getByTestId: (arg0: string) => any; + + beforeEach(async () => { + objectStub = KubeObject.create({ + apiVersion: "some-api-version", + kind: "some-kind", + metadata: { + uid: "some-uid", + name: "some-name", + resourceVersion: "some-resource-version", + namespace: "some-namespace", + }, + }); + + ({ baseElement, getByTestId } = render( +

+ + + {}} + /> +
, + )); + }); + + it("when removing kube object, renders confirmation dialog with namespace", () => { + const menuItem = getByTestId("menu-action-remove"); + + userEvent.click(menuItem); + + expect(baseElement).toMatchSnapshot(); + }); + }); + + describe("given kube object without namespace", () => { + let baseElement: Element; + let getByTestId: (arg0: string) => any; + + beforeEach(async () => { + objectStub = KubeObject.create({ + apiVersion: "some-api-version", + kind: "some-kind", + metadata: { + uid: "some-uid", + name: "some-name", + resourceVersion: "some-resource-version", + namespace: undefined, + }, + }); + + ({ baseElement, getByTestId } = render( +
+ + + {}} + /> +
, + )); + }); + + it("when removing kube object, renders confirmation dialog without namespace", () => { + const menuItem = getByTestId("menu-action-remove"); + + userEvent.click(menuItem); + + expect(baseElement).toMatchSnapshot(); + }); + }); });