From bcaef7938669610ccbda6bbe973e70fd134e244d Mon Sep 17 00:00:00 2001
From: Sebastian Malton <sebastian@malton.name>
Date: Wed, 3 Mar 2021 14:34:35 -0500
Subject: [PATCH] Cleanup add namespace dialog (#2261)

- Remove mixing of async and promises
- Remove unnecessary instance close method
- Use condition call syntax

Signed-off-by: Sebastian Malton <sebastian@malton.name>
---
 .../+namespaces/add-namespace-dialog.tsx         | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

diff --git a/src/renderer/components/+namespaces/add-namespace-dialog.tsx b/src/renderer/components/+namespaces/add-namespace-dialog.tsx
index a3b30235fa..1ad2efae59 100644
--- a/src/renderer/components/+namespaces/add-namespace-dialog.tsx
+++ b/src/renderer/components/+namespaces/add-namespace-dialog.tsx
@@ -33,20 +33,18 @@ export class AddNamespaceDialog extends React.Component<Props> {
     this.namespace = "";
   };
 
-  close = () => {
-    AddNamespaceDialog.close();
-  };
-
   addNamespace = async () => {
     const { namespace } = this;
     const { onSuccess, onError } = this.props;
 
     try {
-      await namespaceStore.create({ name: namespace }).then(onSuccess);
-      this.close();
+      const created = await namespaceStore.create({ name: namespace });
+
+      onSuccess?.(created);
+      AddNamespaceDialog.close();
     } catch (err) {
       Notifications.error(err);
-      onError && onError(err);
+      onError?.(err);
     }
   };
 
@@ -61,9 +59,9 @@ export class AddNamespaceDialog extends React.Component<Props> {
         className="AddNamespaceDialog"
         isOpen={AddNamespaceDialog.isOpen}
         onOpen={this.reset}
-        close={this.close}
+        close={AddNamespaceDialog.close}
       >
-        <Wizard header={header} done={this.close}>
+        <Wizard header={header} done={AddNamespaceDialog.close}>
           <WizardStep
             contentClass="flex gaps column"
             nextLabel="Create"