mirror of
https://github.com/lensapp/lens.git
synced 2025-05-20 05:10:56 +00:00
address review comments
Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>
This commit is contained in:
parent
9ebbe5b84f
commit
be1503ccf0
@ -83,7 +83,7 @@ export class PortForwardMenu extends React.Component<Props> {
|
|||||||
|
|
||||||
return (
|
return (
|
||||||
<>
|
<>
|
||||||
{ Boolean(portForward.status === "Active") &&
|
{ portForward.status === "Active" &&
|
||||||
<MenuItem onClick={() => openPortForward(portForward)}>
|
<MenuItem onClick={() => openPortForward(portForward)}>
|
||||||
<Icon material="open_in_browser" interactive={toolbar} tooltip="Open in browser" />
|
<Icon material="open_in_browser" interactive={toolbar} tooltip="Open in browser" />
|
||||||
<span className="title">Open</span>
|
<span className="title">Open</span>
|
||||||
|
|||||||
@ -88,10 +88,6 @@ export class PortForwardDialog extends Component<Props> {
|
|||||||
this.desiredPort = this.currentPort;
|
this.desiredPort = this.currentPort;
|
||||||
};
|
};
|
||||||
|
|
||||||
onClose = async () => {
|
|
||||||
await (async () => dialogState.onClose())();
|
|
||||||
};
|
|
||||||
|
|
||||||
changePort = (value: string) => {
|
changePort = (value: string) => {
|
||||||
this.desiredPort = Number(value);
|
this.desiredPort = Number(value);
|
||||||
};
|
};
|
||||||
@ -187,7 +183,7 @@ export class PortForwardDialog extends Component<Props> {
|
|||||||
isOpen={dialogState.isOpen}
|
isOpen={dialogState.isOpen}
|
||||||
className={cssNames("PortForwardDialog", className)}
|
className={cssNames("PortForwardDialog", className)}
|
||||||
onOpen={this.onOpen}
|
onOpen={this.onOpen}
|
||||||
onClose={this.onClose}
|
onClose={dialogState.onClose}
|
||||||
close={this.close}
|
close={this.close}
|
||||||
>
|
>
|
||||||
<Wizard header={header} done={this.close}>
|
<Wizard header={header} done={this.close}>
|
||||||
|
|||||||
Loading…
Reference in New Issue
Block a user