hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Refactor to extract a responsibility

Browse Source 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
This commit is contained in:
Iku-turso 2023-03-14 13:21:45 +02:00
parent 0c7db307d6
commit be1fa6932a
2 changed files with 78 additions and 49 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
packages/kata-for-gabriel/src/handle-landed-hit-on-monster-for.ts Normal file
View File

@ -0,0 +1,33 @@
import type { Dependencies } from "./monster-beatdown";
export type Monster = {
hitPoints: number;
};
export const handleLandedHitOnMonsterFor =
({
monster,
messageToPlayer,
}: {
monster: Monster;
messageToPlayer: Dependencies["messageToPlayer"];
}) =>
() => {
monster.hitPoints--;
if (monster.hitPoints) {
messageToPlayer(
`You successfully land a hit on the monster, and it now only has ${monster.hitPoints} hit-points remaining.`,
);
return { monsterIsDead: false };
}
messageToPlayer(
"You successfully land a final hit on the monster, and it is now properly beat.",
);
messageToPlayer("You win. Congratulations!");
return { monsterIsDead: true };
};

34
packages/kata-for-gabriel/src/monster-beatdown.ts
View File

@ -1,14 +1,19 @@
import { handleLandedHitOnMonsterFor, Monster } from "./handle-landed-hit-on-monster-for";
export type Dependencies = {
messageToPlayer: (message: string) => void;
questionToPlayer: (message: string) => Promise<boolean>;
castDie: () => Promise<number>;
};
const createGame = ({ messageToPlayer, questionToPlayer, castDie }: Dependencies) => ({
start: async () => {
let monsterHitPoints = 3;
const createGame = ({ messageToPlayer, questionToPlayer, castDie }: Dependencies) => {
const monster: Monster = { hitPoints: 3 };
messageToPlayer(`You encounter a monster with ${monsterHitPoints} hit-points`);
const handleLandedHitOnMonster = handleLandedHitOnMonsterFor({ messageToPlayer, monster });
return {
start: async () => {
messageToPlayer(`You encounter a monster with ${monster.hitPoints} hit-points`);
const playerWantsToAttack = await questionToPlayer("Attack the monster?");
if (!playerWantsToAttack) {
@ -28,24 +33,13 @@ const createGame = ({ messageToPlayer, questionToPlayer, castDie }: Dependencies
const playerLandsHitOnMonster = dieResult > 3;
if (playerLandsHitOnMonster) {
monsterHitPoints--;
if (!monsterHitPoints) {
messageToPlayer(
"You successfully land a final hit on the monster, and it is now properly beat.",
);
messageToPlayer("You win. Congratulations!");
const { monsterIsDead } = handleLandedHitOnMonster();
if (monsterIsDead) {
return;
}
messageToPlayer(
`You successfully land a hit on the monster, and it now only has ${monsterHitPoints} hit-points remaining.`,
);
} else {
messageToPlayer(
`You fail to land a hit on the monster, and it still has ${monsterHitPoints} hit-points remaining.`,
`You fail to land a hit on the monster, and it still has ${monster.hitPoints} hit-points remaining.`,
);
}
@ -62,6 +56,8 @@ const createGame = ({ messageToPlayer, questionToPlayer, castDie }: Dependencies
}
}
},
});
};
};
export { createGame };