From bedc440d426a23fbb7fb6f0f651500e0d00dc04e Mon Sep 17 00:00:00 2001 From: Janne Savolainen Date: Tue, 26 Jul 2022 14:57:46 +0300 Subject: [PATCH] Fix opening of release details (#5850) * Make sure release details are updates when opening details Signed-off-by: Janne Savolainen * Relax filtering of resources to prevent crashing when release has installed resources in another namespace Signed-off-by: Janne Savolainen * Add Open Closed Principle compliant way to introduce global overrides without modification in getDiForUnitTesting Signed-off-by: Janne Savolainen * Rework helm release details to fix multiple bugs Signed-off-by: Janne Savolainen * Remove redundant optional chaining Signed-off-by: Janne Savolainen * Simplify code Signed-off-by: Janne Savolainen --- ...lling-helm-chart-from-new-tab.test.ts.snap | 43 + ...wing-details-for-helm-release.test.ts.snap | 16071 ++++++++++++++++ .../showing-details-for-helm-release.test.ts | 604 + .../k8s-api/endpoints/helm-releases.api.ts | 150 +- src/common/test-utils/get-global-override.ts | 13 + src/main/getDiForUnitTesting.ts | 18 + src/main/helm/helm-release-manager.ts | 1 - ...releases.global-override-for-injectable.ts | 15 + .../call-for-helm-releases.injectable.ts | 24 + ...call-for-create-helm-release.injectable.ts | 31 +- .../create-release.injectable.ts | 7 +- ...luster-frame-child-component.injectable.ts | 26 + .../release-details-content.tsx | 210 + ...guration.global-override-for-injectable.ts | 15 + ...r-helm-release-configuration.injectable.ts | 29 + ...-details.global-override-for-injectable.ts | 15 + ...all-for-helm-release-details.injectable.ts | 45 + .../call-for-helm-release.injectable.ts | 47 + .../get-resource-details-url.injectable.ts | 45 + .../release-details-model.injectable.tsx | 308 + .../release-details.injectable.ts | 24 - .../release-details/release-details.tsx | 311 +- .../release-values.injectable.ts | 36 - ...e.ts => target-helm-release.injectable.ts} | 19 +- ...er-supplied-values-are-shown.injectable.ts | 27 - .../+helm-releases/releases.injectable.ts | 81 +- .../components/+helm-releases/releases.tsx | 7 +- ...e-update.global-override-for-injectable.ts | 15 + ...call-for-helm-release-update.injectable.ts | 50 + .../update-release.injectable.ts | 19 +- .../create-upgrade-chart-tab.injectable.ts | 6 +- ...-random-upgrade-chart-tab-id.injectable.ts | 13 + .../components/dock/upgrade-chart/view.tsx | 8 +- src/renderer/components/drawer/drawer.tsx | 6 +- .../components/item-object-list/content.tsx | 4 +- .../item-object-list/list-layout.tsx | 3 + src/renderer/getDiForUnitTesting.tsx | 18 + 37 files changed, 17798 insertions(+), 566 deletions(-) create mode 100644 src/behaviours/helm-releases/__snapshots__/showing-details-for-helm-release.test.ts.snap create mode 100644 src/behaviours/helm-releases/showing-details-for-helm-release.test.ts create mode 100644 src/common/test-utils/get-global-override.ts create mode 100644 src/renderer/components/+helm-releases/call-for-helm-releases/call-for-helm-releases.global-override-for-injectable.ts create mode 100644 src/renderer/components/+helm-releases/call-for-helm-releases/call-for-helm-releases.injectable.ts create mode 100644 src/renderer/components/+helm-releases/release-details/release-details-cluster-frame-child-component.injectable.ts create mode 100644 src/renderer/components/+helm-releases/release-details/release-details-content.tsx create mode 100644 src/renderer/components/+helm-releases/release-details/release-details-model/call-for-helm-release-configuration/call-for-helm-release-configuration.global-override-for-injectable.ts create mode 100644 src/renderer/components/+helm-releases/release-details/release-details-model/call-for-helm-release-configuration/call-for-helm-release-configuration.injectable.ts create mode 100644 src/renderer/components/+helm-releases/release-details/release-details-model/call-for-helm-release/call-for-helm-release-details/call-for-helm-release-details.global-override-for-injectable.ts create mode 100644 src/renderer/components/+helm-releases/release-details/release-details-model/call-for-helm-release/call-for-helm-release-details/call-for-helm-release-details.injectable.ts create mode 100644 src/renderer/components/+helm-releases/release-details/release-details-model/call-for-helm-release/call-for-helm-release.injectable.ts create mode 100644 src/renderer/components/+helm-releases/release-details/release-details-model/get-resource-details-url.injectable.ts create mode 100644 src/renderer/components/+helm-releases/release-details/release-details-model/release-details-model.injectable.tsx delete mode 100644 src/renderer/components/+helm-releases/release-details/release-details.injectable.ts delete mode 100644 src/renderer/components/+helm-releases/release-details/release-values.injectable.ts rename src/renderer/components/+helm-releases/release-details/{release.injectable.ts => target-helm-release.injectable.ts} (58%) delete mode 100644 src/renderer/components/+helm-releases/release-details/user-supplied-values-are-shown.injectable.ts create mode 100644 src/renderer/components/+helm-releases/update-release/call-for-helm-release-update/call-for-helm-release-update.global-override-for-injectable.ts create mode 100644 src/renderer/components/+helm-releases/update-release/call-for-helm-release-update/call-for-helm-release-update.injectable.ts create mode 100644 src/renderer/components/dock/upgrade-chart/get-random-upgrade-chart-tab-id.injectable.ts diff --git a/src/behaviours/helm-charts/installing-chart/__snapshots__/installing-helm-chart-from-new-tab.test.ts.snap b/src/behaviours/helm-charts/installing-chart/__snapshots__/installing-helm-chart-from-new-tab.test.ts.snap index ad5d354124..eb02f57fc8 100644 --- a/src/behaviours/helm-charts/installing-chart/__snapshots__/installing-helm-chart-from-new-tab.test.ts.snap +++ b/src/behaviours/helm-charts/installing-chart/__snapshots__/installing-helm-chart-from-new-tab.test.ts.snap @@ -11123,6 +11123,49 @@ exports[`installing helm chart from new tab given tab for installing chart was n +
+
+
+
+ +
+ + + close + + +
+
+
+
+
+
+
`; diff --git a/src/behaviours/helm-releases/__snapshots__/showing-details-for-helm-release.test.ts.snap b/src/behaviours/helm-releases/__snapshots__/showing-details-for-helm-release.test.ts.snap new file mode 100644 index 0000000000..3c36512476 --- /dev/null +++ b/src/behaviours/helm-releases/__snapshots__/showing-details-for-helm-release.test.ts.snap @@ -0,0 +1,16071 @@ +// Jest Snapshot v1, https://goo.gl/fbAQLP + +exports[`showing details for helm release given application is started when navigating to helm releases renders 1`] = ` + +
+
+
+