hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

fix: change class name behaviour to limit snapshot diffs

Browse Source 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
Sebastian Malton 2023-04-17 11:22:40 -04:00
parent fef789bd49
commit bfb2b8e659
4 changed files with 16 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
packages/core/src/renderer/components/status-bar/__snapshots__/status-bar.test.tsx.snap
View File

@ -838,7 +838,7 @@ exports[`<StatusBar /> when an extension is enabled specifying the side the elem
</div> </div>
</div> </div>
<div <div
class="StatusBar status-default" class="StatusBar"
data-testid="status-bar" data-testid="status-bar"
> >
<div <div
@ -1166,7 +1166,7 @@ exports[`<StatusBar /> when an extension is enabled with an invalid data type, (
</div> </div>
</div> </div>
<div <div
class="StatusBar status-default" class="StatusBar"
data-testid="status-bar" data-testid="status-bar"
> >
<div <div
@ -1452,7 +1452,7 @@ exports[`<StatusBar /> when an extension is enabled with an invalid data type, (
</div> </div>
</div> </div>
<div <div
class="StatusBar status-default" class="StatusBar"
data-testid="status-bar" data-testid="status-bar"
> >
<div <div
@ -1738,7 +1738,7 @@ exports[`<StatusBar /> when an extension is enabled with an invalid data type, (
</div> </div>
</div> </div>
<div <div
class="StatusBar status-default" class="StatusBar"
data-testid="status-bar" data-testid="status-bar"
> >
<div <div
@ -2024,7 +2024,7 @@ exports[`<StatusBar /> when an extension is enabled with an invalid data type, (
</div> </div>
</div> </div>
<div <div
class="StatusBar status-default" class="StatusBar"
data-testid="status-bar" data-testid="status-bar"
> >
<div <div
@ -2310,7 +2310,7 @@ exports[`<StatusBar /> when an extension is enabled with an invalid data type, (
</div> </div>
</div> </div>
<div <div
class="StatusBar status-default" class="StatusBar"
data-testid="status-bar" data-testid="status-bar"
> >
<div <div
@ -2596,7 +2596,7 @@ exports[`<StatusBar /> when an extension is enabled with an invalid data type, (
</div> </div>
</div> </div>
<div <div
class="StatusBar status-default" class="StatusBar"
data-testid="status-bar" data-testid="status-bar"
> >
<div <div
@ -2882,7 +2882,7 @@ exports[`<StatusBar /> when an extension is enabled with an invalid data type, (
</div> </div>
</div> </div>
<div <div
class="StatusBar status-default" class="StatusBar"
data-testid="status-bar" data-testid="status-bar"
> >
<div <div
@ -3168,7 +3168,7 @@ exports[`<StatusBar /> when an extension is enabled with no status items renders
</div> </div>
</div> </div>
<div <div
class="StatusBar status-default" class="StatusBar"
data-testid="status-bar" data-testid="status-bar"
> >
<div <div

3
packages/core/src/renderer/components/status-bar/status-bar.module.scss
View File

@ -13,10 +13,7 @@
display: inline-grid; display: inline-grid;
grid-template-columns: 1fr 1fr; grid-template-columns: 1fr 1fr;
&.status-default {
background-color: var(--colorInfo); background-color: var(--colorInfo);
}
&.status-warning { &.status-warning {
background-color: var(--colorWarning); background-color: var(--colorWarning);

3
packages/core/src/renderer/components/status-bar/status-bar.test.tsx
View File

@ -4,7 +4,6 @@
*/ */
import React from "react"; import React from "react";
import "@testing-library/jest-dom/extend-expect";
import type { ApplicationBuilder } from "../test-utils/get-application-builder"; import type { ApplicationBuilder } from "../test-utils/get-application-builder";
import { getApplicationBuilder } from "../test-utils/get-application-builder"; import { getApplicationBuilder } from "../test-utils/get-application-builder";
import setStatusBarStatusInjectable from "./set-status-bar-status.injectable"; import setStatusBarStatusInjectable from "./set-status-bar-status.injectable";
@ -155,7 +154,7 @@ describe("<StatusBar />", () => {
}); });
it("has the default status by default", () => { it("has the default status by default", () => {
expect([...result.getByTestId("status-bar").classList]).toContain("status-default"); expect([...result.getByTestId("status-bar").classList]).toEqual(["StatusBar"]);
}); });
describe.each([ describe.each([

6
packages/core/src/renderer/components/status-bar/status-bar.tsx
View File

@ -27,9 +27,13 @@ const NonInjectedStatusBar = observer(({
status, status,
}: Dependencies & StatusBarProps) => { }: Dependencies & StatusBarProps) => {
const { left, right } = items.get(); const { left, right } = items.get();
const barStatus = status.get();
const barStyle = barStatus === "default"
? undefined
: styles[`status-${barStatus}`];
return ( return (
<div className={cssNames(styles.StatusBar, styles[`status-${status.get()}`])} data-testid="status-bar"> <div className={cssNames(styles.StatusBar, barStyle)} data-testid="status-bar">
<div className={styles.leftSide} data-testid="status-bar-left"> <div className={styles.leftSide} data-testid="status-bar-left">
{left.map((Item, index) => ( {left.map((Item, index) => (
<div <div