store-sync-fixes, part 1

Signed-off-by: Roman <ixrock@gmail.com>

src/common/base-store.ts

@@ -1,14 +1,13 @@
 import path from "path"
 import Config from "conf"
 import { Options as ConfOptions } from "conf/dist/source/types"
-import produce from "immer";
 import { app, ipcMain, ipcRenderer, remote } from "electron"
 import { action, observable, reaction, toJS, when } from "mobx";
 import Singleton from "./utils/singleton";
-import isEqual from "lodash/isEqual"
 import { getAppVersion } from "./utils/app-version";
 import logger from "../main/logger";
 import { broadcastMessage } from "./ipc-helpers";
+import isEqual from "lodash/isEqual";
 
 export interface BaseStoreParams<T = any> extends ConfOptions<T> {
   autoLoad?: boolean;
@@ -63,25 +62,33 @@ export class BaseStore<T = any> extends Singleton {
     });
     const storeModel = Object.assign({}, this.storeConfig.store);
     Reflect.deleteProperty(storeModel, "__internal__"); // fixme: avoid "external-internals"
-    logger.info(`[STORE]: loaded ${this.storeConfig.path}`);
+    logger.info(`[STORE]: LOADED from ${this.storeConfig.path}`);
     this.fromStore(storeModel);
     this.isLoaded = true;
   }
 
+  protected async save(model: T) {
+    logger.info(`[STORE]: SAVING ${this.name}`);
+    // fixme: https://github.com/sindresorhus/conf/issues/114
+    Object.entries(model).forEach(([key, value]) => {
+      this.storeConfig.set(key, value); // save update to config file
+    });
+  }
+
   enableSync() {
     this.syncDisposers.push(
-      reaction(() => this.toJSON(), this.onModelChange.bind(this)),
+      reaction(() => this.toJSON(), model => this.onModelChange(model)),
     );
     if (ipcMain) {
       ipcMain.on(this.syncEvent, (event, model: T) => {
-        logger.debug(`[STORE]: ${this.name} sync update from renderer`, model);
+        logger.info(`[STORE]: SYNC ${this.name} from renderer`);
         this.onSync(model);
       });
       this.syncDisposers.push(() => ipcMain.removeAllListeners(this.syncEvent));
     }
     if (ipcRenderer) {
       ipcRenderer.on(this.syncEvent, (event, model: T) => {
-        logger.debug(`[STORE]: ${this.name} sync update from main`, model);
+        logger.info(`[STORE]: SYNC ${this.name} from main`);
         this.onSync(model);
       });
       this.syncDisposers.push(() => ipcRenderer.removeAllListeners(this.syncEvent));
@@ -101,14 +108,10 @@ export class BaseStore<T = any> extends Singleton {
 
   protected async onModelChange(model: T) {
     if (ipcMain) {
-      broadcastMessage(this.syncEvent, model); // send updates to renderer views
+      this.save(model); // save to config file
-
+      broadcastMessage({ channel: this.syncEvent }, model); // broadcast to renderer views
-      // fixme: https://github.com/sindresorhus/conf/issues/114
-      Object.entries(model).forEach(([key, value]) => {
-        this.storeConfig.set(key, value); // save update to config file
-      });
     }
-    // sends "update-request" event to main-process
+    // send "update-request" to main-process
     if (ipcRenderer) {
       ipcRenderer.send(this.syncEvent, model);
     }
@@ -119,11 +122,6 @@ export class BaseStore<T = any> extends Singleton {
     this.data = data;
   }
 
-  @action
-  merge(updater: (modelDraft: T) => void) {
-    this.data = produce(this.data, updater);
-  }
-
   // todo: use "serializr" ?
   toJSON(): T {
     return toJS(this.data, {

src/common/ipc-helpers.ts

@@ -2,7 +2,7 @@
 // https://www.electronjs.org/docs/api/ipc-main
 // https://www.electronjs.org/docs/api/ipc-renderer
 
-import { ipcMain, ipcRenderer, webContents } from "electron"
+import { ipcMain, ipcRenderer, WebContents, webContents } from "electron"
 import logger from "../main/logger";
 
 export type IpcChannel = string;
@@ -15,8 +15,17 @@ export interface IpcMessageHandler<T extends any[] = any> {
   (...args: T): any;
 }
 
-export function broadcastMessage(channel: IpcChannel, ...args: any[]) {
+export interface IpcBroadcastOpts {
-  webContents.getAllWebContents().forEach(webContent => {
+  channel: IpcChannel
+  filter?: (webContent: WebContents) => boolean
+}
+
+export function broadcastMessage({ channel, filter }: IpcBroadcastOpts, ...args: any[]) {
+  let webContentsList = webContents.getAllWebContents();
+  if (filter) {
+    webContentsList = webContentsList.filter(filter);
+  }
+  webContentsList.forEach(webContent => {
     webContent.send(channel, ...args);
   })
 }

src/main/kube-auth-proxy.ts

@@ -84,7 +84,7 @@ export class KubeAuthProxy {
     const channel = `kube-auth:${this.cluster.id}`
     const message = { data, stream };
     logger.debug(channel, message);
-    broadcastMessage(channel, message);
+    broadcastMessage({ channel }, message);
   }
 
   public exit() {

src/main/window-manager.ts

@@ -5,6 +5,8 @@ import type { ClusterId } from "../common/cluster-store";
 import { clusterStore } from "../common/cluster-store";
 import logger from "./logger";
 
+// fixme: activate landing-page when no-clusters exists
+
 export class WindowManager {
   protected activeView: BrowserWindow;
   protected views = new Map<ClusterId, BrowserWindow>();
@@ -68,11 +70,12 @@ export class WindowManager {
       const activeView = this.activeView;
       const isLoadedBefore = !!this.getView(clusterId);
       const view = this.initView(clusterId);
-      logger.info(`Activating cluster(${cluster.id}) view`, {
+      logger.info(`[WINDOW-MANAGER]: activating cluster view`, {
+        id: cluster.id,
         contextName: cluster.contextName,
         isLoadedBefore: isLoadedBefore,
       });
-      if (view !== activeView) {
+      if (activeView !== view) {
         if (!isLoadedBefore) {
           await cluster.whenReady;
           await view.loadURL(cluster.webContentUrl);
@@ -86,7 +89,10 @@ export class WindowManager {
         this.activeView = view;
       }
     } catch (err) {
-      logger.error(`Activating cluster(${clusterId}) view has failed: ${err.stack}`);
+      logger.error(`[WINDOW-MANAGER]: can't activate cluster view`, {
+        clusterId: cluster.id,
+        err: String(err),
+      });
     }
   }
 

src/renderer/components/cluster-manager/clusters-menu.tsx

@@ -24,7 +24,7 @@ interface Props {
 export class ClustersMenu extends React.Component<Props> {
   showCluster = (cluster: Cluster) => {
     clusterStore.activeClusterId = cluster.id;
-    console.log('load lens for cluster:', cluster.toJSON());
+    console.log('show lens for cluster:', cluster.contextName);
   }
 
   addCluster = () => {