From c0e0408c9b6fc9197e66399898058f376c91ccc1 Mon Sep 17 00:00:00 2001 From: Sebastian Malton Date: Fri, 10 Dec 2021 13:06:33 -0500 Subject: [PATCH 1/2] Remove all 'NonBreakingSpace' characters from the repo Signed-off-by: Sebastian Malton --- extensions/metrics-cluster-feature/src/metrics-settings.tsx | 2 +- src/common/ipc/ipc.ts | 2 +- src/main/lens-binary.ts | 2 +- src/main/window-manager.ts | 4 ++-- src/migrations/hotbar-store/5.0.0-beta.10.ts | 2 +- src/renderer/api/catalog-entity-registry.ts | 2 +- src/renderer/components/+catalog/catalog-add-button.tsx | 4 ++-- src/renderer/components/+events/events.tsx | 2 +- src/renderer/components/+preferences/application.tsx | 2 +- src/renderer/components/dock/terminal.ts | 2 +- 10 files changed, 12 insertions(+), 12 deletions(-) diff --git a/extensions/metrics-cluster-feature/src/metrics-settings.tsx b/extensions/metrics-cluster-feature/src/metrics-settings.tsx index 7e12e3f0a2..4ce1985361 100644 --- a/extensions/metrics-cluster-feature/src/metrics-settings.tsx +++ b/extensions/metrics-cluster-feature/src/metrics-settings.tsx @@ -187,7 +187,7 @@ export class MetricsSettings extends React.Component { this.changed = true; } - @computed get buttonLabel() { + @computed get buttonLabel() { const allDisabled = !this.featureStates.kubeStateMetrics && !this.featureStates.nodeExporter && !this.featureStates.prometheus; if (this.inProgress && this.canUpgrade) return "Upgrading ..."; diff --git a/src/common/ipc/ipc.ts b/src/common/ipc/ipc.ts index 4a8b4f1f8d..b0eaa01e2a 100644 --- a/src/common/ipc/ipc.ts +++ b/src/common/ipc/ipc.ts @@ -26,7 +26,7 @@ import { ipcMain, ipcRenderer, webContents } from "electron"; import { toJS } from "../utils/toJS"; import logger from "../../main/logger"; -import { ClusterFrameInfo, clusterFrameMap } from "../cluster-frames"; +import { ClusterFrameInfo, clusterFrameMap } from "../cluster-frames"; import type { Disposer } from "../utils"; import type remote from "@electron/remote"; diff --git a/src/main/lens-binary.ts b/src/main/lens-binary.ts index 5a4420108f..7b9f580783 100644 --- a/src/main/lens-binary.ts +++ b/src/main/lens-binary.ts @@ -84,7 +84,7 @@ export class LensBinary { } } - public setLogger(logger: Console | winston.Logger) { + public setLogger(logger: Console | winston.Logger) { this.logger = logger; } diff --git a/src/main/window-manager.ts b/src/main/window-manager.ts index 70713b22e8..3d501f7064 100644 --- a/src/main/window-manager.ts +++ b/src/main/window-manager.ts @@ -113,7 +113,7 @@ export class WindowManager extends Singleton { appEventBus.emit({ name: "app", action: "dom-ready" }); }) .on("did-fail-load", (_event, code, desc) => { - logger.error(`[WINDOW-MANAGER]: Failed to load Main window`, { code, desc }); + logger.error(`[WINDOW-MANAGER]: Failed to load Main window`, { code, desc }); }) .on("did-finish-load", () => { logger.info("[WINDOW-MANAGER]: Main window loaded"); @@ -155,7 +155,7 @@ export class WindowManager extends Singleton { try { if (showSplash) await this.showSplash(); - logger.info(`[WINDOW-MANAGER]: Loading Main window from url: ${this.mainUrl} ...`); + logger.info(`[WINDOW-MANAGER]: Loading Main window from url: ${this.mainUrl} ...`); await this.mainWindow.loadURL(this.mainUrl); } catch (error) { logger.error("Loading main window failed", { error }); diff --git a/src/migrations/hotbar-store/5.0.0-beta.10.ts b/src/migrations/hotbar-store/5.0.0-beta.10.ts index 196b61c15f..882685e1b3 100644 --- a/src/migrations/hotbar-store/5.0.0-beta.10.ts +++ b/src/migrations/hotbar-store/5.0.0-beta.10.ts @@ -127,7 +127,7 @@ export default { * Finally, make sure that the catalog entity hotbar item is in place. * Just in case something else removed it. * - * if every hotbar has elements that all not the `catalog-entity` item + * if every hotbar has elements that all not the `catalog-entity` item */ if (hotbars.every(hotbar => hotbar.items.every(item => item?.entity?.uid !== "catalog-entity"))) { // note, we will add a new whole hotbar here called "default" if that was previously removed diff --git a/src/renderer/api/catalog-entity-registry.ts b/src/renderer/api/catalog-entity-registry.ts index b93d724eb4..abeaae6f68 100644 --- a/src/renderer/api/catalog-entity-registry.ts +++ b/src/renderer/api/catalog-entity-registry.ts @@ -199,7 +199,7 @@ export class CatalogEntityRegistry { const runEvent = new CatalogRunEvent({ target: entity }); for (const onBeforeRun of this.onBeforeRunHooks) { - try {  + try { await onBeforeRun(runEvent); } catch (error) { logger.warn(`[CATALOG-ENTITY-REGISTRY]: entity ${entity.getId()} onBeforeRun threw an error`, error); diff --git a/src/renderer/components/+catalog/catalog-add-button.tsx b/src/renderer/components/+catalog/catalog-add-button.tsx index 00c4d01831..2d151aca7a 100644 --- a/src/renderer/components/+catalog/catalog-add-button.tsx +++ b/src/renderer/components/+catalog/catalog-add-button.tsx @@ -21,7 +21,7 @@ import "./catalog-add-button.scss"; import React from "react"; -import { SpeedDial, SpeedDialAction } from "@material-ui/lab"; +import { SpeedDial, SpeedDialAction } from "@material-ui/lab"; import { Icon } from "../icon"; import { observer } from "mobx-react"; import { observable, makeObservable, action } from "mobx"; @@ -97,7 +97,7 @@ export class CatalogAddButton extends React.Component { } @boundMethod - onClose() { + onClose() { this.isOpen = false; } diff --git a/src/renderer/components/+events/events.tsx b/src/renderer/components/+events/events.tsx index bea552dd55..b02d21aafc 100644 --- a/src/renderer/components/+events/events.tsx +++ b/src/renderer/components/+events/events.tsx @@ -37,7 +37,7 @@ import { cssNames, IClassName, stopPropagation } from "../../utils"; import { Icon } from "../icon"; import { eventsURL } from "../../../common/routes"; import { getDetailsUrl } from "../kube-detail-params"; -import { apiManager } from "../../../common/k8s-api/api-manager"; +import { apiManager } from "../../../common/k8s-api/api-manager"; enum columnId { message = "message", diff --git a/src/renderer/components/+preferences/application.tsx b/src/renderer/components/+preferences/application.tsx index f99b65f306..9962176688 100644 --- a/src/renderer/components/+preferences/application.tsx +++ b/src/renderer/components/+preferences/application.tsx @@ -42,7 +42,7 @@ const updateChannelOptions: SelectOption[] = Array.from( export const Application = observer(() => { const defaultShell = process.env.SHELL - || process.env.PTYSHELL + || process.env.PTYSHELL || ( isWindows ? "powershell.exe" diff --git a/src/renderer/components/dock/terminal.ts b/src/renderer/components/dock/terminal.ts index 07dcde55ae..e88bfc067e 100644 --- a/src/renderer/components/dock/terminal.ts +++ b/src/renderer/components/dock/terminal.ts @@ -30,7 +30,7 @@ import { boundMethod, disposer } from "../../utils"; import { isMac } from "../../../common/vars"; import { camelCase, once } from "lodash"; import { UserStore } from "../../../common/user-store"; -import { clipboard } from "electron"; +import { clipboard } from "electron"; import logger from "../../../common/logger"; export class Terminal { From e32c33fc18e867f396bdb934a793611274cb3a31 Mon Sep 17 00:00:00 2001 From: Sebastian Malton Date: Wed, 15 Dec 2021 08:41:28 -0500 Subject: [PATCH 2/2] Add lint rule Signed-off-by: Sebastian Malton --- .eslintrc.js | 2 ++ src/common/utils/readableStream.ts | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.eslintrc.js b/.eslintrc.js index 5cc4144b5d..1415136093 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -118,6 +118,7 @@ module.exports = { sourceType: "module", }, rules: { + "no-irregular-whitespace": "error", "header/header": [2, "./license-header"], "no-invalid-this": "off", "@typescript-eslint/no-invalid-this": ["error"], @@ -199,6 +200,7 @@ module.exports = { jsx: true, }, rules: { + "no-irregular-whitespace": "error", "header/header": [2, "./license-header"], "no-invalid-this": "off", "@typescript-eslint/no-invalid-this": ["error"], diff --git a/src/common/utils/readableStream.ts b/src/common/utils/readableStream.ts index 85f5a81bac..2b2fd3728d 100644 --- a/src/common/utils/readableStream.ts +++ b/src/common/utils/readableStream.ts @@ -44,7 +44,7 @@ export class ReadableWebToNodeStream extends Readable { /** * - * @param stream Readable​Stream: https://developer.mozilla.org/en-US/docs/Web/API/ReadableStream + * @param stream ReadableStream: https://developer.mozilla.org/en-US/docs/Web/API/ReadableStream */ constructor(stream: ReadableStream) { super(); @@ -85,7 +85,7 @@ export class ReadableWebToNodeStream extends Readable { } /** - * If there is no unresolved read call to Web-API Readable​Stream immediately returns; + * If there is no unresolved read call to Web-API ReadableStream immediately returns; * otherwise will wait until the read is resolved. */ public async waitForReadToComplete() {