mirror of
https://github.com/lensapp/lens.git
synced 2025-05-20 05:10:56 +00:00
clean-up/update "todo/fixme-comments"
Signed-off-by: Roman <ixrock@gmail.com>
This commit is contained in:
1 parent
1510091cd2
commit
c0c1c227ca
8 files changed
+11
-15
No files matched your search
@@ -61,7 +61,7 @@ export class BaseStore<T = any> extends Singleton {
|
||||
},
|
||||
});
|
||||
const storedModel = Object.assign({}, this.storeConfig.store);
|
||||
Reflect.deleteProperty(storedModel, "__internal__"); // fixme: avoid "external-internals"
|
||||
Reflect.deleteProperty(storedModel, "__internal__"); // todo: avoid "external-internals"
|
||||
logger.info(`[STORE]: LOADED from ${this.storeConfig.path}`);
|
||||
this.fromStore(storedModel);
|
||||
this.isLoaded = true;
|
||||
@@ -69,8 +69,7 @@ export class BaseStore<T = any> extends Singleton {
|
||||
|
||||
protected async save(model: T) {
|
||||
logger.info(`[STORE]: SAVING ${this.name}`);
|
||||
// todo: avoid multiple file updates
|
||||
// fixme: https://github.com/sindresorhus/conf/issues/114
|
||||
// todo: update when fixed https://github.com/sindresorhus/conf/issues/114
|
||||
Object.entries(model).forEach(([key, value]) => {
|
||||
this.storeConfig.set(key, value);
|
||||
});
|
||||
|
||||
+1
-1
@@ -19,7 +19,7 @@ export interface IpcMessageOpts<A extends any[] = any> {
|
||||
channel: IpcChannel
|
||||
webContentId?: number; // sends to single webContents view
|
||||
filter?: (webContent: WebContents) => boolean
|
||||
timeout?: number; // fixme: add support
|
||||
timeout?: number; // todo: add support
|
||||
args?: A;
|
||||
}
|
||||
|
||||
|
||||
Reference in new issue
Block a user