From c14c237a8406d1abd4ea8d71ed2497a71fc59917 Mon Sep 17 00:00:00 2001
From: Alex Andreev <alex.andreev.email@gmail.com>
Date: Wed, 25 Jan 2023 14:38:08 +0300
Subject: [PATCH] Show metric name is targetCPUUtilizationPercentage is used

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
---
 .../components/+config-autoscalers/get-hpa-metric-name.ts     | 4 ++--
 .../renderer/components/+config-autoscalers/hpa-details.tsx   | 4 +++-
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/packages/core/src/renderer/components/+config-autoscalers/get-hpa-metric-name.ts b/packages/core/src/renderer/components/+config-autoscalers/get-hpa-metric-name.ts
index f92b249909..d45db05ec0 100644
--- a/packages/core/src/renderer/components/+config-autoscalers/get-hpa-metric-name.ts
+++ b/packages/core/src/renderer/components/+config-autoscalers/get-hpa-metric-name.ts
@@ -19,8 +19,8 @@ interface Metric extends MetricNames {
   type: HpaMetricType;
 }
 
-export function getMetricName(metric: Metric): string | undefined {
-  switch (metric.type) {
+export function getMetricName(metric: Metric | undefined): string | undefined {
+  switch (metric?.type) {
     case HpaMetricType.Resource:
       return metric.resource?.name;
     case HpaMetricType.Pods:
diff --git a/packages/core/src/renderer/components/+config-autoscalers/hpa-details.tsx b/packages/core/src/renderer/components/+config-autoscalers/hpa-details.tsx
index 96c1a7e20b..2afc992baf 100644
--- a/packages/core/src/renderer/components/+config-autoscalers/hpa-details.tsx
+++ b/packages/core/src/renderer/components/+config-autoscalers/hpa-details.tsx
@@ -62,7 +62,7 @@ class NonInjectedHpaDetails extends React.Component<HpaDetailsProps & Dependenci
     const renderName = (metric: HorizontalPodAutoscalerMetricSpec) => {
       const metricName = getMetricName(metric);
 
-      switch (metric.type) {
+      switch (metric?.type) {
         case HpaMetricType.ContainerResource:
 
         // fallthrough
@@ -85,6 +85,8 @@ class NonInjectedHpaDetails extends React.Component<HpaDetailsProps & Dependenci
         }
         case HpaMetricType.External:
           return `${metricName} on ${JSON.stringify(metric.external.metricSelector ?? metric.external.metric?.selector)}`;
+        default:
+          return hpa.spec?.targetCPUUtilizationPercentage ? "CPU Utilization percentage" : "unknown";
       }
     };