From c1679a224994ca04a674c8a25a214419973b6f76 Mon Sep 17 00:00:00 2001 From: Sebastian Malton Date: Tue, 3 Aug 2021 11:55:47 -0400 Subject: [PATCH] Review changes Signed-off-by: Sebastian Malton --- src/renderer/api/kube-object.ts | 2 +- .../components/+custom-resources/crd-resource-details.tsx | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/renderer/api/kube-object.ts b/src/renderer/api/kube-object.ts index 37deac617c..97b6442a02 100644 --- a/src/renderer/api/kube-object.ts +++ b/src/renderer/api/kube-object.ts @@ -87,7 +87,7 @@ export class KubeStatus { } export interface KubeObjectStatus { - conditions: { + conditions?: { lastTransitionTime: string; message: string; reason: string; diff --git a/src/renderer/components/+custom-resources/crd-resource-details.tsx b/src/renderer/components/+custom-resources/crd-resource-details.tsx index 0d1e44f79b..6f2b13938f 100644 --- a/src/renderer/components/+custom-resources/crd-resource-details.tsx +++ b/src/renderer/components/+custom-resources/crd-resource-details.tsx @@ -68,14 +68,14 @@ export class CrdResourceDetails extends React.Component { )); } - renderStatus(crd: KubeObject, columns: AdditionalPrinterColumnsV1[]) { - const showStatus = !columns.find(column => column.name == "Status") && crd.status?.conditions; + renderStatus(customResource: KubeObject, columns: AdditionalPrinterColumnsV1[]) { + const showStatus = !columns.find(column => column.name == "Status") && Array.isArray(customResource.status?.conditions); if (!showStatus) { return null; } - const conditions = crd.status.conditions + const conditions = customResource.status.conditions .filter(({ type, reason }) => type || reason) .map(({ type, reason, message, status }) => ({ kind: type || reason, message, status })) .map(({ kind, message, status }, index) => (