hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

revert addWorkspace, change to unexported symbol function

Browse Source 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
Sebastian Malton 2021-03-16 10:53:14 -04:00
parent 18758bffc2
commit c3467abe34
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/common/workspace-store.ts
View File

@ -26,6 +26,8 @@ export interface WorkspaceState {
enabled: boolean; enabled: boolean;
} }
const updateFromModel = Symbol("updateFromModel");
/** /**
* Workspace * Workspace
* *
@ -130,7 +132,7 @@ export class Workspace implements WorkspaceModel, WorkspaceState {
Object.assign(this, state); Object.assign(this, state);
} }
@action updateModel(model: WorkspaceModel) { @action [updateFromModel](model: WorkspaceModel) {
Object.assign(this, model); Object.assign(this, model);
} }
@ -251,10 +253,9 @@ export class WorkspaceStore extends BaseStore<WorkspaceStoreModel> {
@action @action
addWorkspace(workspace: Workspace) { addWorkspace(workspace: Workspace) {
workspace.name = workspace.name.trim();
const { id, name } = workspace; const { id, name } = workspace;
if (!name || this.getByName(name)) { if (!name.trim() || this.getByName(name.trim())) {
return; return;
} }
this.workspaces.set(id, workspace); this.workspaces.set(id, workspace);
@ -312,7 +313,7 @@ export class WorkspaceStore extends BaseStore<WorkspaceStoreModel> {
const oldWorkspace = this.workspaces.get(workspaceModel.id); const oldWorkspace = this.workspaces.get(workspaceModel.id);
if (oldWorkspace) { if (oldWorkspace) {
oldWorkspace.updateModel(workspaceModel); oldWorkspace[updateFromModel](workspaceModel);
} else { } else {
this.workspaces.set(workspaceModel.id, new Workspace(workspaceModel)); this.workspaces.set(workspaceModel.id, new Workspace(workspaceModel));
} }