From c62c335f5fe80e11aee1d90a369f3de74e6a5828 Mon Sep 17 00:00:00 2001
From: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com>
Date: Tue, 7 Mar 2023 11:22:49 +0200
Subject: [PATCH] Winston logger override

Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com>
---
 ...n-logger.global-override-for-injectable.ts | 23 +++++++++++++++++++
 .../main/logger/ipc-file-logger.injectable.ts |  1 +
 .../src/renderer/logger/ipc-transport.test.ts |  2 +-
 3 files changed, 25 insertions(+), 1 deletion(-)
 create mode 100644 packages/core/src/common/winston-logger.global-override-for-injectable.ts

diff --git a/packages/core/src/common/winston-logger.global-override-for-injectable.ts b/packages/core/src/common/winston-logger.global-override-for-injectable.ts
new file mode 100644
index 0000000000..cecace774d
--- /dev/null
+++ b/packages/core/src/common/winston-logger.global-override-for-injectable.ts
@@ -0,0 +1,23 @@
+/**
+ * Copyright (c) OpenLens Authors. All rights reserved.
+ * Licensed under MIT License. See LICENSE in root directory for more information.
+ */
+
+import winstonLoggerInjectable from "./winston-logger.injectable";
+import { getGlobalOverride } from "./test-utils/get-global-override";
+import { noop } from "./utils";
+import type winston from "winston";
+
+export default getGlobalOverride(winstonLoggerInjectable, () => ({
+  log: noop,
+  add: noop,
+  remove: noop,
+  clear: noop,
+  close: noop,
+
+  warn: noop,
+  debug: noop,
+  error: noop,
+  info: noop,
+  silly: noop,
+}) as winston.Logger);
diff --git a/packages/core/src/main/logger/ipc-file-logger.injectable.ts b/packages/core/src/main/logger/ipc-file-logger.injectable.ts
index b4cd3e76ea..dad6723f99 100644
--- a/packages/core/src/main/logger/ipc-file-logger.injectable.ts
+++ b/packages/core/src/main/logger/ipc-file-logger.injectable.ts
@@ -19,6 +19,7 @@ const ipcFileLoggerInjectable = getInjectable({
       },
       (options: transports.FileTransportOptions) => new transports.File(options),
     ),
+  causesSideEffects: true,
 });
 
 export default ipcFileLoggerInjectable;
diff --git a/packages/core/src/renderer/logger/ipc-transport.test.ts b/packages/core/src/renderer/logger/ipc-transport.test.ts
index 1ec40026b5..461de8a8b7 100644
--- a/packages/core/src/renderer/logger/ipc-transport.test.ts
+++ b/packages/core/src/renderer/logger/ipc-transport.test.ts
@@ -16,7 +16,7 @@ describe("renderer log transport through ipc", () => {
 
   beforeEach(() => {
     sendIpcMock = jest.fn();
-    di = getDiForUnitTesting({ doGeneralOverrides: true });
+    di = getDiForUnitTesting({ doGeneralOverrides: false });
     di.override(sendMessageToChannelInjectionToken, () => sendIpcMock);
     di.override(rendererLogFileIdInjectable, () => "some-log-id");
   });