Merge branch 'master' into turn-on-strict

.eslintrc.js

@@ -22,15 +22,16 @@ module.exports = {
     {
       files: [
         "**/*.js",
+        "**/*.mjs",
       ],
       extends: [
         "eslint:recommended",
       ],
       env: {
         node: true,
+        es2022: true,
       },
       parserOptions: {
-        ecmaVersion: 2018,
         sourceType: "module",
       },
       plugins: [

integration/__tests__/cluster-pages.tests.ts

@@ -39,7 +39,8 @@ utils.describeIf(minikubeReady(TEST_NAMESPACE))("Minikube based tests", () => {
     await frame.waitForSelector(`.Menu >> text="Remove"`);
   });
 
-  it("opens cluster settings by clicking link in no-metrics area", async () => {
+  // FIXME: failed locally since metrics might already exist, cc @aleksfront
+  it.skip("opens cluster settings by clicking link in no-metrics area", async () => {
     await frame.locator("text=Open cluster settings >> nth=0").click();
     await window.waitForSelector(`[data-testid="metrics-header"]`);
   });

package.json

@@ -291,6 +291,7 @@
     "@types/circular-dependency-plugin": "5.0.5",
     "@types/cli-progress": "^3.9.2",
     "@types/color": "^3.0.3",
+    "@types/command-line-args": "^5.2.0",
     "@types/crypto-js": "^3.1.47",
     "@types/dompurify": "^2.3.3",
     "@types/electron-devtools-installer": "^2.2.1",
@@ -344,6 +345,7 @@
     "circular-dependency-plugin": "^5.2.2",
     "cli-progress": "^3.11.0",
     "color": "^3.2.1",
+    "command-line-args": "^5.2.1",
     "concurrently": "^7.1.0",
     "css-loader": "^6.7.1",
     "deepdash": "^5.3.9",

scripts/clear-release-pr.mjs

@@ -0,0 +1,210 @@
+#!/usr/bin/env node
+/**
+ * Copyright (c) OpenLens Authors. All rights reserved.
+ * Licensed under MIT License. See LICENSE in root directory for more information.
+ */
+
+// This script creates a release PR
+import { execSync, exec, spawn } from "child_process";
+import commandLineArgs from "command-line-args";
+import fse from "fs-extra";
+import { basename } from "path";
+import semver from "semver";
+import { promisify } from "util";
+
+const {
+  SemVer,
+  valid: semverValid,
+  rcompare: semverRcompare,
+  lte: semverLte,
+} = semver;
+const { readJsonSync } = fse;
+const execP = promisify(exec);
+
+const options = commandLineArgs([
+  {
+    name: "type",
+    defaultOption: true,
+  },
+  {
+    name: "preid",
+  },
+]);
+
+const validReleaseValues = [
+  "major",
+  "minor",
+  "patch",
+];
+const validPrereleaseValues = [
+  "premajor",
+  "preminor",
+  "prepatch",
+  "prerelease",
+];
+const validPreidValues = [
+  "alpha",
+  "beta",
+];
+
+const errorMessages = {
+  noReleaseType: `No release type provided. Valid options are: ${[...validReleaseValues, ...validPrereleaseValues].join(", ")}`,
+  invalidRelease: (invalid) => `Invalid release type was provided (value was "${invalid}"). Valid options are: ${[...validReleaseValues, ...validPrereleaseValues].join(", ")}`,
+  noPreid: `No preid was provided. Use '--preid' to specify. Valid options are: ${validPreidValues.join(", ")}`,
+  invalidPreid: (invalid) => `Invalid preid was provided (value was "${invalid}"). Valid options are: ${validPreidValues.join(", ")}`,
+  wrongCwd: "It looks like you are running this script from the 'scripts' directory. This script assumes it is run from the root of the git repo",
+};
+
+if (!options.type) {
+  console.error(errorMessages.noReleaseType);
+  process.exit(1);
+}
+
+if (validReleaseValues.includes(options.type)) {
+  // do nothing, is valid
+} else if (validPrereleaseValues.includes(options.type)) {
+  if (!options.preid) {
+    console.error(errorMessages.noPreid);
+    process.exit(1);
+  }
+
+  if (!validPreidValues.includes(options.preid)) {
+    console.error(errorMessages.invalidPreid(options.preid));
+    process.exit(1);
+  }
+} else {
+  console.error(errorMessages.invalidRelease(options.type));
+  process.exit(1);
+}
+
+if (basename(process.cwd()) === "scripts") {
+  console.error(errorMessages.wrongCwd);
+}
+
+
+const currentVersion = new SemVer(readJsonSync("./package.json").version);
+const currentVersionMilestone = `${currentVersion.major}.${currentVersion.minor}.${currentVersion.patch}`;
+
+console.log(`current version: ${currentVersion.format()}`);
+console.log("fetching tags...");
+execSync("git fetch --tags --force");
+
+const actualTags = execSync("git tag --list", { encoding: "utf-8" }).split(/\r?\n/).map(line => line.trim());
+const [previousReleasedVersion] = actualTags
+  .map(semverValid)
+  .filter(Boolean)
+  .sort(semverRcompare)
+  .filter(version => semverLte(version, currentVersion));
+
+const npmVersionArgs = [
+  "npm",
+  "version",
+  options.type,
+];
+
+if (options.preid) {
+  npmVersionArgs.push(`--preid=${options.preid}`);
+}
+
+npmVersionArgs.push("--git-tag-version false");
+
+execSync(npmVersionArgs.join(" "), { stdio: "ignore" });
+
+const newVersion = new SemVer(readJsonSync("./package.json").version);
+
+const getMergedPrsArgs = [
+  "gh",
+  "pr",
+  "list",
+  "--limit=500", // Should be big enough, if not we need to release more often ;)
+  "--state=merged",
+  "--base=master",
+  "--json mergeCommit,title,author,labels,number,milestone",
+];
+
+console.log("retreiving last 500 PRs to create release PR body...");
+const mergedPrs = JSON.parse(execSync(getMergedPrsArgs.join(" "), { encoding: "utf-8" }));
+const milestoneRelevantPrs = mergedPrs.filter(pr => pr.milestone && pr.milestone.title === currentVersionMilestone);
+const relaventPrsQuery = await Promise.all(
+  milestoneRelevantPrs.map(async pr => ({
+    pr,
+    stdout: (await execP(`git tag v${previousReleasedVersion} --no-contains ${pr.mergeCommit.oid}`)).stdout,
+  })),
+);
+const relaventPrs = relaventPrsQuery
+  .filter(query => query.stdout)
+  .map(query => query.pr);
+
+const enhancementPrLabelName = "enhancement";
+const bugfixPrLabelName = "bug";
+
+const enhancementPrs = relaventPrs.filter(pr => pr.labels.some(label => label.name === enhancementPrLabelName));
+const bugfixPrs = relaventPrs.filter(pr => pr.labels.some(label => label.name === bugfixPrLabelName));
+const maintenencePrs = relaventPrs.filter(pr => pr.labels.every(label => label.name !== bugfixPrLabelName && label.name !== enhancementPrLabelName));
+
+console.log("Found:");
+console.log(`${enhancementPrs.length} enhancement PRs`);
+console.log(`${bugfixPrs.length} bug fix PRs`);
+console.log(`${maintenencePrs.length} maintenence PRs`);
+
+const prBodyLines = [
+  `## Changes since ${previousReleasedVersion}`,
+  "",
+];
+
+if (enhancementPrs.length > 0) {
+  prBodyLines.push(
+    "## 🚀 Features",
+    "",
+    ...enhancementPrs.map(pr => `- ${pr.title} (**#${pr.number}**) https://github.com/${pr.author.login}`),
+    "",
+  );
+}
+
+if (bugfixPrs.length > 0) {
+  prBodyLines.push(
+    "## 🐛 Bug Fixes",
+    "",
+    ...bugfixPrs.map(pr => `- ${pr.title} (**#${pr.number}**) https://github.com/${pr.author.login}`),
+    "",
+  );
+}
+
+if (maintenencePrs.length > 0) {
+  prBodyLines.push(
+    "## 🧰 Maintenance",
+    "",
+    ...maintenencePrs.map(pr => `- ${pr.title} (**#${pr.number}**) https://github.com/${pr.author.login}`),
+    "",
+  );
+}
+
+const prBody = prBodyLines.join("\n");
+const prBase = newVersion.patch === 0
+  ? "master"
+  : `release/v${newVersion.major}.${newVersion.minor}`;
+const createPrArgs = [
+  "pr",
+  "create",
+  "--base", prBase,
+  "--title", `release ${newVersion.format()}`,
+  "--label", "skip-changelog",
+  "--body-file", "-",
+];
+
+const createPrProcess = spawn("gh", createPrArgs, { stdio: "pipe" });
+let result = "";
+
+createPrProcess.stdout.on("data", (chunk) => result += chunk);
+
+createPrProcess.stdin.write(prBody);
+createPrProcess.stdin.end();
+
+await new Promise((resolve) => {
+  createPrProcess.on("close", () => {
+    createPrProcess.stdout.removeAllListeners();
+    resolve();
+  });
+});
+
+console.log(result);

src/extensions/__tests__/extension-compatibility.test.ts

@@ -1,128 +0,0 @@
-/**
- * Copyright (c) OpenLens Authors. All rights reserved.
- * Licensed under MIT License. See LICENSE in root directory for more information.
- */
-
-import { rawIsCompatibleExtension } from "../extension-compatibility";
-import { Console } from "console";
-import { stdout, stderr } from "process";
-import type { LensExtensionManifest } from "../lens-extension";
-import { SemVer } from "semver";
-
-console = new Console(stdout, stderr);
-
-describe("extension compatibility", () => {
-  describe("appSemVer with no prerelease tag", () => {
-    const isCompatibleExtension = rawIsCompatibleExtension(new SemVer("5.0.3"));
-
-    it("has no extension comparator", () => {
-      const manifest = { name: "extensionName", version: "0.0.1" };
-
-      expect(isCompatibleExtension(manifest)).toBe(false);
-    });
-
-    it.each([
-      {
-        comparator: "",
-        expected: false,
-      },
-      {
-        comparator: "bad comparator",
-        expected: false,
-      },
-      {
-        comparator: "^4.0.0",
-        expected: false,
-      },
-      {
-        comparator: "^5.0.0",
-        expected: true,
-      },
-      {
-        comparator: "^6.0.0",
-        expected: false,
-      },
-      {
-        comparator: "^4.0.0-alpha.1",
-        expected: false,
-      },
-      {
-        comparator: "^5.0.0-alpha.1",
-        expected: true,
-      },
-      {
-        comparator: "^6.0.0-alpha.1",
-        expected: false,
-      },
-    ])("extension comparator test: %p", ({ comparator, expected }) => {
-      const manifest: LensExtensionManifest = { name: "extensionName", version: "0.0.1", engines: { lens: comparator }};
-
-      expect(isCompatibleExtension(manifest)).toBe(expected);
-    });
-  });
-
-  describe("appSemVer with prerelease tag", () => {
-    const isCompatibleExtension = rawIsCompatibleExtension(new SemVer("5.0.3-beta.3"));
-
-    it("^5.1.0 should work when lens' version is 5.1.0-latest.123456789", () => {
-      const comparer = rawIsCompatibleExtension(new SemVer("5.1.0-latest.123456789"));
-
-      expect(comparer({ name: "extensionName", version: "0.0.1", engines: { lens: "^5.1.0" }})).toBe(true);
-    });
-
-    it("^5.1.0 should not when lens' version is 5.1.0-beta.1.123456789", () => {
-      const comparer = rawIsCompatibleExtension(new SemVer("5.1.0-beta.123456789"));
-
-      expect(comparer({ name: "extensionName", version: "0.0.1", engines: { lens: "^5.1.0" }})).toBe(false);
-    });
-
-    it("^5.1.0 should not when lens' version is 5.1.0-alpha.1.123456789", () => {
-      const comparer = rawIsCompatibleExtension(new SemVer("5.1.0-alpha.123456789"));
-
-      expect(comparer({ name: "extensionName", version: "0.0.1", engines: { lens: "^5.1.0" }})).toBe(false);
-    });
-
-    it("has no extension comparator", () => {
-      const manifest = { name: "extensionName", version: "0.0.1" };
-
-      expect(isCompatibleExtension(manifest)).toBe(false);
-    });
-
-    it.each([
-      {
-        comparator: "",
-        expected: false,
-      },
-      {
-        comparator: "bad comparator",
-        expected: false,
-      },
-      {
-        comparator: "^4.0.0",
-        expected: false,
-      },
-      {
-        comparator: "^5.0.0",
-        expected: true,
-      },
-      {
-        comparator: "^6.0.0",
-        expected: false,
-      },
-      {
-        comparator: "^4.0.0-alpha.1",
-        expected: false,
-      },
-      {
-        comparator: "^5.0.0-alpha.1",
-        expected: true,
-      },
-      {
-        comparator: "^6.0.0-alpha.1",
-        expected: false,
-      },
-    ])("extension comparator test: %p", ({ comparator, expected }) => {
-      expect(isCompatibleExtension({ name: "extensionName", version: "0.0.1", engines: { lens: comparator }})).toBe(expected);
-    });
-  });
-});

src/extensions/__tests__/is-compatible-extension.test.ts

@@ -0,0 +1,121 @@
+/**
+ * Copyright (c) OpenLens Authors. All rights reserved.
+ * Licensed under MIT License. See LICENSE in root directory for more information.
+ */
+
+import semver from "semver";
+import {
+  isCompatibleExtension,
+} from "../extension-discovery/is-compatible-extension/is-compatible-extension";
+import type { LensExtensionManifest } from "../lens-extension";
+
+describe("Extension/App versions compatibility check", () => {
+  it("is compatible with exact version matching", () => {
+    expect(isCompatibleExtension({
+      appSemVer: semver.coerce("5.5.0"),
+    })(getExtensionManifestMock({
+      lensEngine: "5.5.0",
+    }))).toBeTruthy();
+  });
+
+  it("is compatible with upper %PATCH versions of base app", () => {
+    expect(isCompatibleExtension({
+      appSemVer: semver.coerce("5.5.5"),
+    })(getExtensionManifestMock({
+      lensEngine: "5.5.0",
+    }))).toBeTruthy();
+  });
+
+  it("is compatible with upper %MINOR version of base app", () => {
+    expect(isCompatibleExtension({
+      appSemVer: semver.coerce("5.6.0"),
+    })(getExtensionManifestMock({
+      lensEngine: "5.5.0",
+    }))).toBeTruthy();
+
+    expect(isCompatibleExtension({
+      appSemVer: semver.coerce("5.5.0-alpha.0"),
+    })(getExtensionManifestMock({
+      lensEngine: "^5.5.0",
+    }))).toBeTruthy();
+
+    expect(isCompatibleExtension({
+      appSemVer: semver.coerce("5.5"),
+    })(getExtensionManifestMock({
+      lensEngine: "^5.6.0",
+    }))).toBeFalsy();
+  });
+
+  it("is not compatible with upper %MAJOR version of base app", () => {
+    expect(isCompatibleExtension({
+      appSemVer: semver.coerce("5.5.0"), // current lens-version
+    })(getExtensionManifestMock({
+      lensEngine: "6.0.0",
+    }))).toBeFalsy(); // extension with lens@6.0 is not compatible with app@5.5
+
+    expect(isCompatibleExtension({
+      appSemVer: semver.coerce("6.0.0"), // current lens-version
+    })(getExtensionManifestMock({
+      lensEngine: "5.5.0",
+    }))).toBeFalsy(); // extension with lens@5.5 is not compatible with app@6.0
+  });
+
+  it("is compatible with lensEngine with prerelease", () => {
+    expect(isCompatibleExtension({
+      appSemVer: semver.parse("5.5.0-alpha.0"),
+    })(getExtensionManifestMock({
+      lensEngine: "^5.4.0-alpha.0",
+    }))).toBeTruthy();
+  });
+
+  describe("supported formats for manifest.engines.lens", () => {
+    it("short version format for engines.lens", () => {
+      expect(isCompatibleExtension({
+        appSemVer: semver.coerce("5.5.0"),
+      })(getExtensionManifestMock({
+        lensEngine: "5.5",
+      }))).toBeTruthy();
+    });
+
+    it("validates version and throws if incorrect format", () => {
+      expect(() => isCompatibleExtension({
+        appSemVer: semver.coerce("1.0.0"),
+      })(getExtensionManifestMock({
+        lensEngine: "1.0",
+      }))).not.toThrow();
+
+      expect(() => isCompatibleExtension({
+        appSemVer: semver.coerce("1.0.0"),
+      })(getExtensionManifestMock({
+        lensEngine: "^1.0",
+      }))).not.toThrow();
+
+      expect(() => isCompatibleExtension({
+        appSemVer: semver.coerce("1.0.0"),
+      })(getExtensionManifestMock({
+        lensEngine: ">=2.0",
+      }))).toThrow(/Invalid format/i);
+    });
+
+    it("'*' cannot be used for any version matching (at least in the prefix)", () => {
+      expect(() => isCompatibleExtension({
+        appSemVer: semver.coerce("1.0.0"),
+      })(getExtensionManifestMock({
+        lensEngine: "*",
+      }))).toThrowError(/Invalid format/i);
+    });
+  });
+});
+
+function getExtensionManifestMock(
+  {
+    lensEngine = "1.0",
+  } = {}): LensExtensionManifest {
+  return {
+    name: "some-extension",
+    version: "1.0",
+    engines: {
+      lens: lensEngine,
+    },
+  };
+}

src/extensions/__tests__/lens-extension.test.ts

@@ -17,6 +17,7 @@ describe("lens extension", () => {
       manifest: {
         name: "foo-bar",
         version: "0.1.1",
+        engines: { lens: "^5.5.0" },
       },
       id: "/this/is/fake/package.json",
       absolutePath: "/absolute/fake/",

src/extensions/extension-compatibility.ts

@@ -1,49 +0,0 @@
-/**
- * Copyright (c) OpenLens Authors. All rights reserved.
- * Licensed under MIT License. See LICENSE in root directory for more information.
- */
-
-import semver, { SemVer } from "semver";
-import { appSemVer, isProduction } from "../common/vars";
-import type { LensExtensionManifest } from "./lens-extension";
-
-export function rawIsCompatibleExtension(version: SemVer): (manifest: LensExtensionManifest) => boolean {
-  const { major, minor, patch, prerelease: oldPrelease } = version;
-  let prerelease = "";
-
-  if (oldPrelease.length > 0) {
-    const [first] = oldPrelease;
-
-    if (first === "alpha" || first === "beta" || first === "rc") {
-      /**
-       * Strip the build IDs and "latest" prerelease tag as that is not really
-       * a part of API version
-       */
-      prerelease = `-${oldPrelease.slice(0, 2).join(".")}`;
-    }
-  }
-
-  /**
-   * We unfortunately have to format as string because the constructor only
-   * takes an instance or a string.
-   */
-  const strippedVersion = new SemVer(`${major}.${minor}.${patch}${prerelease}`, { includePrerelease: true });
-
-  return (manifest: LensExtensionManifest): boolean => {
-    if (manifest.engines?.lens) {
-      /**
-       * include Lens's prerelease tag in the matching so the extension's
-       * compatibility is not limited by it
-       */
-      return semver.satisfies(strippedVersion, manifest.engines.lens, { includePrerelease: true });
-    }
-
-    return false;
-  };
-}
-
-export const isCompatibleExtension = rawIsCompatibleExtension(appSemVer);
-
-export function isCompatibleBundledExtension(manifest: LensExtensionManifest): boolean {
-  return !isProduction || manifest.version === appSemVer.raw;
-}

src/extensions/extension-discovery/extension-discovery.test.ts

@@ -75,6 +75,9 @@ describe("ExtensionDiscovery", () => {
       return {
         name: "my-extension",
         version: "1.0.0",
+        engines: {
+          lens: "5.0.0",
+        },
       };
     });
 
@@ -103,10 +106,13 @@ describe("ExtensionDiscovery", () => {
         id: path.normalize("some-directory-for-user-data/node_modules/my-extension/package.json"),
         isBundled: false,
         isEnabled: false,
-        isCompatible: false,
+        isCompatible: true,
         manifest:  {
           name: "my-extension",
           version: "1.0.0",
+          engines: {
+            lens: "5.0.0",
+          },
         },
         manifestPath: path.normalize("some-directory-for-user-data/node_modules/my-extension/package.json"),
       });

src/extensions/extension-discovery/is-compatible-extension/is-compatible-extension.ts

@@ -2,51 +2,38 @@
  * Copyright (c) OpenLens Authors. All rights reserved.
  * Licensed under MIT License. See LICENSE in root directory for more information.
  */
-import semver, { SemVer } from "semver";
+import semver, { type SemVer } from "semver";
 import type { LensExtensionManifest } from "../../lens-extension";
 
 interface Dependencies {
   appSemVer: SemVer;
 }
 
-export const isCompatibleExtension = ({
+export const isCompatibleExtension = ({ appSemVer }: Dependencies): ((manifest: LensExtensionManifest) => boolean) => {
-  appSemVer,
-}: Dependencies): ((manifest: LensExtensionManifest) => boolean) => {
-  const { major, minor, patch, prerelease: oldPrelease } = appSemVer;
-  let prerelease = "";
-
-  if (oldPrelease.length > 0) {
-    const [first] = oldPrelease;
-
-    if (first === "alpha" || first === "beta" || first === "rc") {
-      /**
-       * Strip the build IDs and "latest" prerelease tag as that is not really
-       * a part of API version
-       */
-      prerelease = `-${oldPrelease.slice(0, 2).join(".")}`;
-    }
-  }
-
-  /**
-   * We unfortunately have to format as string because the constructor only
-   * takes an instance or a string.
-   */
-  const strippedVersion = new SemVer(
-    `${major}.${minor}.${patch}${prerelease}`,
-    { includePrerelease: true },
-  );
-
   return (manifest: LensExtensionManifest): boolean => {
-    if (manifest.engines?.lens) {
+    const appVersion = appSemVer.raw.split("-")[0]; // drop prerelease version if any, e.g. "-alpha.0"
-      /**
+    const manifestLensEngine = manifest.engines.lens;
-       * include Lens's prerelease tag in the matching so the extension's
+    const validVersion = manifestLensEngine.match(/^[\^0-9]\d*\.\d+\b/); // must start from ^ or number
-       * compatibility is not limited by it
+
-       */
+    if (!validVersion) {
-      return semver.satisfies(strippedVersion, manifest.engines.lens, {
+      const errorInfo = [
-        includePrerelease: true,
+        `Invalid format for "manifest.engines.lens"="${manifestLensEngine}"`,
-      });
+        `Range versions can only be specified starting with '^'.`,
+        `Otherwise it's recommended to use plain %MAJOR.%MINOR to match with supported Lens version.`,
+      ].join("\n");
+
+      throw new Error(errorInfo);
     }
 
-    return false;
+    const { major: extMajor, minor: extMinor } = semver.coerce(manifestLensEngine, {
+      loose: true,
+      includePrerelease: false,
+    });
+    const supportedVersionsByExtension: string = semver.validRange(`^${extMajor}.${extMinor}`);
+
+    return semver.satisfies(appVersion, supportedVersionsByExtension, {
+      loose: true,
+      includePrerelease: false,
+    });
   };
 };

src/extensions/lens-extension.ts

@@ -4,7 +4,7 @@
  */
 
 import type { InstalledExtension } from "./extension-discovery/extension-discovery";
-import { action, observable, makeObservable, computed } from "mobx";
+import { action, computed, makeObservable, observable } from "mobx";
 import logger from "../main/logger";
 import type { ProtocolHandlerRegistration } from "./registries";
 import type { PackageJson } from "type-fest";
@@ -20,6 +20,15 @@ export interface LensExtensionManifest extends PackageJson {
   version: string;
   main?: string; // path to %ext/dist/main.js
   renderer?: string; // path to %ext/dist/renderer.js
+  /**
+   * Supported Lens version engine by extension could be defined in `manifest.engines.lens`
+   * Only MAJOR.MINOR version is taken in consideration.
+   */
+  engines: {
+    lens: string; // "semver"-package format
+    npm?: string;
+    node?: string;
+  };
 }
 
 export const lensExtensionDependencies = Symbol("lens-extension-dependencies");

src/main/menu/electron-menu-items.test.ts

@@ -109,7 +109,7 @@ class SomeTestExtension extends LensMainExtension {
       isBundled: false,
       isCompatible: false,
       isEnabled: false,
-      manifest: { name: id, version: "some-version" },
+      manifest: { name: id, version: "some-version", engines: { lens: "^5.5.0" }},
       manifestPath: "irrelevant",
     });
 

src/main/protocol-handler/__test__/router.test.ts

@@ -85,6 +85,7 @@ describe("protocol router tests", () => {
       manifest: {
         name: "@mirantis/minikube",
         version: "0.1.1",
+        engines: { lens: "^5.5.0" },
       },
       isBundled: false,
       isEnabled: true,
@@ -160,6 +161,7 @@ describe("protocol router tests", () => {
       manifest: {
         name: "@foobar/icecream",
         version: "0.1.1",
+        engines: { lens: "^5.5.0" },
       },
       isBundled: false,
       isEnabled: true,
@@ -201,6 +203,7 @@ describe("protocol router tests", () => {
         manifest: {
           name: "@foobar/icecream",
           version: "0.1.1",
+          engines: { lens: "^5.5.0" },
         },
         isBundled: false,
         isEnabled: true,
@@ -226,6 +229,7 @@ describe("protocol router tests", () => {
         manifest: {
           name: "icecream",
           version: "0.1.1",
+          engines: { lens: "^5.5.0" },
         },
         isBundled: false,
         isEnabled: true,

src/main/tray/tray-menu-items.test.ts

@@ -113,7 +113,7 @@ class SomeTestExtension extends LensMainExtension {
       isBundled: false,
       isCompatible: false,
       isEnabled: false,
-      manifest: { name: id, version: "some-version" },
+      manifest: { name: id, version: "some-version", engines: { lens: "^5.5.0" }},
       manifestPath: "irrelevant",
     });
 

src/renderer/components/+extensions/__tests__/extensions.test.tsx

@@ -88,6 +88,7 @@ describe("Extensions", () => {
       manifest: {
         name: "test",
         version: "1.2.3",
+        engines: { lens: "^5.5.0" },
       },
       absolutePath: "/absolute/path",
       manifestPath: "/symlinked/path/package.json",

src/renderer/components/+welcome/__test__/welcome.test.tsx

@@ -98,7 +98,7 @@ class TestExtension extends LensRendererExtension {
       isBundled: false,
       isCompatible: false,
       isEnabled: false,
-      manifest: { name: id, version: "some-version" },
+      manifest: { name: id, version: "some-version", engines: { lens: "^5.5.0" }},
       manifestPath: "irrelevant",
     });
 

src/renderer/components/kube-object-menu/kube-object-menu.test.tsx

@@ -45,7 +45,7 @@ class SomeTestExtension extends LensRendererExtension {
       isBundled: false,
       isCompatible: false,
       isEnabled: false,
-      manifest: { name: "some-id", version: "some-version" },
+      manifest: { name: "some-id", version: "some-version", engines: { lens: "^5.5.0" }},
       manifestPath: "irrelevant",
     });
 

src/renderer/components/kube-object-status-icon/kube-object-status-icon.test.tsx

@@ -256,7 +256,7 @@ class SomeTestExtension extends LensRendererExtension {
       isBundled: false,
       isCompatible: false,
       isEnabled: false,
-      manifest: { name: "some-id", version: "some-version" },
+      manifest: { name: "some-id", version: "some-version", engines: { lens: "^5.5.0" }},
       manifestPath: "irrelevant",
     });
 

src/renderer/components/status-bar/status-bar.test.tsx

@@ -26,7 +26,7 @@ class SomeTestExtension extends LensRendererExtension {
       isBundled: false,
       isCompatible: false,
       isEnabled: false,
-      manifest: { name: "some-id", version: "some-version" },
+      manifest: { name: "some-id", version: "some-version", engines: { lens: "^5.5.0" }},
       manifestPath: "irrelevant",
     });
 

src/renderer/components/test-utils/get-renderer-extension-fake.ts

@@ -28,6 +28,9 @@ export const getRendererExtensionFakeFor = (builder: ApplicationBuilder) => (
       manifest: {
         name,
         version: "1.0.0",
+        engines: {
+          lens: "^5.5.0",
+        },
       },
       manifestPath: "irrelevant",
     });

yarn.lock

@@ -1403,6 +1403,11 @@
   dependencies:
     "@types/color-convert" "*"
 
+"@types/command-line-args@^5.2.0":
+  version "5.2.0"
+  resolved "https://registry.yarnpkg.com/@types/command-line-args/-/command-line-args-5.2.0.tgz#adbb77980a1cc376bb208e3f4142e907410430f6"
+  integrity sha512-UuKzKpJJ/Ief6ufIaIzr3A/0XnluX7RvFgwkV89Yzvm77wCh1kFaFmqN8XEnGcN62EuHdedQjEMb8mYxFLGPyA==
+
 "@types/connect-history-api-fallback@^1.3.5":
   version "1.3.5"
   resolved "https://registry.yarnpkg.com/@types/connect-history-api-fallback/-/connect-history-api-fallback-1.3.5.tgz#d1f7a8a09d0ed5a57aee5ae9c18ab9b803205dae"
@@ -2755,6 +2760,11 @@ arr-union@^3.1.0:
   resolved "https://registry.yarnpkg.com/arr-union/-/arr-union-3.1.0.tgz#e39b09aea9def866a8f206e288af63919bae39c4"
   integrity sha1-45sJrqne+Gao8gbiiK9jkZuuOcQ=
 
+array-back@^3.0.1, array-back@^3.1.0:
+  version "3.1.0"
+  resolved "https://registry.yarnpkg.com/array-back/-/array-back-3.1.0.tgz#b8859d7a508871c9a7b2cf42f99428f65e96bfb0"
+  integrity sha512-TkuxA4UCOvxuDK6NZYXCalszEzj+TLszyASooky+i742l9TqsOdYCMJJupxRic61hwquNtppB3hgcuq9SVSH1Q==
+
 array-flatten@1.1.1:
   version "1.1.1"
   resolved "https://registry.yarnpkg.com/array-flatten/-/array-flatten-1.1.1.tgz#9a5f699051b1e7073328f2a008968b64ea2955d2"
@@ -3799,6 +3809,16 @@ combined-stream@^1.0.6, combined-stream@^1.0.8, combined-stream@~1.0.6:
   dependencies:
     delayed-stream "~1.0.0"
 
+command-line-args@^5.2.1:
+  version "5.2.1"
+  resolved "https://registry.yarnpkg.com/command-line-args/-/command-line-args-5.2.1.tgz#c44c32e437a57d7c51157696893c5909e9cec42e"
+  integrity sha512-H4UfQhZyakIjC74I9d34fGYDwk3XpSr17QhEd0Q3I9Xq1CETHo4Hcuo87WyWHpAF1aSLjLRf5lD9ZGX2qStUvg==
+  dependencies:
+    array-back "^3.1.0"
+    find-replace "^3.0.0"
+    lodash.camelcase "^4.3.0"
+    typical "^4.0.0"
+
 commander@2.9.0:
   version "2.9.0"
   resolved "https://registry.yarnpkg.com/commander/-/commander-2.9.0.tgz#9c99094176e12240cb22d6c5146098400fe0f7d4"
@@ -5806,6 +5826,13 @@ find-npm-prefix@^1.0.2:
   resolved "https://registry.yarnpkg.com/find-npm-prefix/-/find-npm-prefix-1.0.2.tgz#8d8ce2c78b3b4b9e66c8acc6a37c231eb841cfdf"
   integrity sha512-KEftzJ+H90x6pcKtdXZEPsQse8/y/UnvzRKrOSQFprnrGaFuJ62fVkP34Iu2IYuMvyauCyoLTNkJZgrrGA2wkA==
 
+find-replace@^3.0.0:
+  version "3.0.0"
+  resolved "https://registry.yarnpkg.com/find-replace/-/find-replace-3.0.0.tgz#3e7e23d3b05167a76f770c9fbd5258b0def68c38"
+  integrity sha512-6Tb2myMioCAgv5kfvP5/PkZZ/ntTpVK39fHY7WkWBgvbeE+VHd/tZuZ4mrC+bxh4cfOZeYKVPaJIZtZXV7GNCQ==
+  dependencies:
+    array-back "^3.0.1"
+
 find-root@^1.1.0:
   version "1.1.0"
   resolved "https://registry.yarnpkg.com/find-root/-/find-root-1.1.0.tgz#abcfc8ba76f708c42a97b3d685b7e9450bfb9ce4"
@@ -12973,6 +13000,11 @@ typescript@^4.5.5:
   resolved "https://registry.yarnpkg.com/typescript/-/typescript-4.6.4.tgz#caa78bbc3a59e6a5c510d35703f6a09877ce45e9"
   integrity sha512-9ia/jWHIEbo49HfjrLGfKbZSuWo9iTMwXO+Ca3pRsSpbsMbc7/IU8NKdCZVRRBafVPGnoJeFL76ZOAA84I9fEg==
 
+typical@^4.0.0:
+  version "4.0.0"
+  resolved "https://registry.yarnpkg.com/typical/-/typical-4.0.0.tgz#cbeaff3b9d7ae1e2bbfaf5a4e6f11eccfde94fc4"
+  integrity sha512-VAH4IvQ7BDFYglMd7BPRDfLgxZZX4O4TFcRDA6EN5X7erNJJq+McIEp8np9aVtxrCJ6qx4GTYVfOWNjcqwZgRw==
+
 uglify-js@^3.1.4:
   version "3.15.4"
   resolved "https://registry.yarnpkg.com/uglify-js/-/uglify-js-3.15.4.tgz#fa95c257e88f85614915b906204b9623d4fa340d"