hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Adding semver coercion before comparing versions

Browse Source 
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
This commit is contained in:
Alex Andreev 2021-02-20 10:25:04 +03:00
parent 9a775c8a7b
commit c89fcd4506
3 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/main/helm/__mocks__/helm-chart-manager.ts
View File

@ -88,14 +88,14 @@ export class HelmChartManager {
{ {
apiVersion: "3.0.0", apiVersion: "3.0.0",
name: "pretzel", name: "pretzel",
version: "1.0.0-beta2", version: "1.0",
repo: "bitnami", repo: "bitnami",
digest: "test", digest: "test",
}, },
{ {
apiVersion: "3.0.0", apiVersion: "3.0.0",
name: "pretzel", name: "pretzel",
version: "1.0.0", version: "1.0.1",
repo: "bitnami", repo: "bitnami",
digest: "test" digest: "test"
} }

4
src/main/helm/__tests__/helm-service.test.ts
View File

@ -86,14 +86,14 @@ describe("Helm Service tests", () => {
{ {
apiVersion: "3.0.0", apiVersion: "3.0.0",
name: "pretzel", name: "pretzel",
version: "1.0.0", version: "1.0.1",
repo: "bitnami", repo: "bitnami",
digest: "test", digest: "test",
}, },
{ {
apiVersion: "3.0.0", apiVersion: "3.0.0",
name: "pretzel", name: "pretzel",
version: "1.0.0-beta2", version: "1.0",
repo: "bitnami", repo: "bitnami",
digest: "test" digest: "test"
} }

5
src/main/helm/helm-service.ts
View File

@ -109,7 +109,10 @@ class HelmService {
private sortChartsByVersion(chartGroups: RepoHelmChartList) { private sortChartsByVersion(chartGroups: RepoHelmChartList) {
for (const key in chartGroups) { for (const key in chartGroups) {
chartGroups[key] = chartGroups[key].sort((first, second) => { chartGroups[key] = chartGroups[key].sort((first, second) => {
return semver.compare(second.version, first.version); const firstVersion = semver.coerce(first.version || 0);
const secondVersion = semver.coerce(second.version || 0);
return semver.compare(secondVersion, firstVersion);
}); });
} }