diff --git a/docs/extensions/capabilities/common-capabilities.md b/docs/extensions/capabilities/common-capabilities.md index 26f193cd15..6fdb87db82 100644 --- a/docs/extensions/capabilities/common-capabilities.md +++ b/docs/extensions/capabilities/common-capabilities.md @@ -101,7 +101,6 @@ export default class ExampleRendererExtension extends LensRendererExtension { globalPages = [ { id: "example", - routePath: "/example", components: { Page: ExamplePage, } @@ -156,7 +155,7 @@ import { ExampleIcon, ExamplePage } from "./src/page" export default class ExampleExtension extends LensRendererExtension { clusterPages = [ { - routePath: "/extension-example", // optional + id: "extension-example", // optional exact: true, // optional components: { Page: () => , diff --git a/docs/extensions/get-started/anatomy.md b/docs/extensions/get-started/anatomy.md index 31bef5da31..5b0b94ec59 100644 --- a/docs/extensions/get-started/anatomy.md +++ b/docs/extensions/get-started/anatomy.md @@ -85,7 +85,7 @@ import React from "react" export default class ExampleExtension extends LensRendererExtension { clusterPages = [ { - routePath: "/extension-example", + id: "extension-example", components: { Page: () => , } @@ -94,4 +94,4 @@ export default class ExampleExtension extends LensRendererExtension { } ``` -The Hello World sample extension uses the `Cluster Page` capability, which is just one of the Lens extension API's capabilities. The [Common Capabilities](../capabilities/common-capabilities.md) page will help you home in on the right capabilities to use with your own extensions. \ No newline at end of file +The Hello World sample extension uses the `Cluster Page` capability, which is just one of the Lens extension API's capabilities. The [Common Capabilities](../capabilities/common-capabilities.md) page will help you home in on the right capabilities to use with your own extensions. diff --git a/extensions/example-extension/package.json b/extensions/example-extension/package.json index f9aa4b4909..b6455c6aa9 100644 --- a/extensions/example-extension/package.json +++ b/extensions/example-extension/package.json @@ -1,5 +1,5 @@ { - "name": "extension-example", + "name": "example-extension", "version": "1.0.0", "description": "Example extension", "main": "dist/main.js", diff --git a/extensions/example-extension/renderer.tsx b/extensions/example-extension/renderer.tsx index 2ddeadb92a..1a7d473ecd 100644 --- a/extensions/example-extension/renderer.tsx +++ b/extensions/example-extension/renderer.tsx @@ -6,7 +6,6 @@ export default class ExampleExtension extends LensRendererExtension { clusterPages = [ { id: "example", - routePath: "/extension-example", title: "Example Extension", components: { Page: () => , diff --git a/src/extensions/extension-discovery.ts b/src/extensions/extension-discovery.ts index 895fb272d7..ab17606e92 100644 --- a/src/extensions/extension-discovery.ts +++ b/src/extensions/extension-discovery.ts @@ -306,7 +306,6 @@ export class ExtensionDiscovery { } const extension = await this.loadExtensionFromPath(absPath); - if (extension) { extensions.push(extension); } @@ -328,4 +327,4 @@ export class ExtensionDiscovery { } } -export const extensionDiscovery = new ExtensionDiscovery(); \ No newline at end of file +export const extensionDiscovery = new ExtensionDiscovery(); diff --git a/src/extensions/registries/page-registry.ts b/src/extensions/registries/page-registry.ts index c346c6a56d..6eb2194205 100644 --- a/src/extensions/registries/page-registry.ts +++ b/src/extensions/registries/page-registry.ts @@ -16,11 +16,6 @@ export interface PageRegistration { * When not provided, first registered page without "id" would be used for page-menus without target.pageId for same extension */ id?: string; - /** - * Alias to page ID which assume to be used as path with possible :param placeholders - * @deprecated - */ - routePath?: string; /** * Strict route matching to provided page-id, read also: https://reactrouter.com/web/api/NavLink/exact-bool * In case when more than one page registered at same extension "pageId" is required to identify different pages, @@ -65,7 +60,7 @@ export class PageRegistry extends BaseRegistry { registeredPages = itemArray.map(page => ({ ...page, extensionId: ext.name, - routePath: getExtensionPageUrl({ extensionId: ext.name, pageId: page.id ?? page.routePath }), + routePath: getExtensionPageUrl({ extensionId: ext.name, pageId: page.id }), })); } catch (err) { logger.error(`[EXTENSION]: page-registration failed`, {