From c9f15949076cc304da9fbfa55d8515db9713f0f2 Mon Sep 17 00:00:00 2001 From: Sebastian Malton Date: Mon, 17 Oct 2022 10:22:25 -0400 Subject: [PATCH] Upgrade XTermJs to v5 to get snapshot testing working Signed-off-by: Sebastian Malton --- package.json | 2 +- ...opened-shows-connecting-message-1-snap.png | Bin 593 -> 0 bytes .../opening-terminal-tab.test.tsx.snap | 105 +++++++++++++++--- .../terminal/opening-terminal-tab.test.tsx | 21 +--- .../components/dock/terminal/terminal.ts | 13 ++- src/test-utils/findByTextWithMarkup.ts | 34 ++++++ yarn.lock | 13 ++- 7 files changed, 145 insertions(+), 43 deletions(-) delete mode 100644 src/features/terminal/__image_snapshots__/opening-terminal-tab-test-tsx-test-for-opening-terminal-tab-within-cluster-frame-when-new-terminal-tab-is-opened-shows-connecting-message-1-snap.png create mode 100644 src/test-utils/findByTextWithMarkup.ts diff --git a/package.json b/package.json index 5add3bf274..cf85dc7315 100644 --- a/package.json +++ b/package.json @@ -449,7 +449,7 @@ "webpack-cli": "^4.9.2", "webpack-dev-server": "^4.11.1", "webpack-node-externals": "^3.0.0", - "xterm": "^4.19.0", + "xterm": "^5.0.0", "xterm-addon-fit": "^0.5.0" }, "peerDependencies": { diff --git a/src/features/terminal/__image_snapshots__/opening-terminal-tab-test-tsx-test-for-opening-terminal-tab-within-cluster-frame-when-new-terminal-tab-is-opened-shows-connecting-message-1-snap.png b/src/features/terminal/__image_snapshots__/opening-terminal-tab-test-tsx-test-for-opening-terminal-tab-within-cluster-frame-when-new-terminal-tab-is-opened-shows-connecting-message-1-snap.png deleted file mode 100644 index 9d263a76b6c17658a103dc24eaa44e4e425bc7e7..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 593 zcmeAS@N?(olHy`uVBq!ia0y~yVAKJ!r*W_W$&~1=mw*&olDE4H!+#K5uy^@n1_mZJ zPZ!6KiaBquIPx+m2prhJ{D0m-Ci_iGLN{E$c4iJE$Bq5W3~`cT6A~jF+7cNh+gMX1 eMmfVS3}QTZn6&wB?yv@?5e83JKbLh*2~7YNGpUpS diff --git a/src/features/terminal/__snapshots__/opening-terminal-tab.test.tsx.snap b/src/features/terminal/__snapshots__/opening-terminal-tab.test.tsx.snap index 57c2e1b5cc..e3f36a584c 100644 --- a/src/features/terminal/__snapshots__/opening-terminal-tab.test.tsx.snap +++ b/src/features/terminal/__snapshots__/opening-terminal-tab.test.tsx.snap @@ -515,7 +515,7 @@ exports[`test for opening terminal tab within cluster frame when new terminal ta class="TerminalWindow dark" >
@@ -529,6 +529,7 @@ exports[`test for opening terminal tab within cluster frame when new terminal ta
- - - - + .xterm-dom-renderer-owner-1 .xterm-rows span { display: inline-block; height: 100%; vertical-align: top; width: 0px} + + +