diff --git a/src/common/app-paths/directory-for-bundled-binaries/directory-for-bundled-binaries.injectable.ts b/src/common/app-paths/directory-for-bundled-binaries/directory-for-bundled-binaries.injectable.ts index 7ac1a21a1e..9c25407d4d 100644 --- a/src/common/app-paths/directory-for-bundled-binaries/directory-for-bundled-binaries.injectable.ts +++ b/src/common/app-paths/directory-for-bundled-binaries/directory-for-bundled-binaries.injectable.ts @@ -2,13 +2,12 @@ * Copyright (c) OpenLens Authors. All rights reserved. * Licensed under MIT License. See LICENSE in root directory for more information. */ -import { getInjectable, lifecycleEnum } from "@ogre-tools/injectable"; +import { getInjectable } from "@ogre-tools/injectable"; import { baseBinariesDir } from "../../vars"; const directoryForBundledBinariesInjectable = getInjectable({ id: "directory-for-bundled-binaries", instantiate: () => baseBinariesDir.get(), - lifecycle: lifecycleEnum.singleton, }); export default directoryForBundledBinariesInjectable; diff --git a/src/common/vars/context-dir.injectable.ts b/src/common/vars/context-dir.injectable.ts index 09484cc816..fdef6c2c71 100644 --- a/src/common/vars/context-dir.injectable.ts +++ b/src/common/vars/context-dir.injectable.ts @@ -2,13 +2,12 @@ * Copyright (c) OpenLens Authors. All rights reserved. * Licensed under MIT License. See LICENSE in root directory for more information. */ -import { getInjectable, lifecycleEnum } from "@ogre-tools/injectable"; +import { getInjectable } from "@ogre-tools/injectable"; import { contextDir } from "../vars"; const contextDirInjectable = getInjectable({ id: "context-dir", instantiate: () => contextDir, - lifecycle: lifecycleEnum.singleton, }); export default contextDirInjectable; diff --git a/src/common/vars/is-development.injectable.ts b/src/common/vars/is-development.injectable.ts index c6adadd7e0..a731ae5a9f 100644 --- a/src/common/vars/is-development.injectable.ts +++ b/src/common/vars/is-development.injectable.ts @@ -2,13 +2,12 @@ * Copyright (c) OpenLens Authors. All rights reserved. * Licensed under MIT License. See LICENSE in root directory for more information. */ -import { getInjectable, lifecycleEnum } from "@ogre-tools/injectable"; +import { getInjectable } from "@ogre-tools/injectable"; import { isDevelopment } from "../vars"; const isDevelopmentInjectable = getInjectable({ id: "is-development", instantiate: () => isDevelopment, - lifecycle: lifecycleEnum.singleton, }); export default isDevelopmentInjectable; diff --git a/src/extensions/as-legacy-globals-for-extension-api/as-legacy-global-function-for-extension-api.ts b/src/extensions/as-legacy-globals-for-extension-api/as-legacy-global-function-for-extension-api.ts index 72ab74cdcb..4ab374743c 100644 --- a/src/extensions/as-legacy-globals-for-extension-api/as-legacy-global-function-for-extension-api.ts +++ b/src/extensions/as-legacy-globals-for-extension-api/as-legacy-global-function-for-extension-api.ts @@ -2,29 +2,19 @@ * Copyright (c) OpenLens Authors. All rights reserved. * Licensed under MIT License. See LICENSE in root directory for more information. */ -import type { Injectable, TentativeTuple } from "@ogre-tools/injectable"; import { getLegacyGlobalDiForExtensionApi } from "./legacy-global-di-for-extension-api"; +import type { Inject } from "@ogre-tools/injectable"; -type FactoryType = < - TInjectable extends Injectable, - TInstantiationParameter, - TInstance extends (...args: unknown[]) => any, - TFunction extends (...args: unknown[]) => any = Awaited< - ReturnType - >, ->( - injectableKey: TInjectable, - ...instantiationParameter: TentativeTuple -) => (...args: Parameters) => ReturnType; +export const asLegacyGlobalFunctionForExtensionApi = (( + injectableKey, + instantiationParameter, +) => + (...args: any[]) => { + const injected = getLegacyGlobalDiForExtensionApi().inject( + injectableKey, + instantiationParameter, + ) as unknown as (...args: any[]) => any; -export const asLegacyGlobalFunctionForExtensionApi: FactoryType = - (injectableKey, ...instantiationParameter) => - (...args) => { - const injected = getLegacyGlobalDiForExtensionApi().inject( - injectableKey, - ...instantiationParameter, - ); - - return injected(...args); - }; + return injected(...args); + }) as Inject; diff --git a/src/extensions/as-legacy-globals-for-extension-api/as-legacy-global-object-for-extension-api-with-modifications.ts b/src/extensions/as-legacy-globals-for-extension-api/as-legacy-global-object-for-extension-api-with-modifications.ts index 679dffb3b6..e8b36021c4 100644 --- a/src/extensions/as-legacy-globals-for-extension-api/as-legacy-global-object-for-extension-api-with-modifications.ts +++ b/src/extensions/as-legacy-globals-for-extension-api/as-legacy-global-object-for-extension-api-with-modifications.ts @@ -2,44 +2,15 @@ * Copyright (c) OpenLens Authors. All rights reserved. * Licensed under MIT License. See LICENSE in root directory for more information. */ -import type { Injectable, TentativeTuple } from "@ogre-tools/injectable"; -import { getLegacyGlobalDiForExtensionApi } from "./legacy-global-di-for-extension-api"; - -type MapInjectables = { - [Key in keyof T]: T[Key] extends () => infer Res ? Res : never; -}; +import { asLegacyGlobalForExtensionApi } from "./as-legacy-global-object-for-extension-api"; +import type { Injectable } from "@ogre-tools/injectable"; export const asLegacyGlobalObjectForExtensionApiWithModifications = < - TInjectable extends Injectable, - TInstantiationParameter, - OtherFields extends Record any>, + InjectableInstance extends InjectionTokenInstance, + InjectionTokenInstance, + ModificationObject extends object, >( - injectableKey: TInjectable, - otherFields: OtherFields, - ...instantiationParameter: TentativeTuple + injectable: Injectable, + modificationObject: ModificationObject, ) => - new Proxy( - {}, - { - get(target, propertyName) { - if (propertyName === "$$typeof") { - return undefined; - } - - const instance: any = getLegacyGlobalDiForExtensionApi().inject( - injectableKey, - ...instantiationParameter, - ); - - const propertyValue = instance[propertyName] ?? otherFields[propertyName as any](); - - if (typeof propertyValue === "function") { - return function (...args: any[]) { - return propertyValue.apply(instance, args); - }; - } - - return propertyValue; - }, - }, - ) as ReturnType & MapInjectables; + Object.assign(modificationObject, asLegacyGlobalForExtensionApi(injectable)); diff --git a/src/extensions/as-legacy-globals-for-extension-api/as-legacy-global-object-for-extension-api.ts b/src/extensions/as-legacy-globals-for-extension-api/as-legacy-global-object-for-extension-api.ts index 4505f2bb5d..3d65e0ea0f 100644 --- a/src/extensions/as-legacy-globals-for-extension-api/as-legacy-global-object-for-extension-api.ts +++ b/src/extensions/as-legacy-globals-for-extension-api/as-legacy-global-object-for-extension-api.ts @@ -2,27 +2,34 @@ * Copyright (c) OpenLens Authors. All rights reserved. * Licensed under MIT License. See LICENSE in root directory for more information. */ -import type { Injectable, TentativeTuple } from "@ogre-tools/injectable"; +import type { Inject } from "@ogre-tools/injectable"; import { getLegacyGlobalDiForExtensionApi } from "./legacy-global-di-for-extension-api"; -export const asLegacyGlobalObjectForExtensionApi = < - TInjectable extends Injectable, - TInstantiationParameter, ->( - injectableKey: TInjectable, - ...instantiationParameter: TentativeTuple - ) => +export const asLegacyGlobalForExtensionApi = (( + injectable, + instantiationParameter, +) => new Proxy( {}, + { + apply(target, thisArg, argArray) { + const fn = getLegacyGlobalDiForExtensionApi().inject( + injectable, + instantiationParameter, + ) as unknown as (...args: any[]) => any; + + return fn(...argArray); + }, + get(target, propertyName) { if (propertyName === "$$typeof") { return undefined; } const instance: any = getLegacyGlobalDiForExtensionApi().inject( - injectableKey, - ...instantiationParameter, + injectable, + instantiationParameter, ); const propertyValue = instance[propertyName]; @@ -36,4 +43,4 @@ export const asLegacyGlobalObjectForExtensionApi = < return propertyValue; }, }, - ) as ReturnType; + )) as Inject; diff --git a/src/extensions/renderer-api/components.ts b/src/extensions/renderer-api/components.ts index 8e6df41fa1..62d97c490c 100644 --- a/src/extensions/renderer-api/components.ts +++ b/src/extensions/renderer-api/components.ts @@ -5,16 +5,16 @@ import { asLegacyGlobalFunctionForExtensionApi } from "../as-legacy-globals-for-extension-api/as-legacy-global-function-for-extension-api"; import createTerminalTabInjectable from "../../renderer/components/dock/terminal/create-terminal-tab.injectable"; import terminalStoreInjectable from "../../renderer/components/dock/terminal/store.injectable"; -import { asLegacyGlobalObjectForExtensionApi } from "../as-legacy-globals-for-extension-api/as-legacy-global-object-for-extension-api"; +import { asLegacyGlobalForExtensionApi } from "../as-legacy-globals-for-extension-api/as-legacy-global-object-for-extension-api"; import logTabStoreInjectable from "../../renderer/components/dock/logs/tab-store.injectable"; import commandOverlayInjectable from "../../renderer/components/command-palette/command-overlay.injectable"; -import { asLegacyGlobalObjectForExtensionApiWithModifications } from "../as-legacy-globals-for-extension-api/as-legacy-global-object-for-extension-api-with-modifications"; import createPodLogsTabInjectable from "../../renderer/components/dock/logs/create-pod-logs-tab.injectable"; import createWorkloadLogsTabInjectable from "../../renderer/components/dock/logs/create-workload-logs-tab.injectable"; import sendCommandInjectable from "../../renderer/components/dock/terminal/send-command.injectable"; import { podsStore } from "../../renderer/components/+workloads-pods/pods.store"; import renameTabInjectable from "../../renderer/components/dock/dock/rename-tab.injectable"; +import { asLegacyGlobalObjectForExtensionApiWithModifications } from "../as-legacy-globals-for-extension-api/as-legacy-global-object-for-extension-api-with-modifications"; // layouts export * from "../../renderer/components/layout/main-layout"; @@ -33,7 +33,9 @@ export * from "../../renderer/components/switch"; export * from "../../renderer/components/input/input"; // command-overlay -export const CommandOverlay = asLegacyGlobalObjectForExtensionApi(commandOverlayInjectable); +export const CommandOverlay = asLegacyGlobalForExtensionApi( + commandOverlayInjectable, +); export type { CategoryColumnRegistration, @@ -74,30 +76,52 @@ export * from "../../renderer/components/+events/kube-event-details"; // specific exports export * from "../../renderer/components/status-brick"; -export const createTerminalTab = asLegacyGlobalFunctionForExtensionApi(createTerminalTabInjectable); -export const terminalStore = asLegacyGlobalObjectForExtensionApiWithModifications(terminalStoreInjectable, { - sendCommand: () => asLegacyGlobalFunctionForExtensionApi(sendCommandInjectable), -}); -export const logTabStore = asLegacyGlobalObjectForExtensionApiWithModifications(logTabStoreInjectable, { - createPodTab: () => asLegacyGlobalFunctionForExtensionApi(createPodLogsTabInjectable), - createWorkloadTab: () => asLegacyGlobalFunctionForExtensionApi(createWorkloadLogsTabInjectable), - renameTab: () => (tabId: string): void => { - const renameTab = asLegacyGlobalFunctionForExtensionApi(renameTabInjectable); - const tabData = logTabStore.getData(tabId); - const pod = podsStore.getById(tabData.selectedPodId); +export const createTerminalTab = asLegacyGlobalFunctionForExtensionApi( + createTerminalTabInjectable, +); - renameTab(tabId, `Pod ${pod.getName()}`); +export const terminalStore = + asLegacyGlobalObjectForExtensionApiWithModifications( + terminalStoreInjectable, + { + sendCommand: asLegacyGlobalFunctionForExtensionApi(sendCommandInjectable), + }, + ); + +export const logTabStore = asLegacyGlobalObjectForExtensionApiWithModifications( + logTabStoreInjectable, + { + createPodTab: asLegacyGlobalFunctionForExtensionApi( + createPodLogsTabInjectable, + ), + + createWorkloadTab: asLegacyGlobalFunctionForExtensionApi( + createWorkloadLogsTabInjectable, + ), + + renameTab: (tabId: string): void => { + const renameTab = + asLegacyGlobalFunctionForExtensionApi(renameTabInjectable); + + const tabData = logTabStore.getData(tabId); + const pod = podsStore.getById(tabData.selectedPodId); + + renameTab(tabId, `Pod ${pod.getName()}`); + }, + + tabs: undefined, }, - tabs: () => undefined, -}); +); export class TerminalStore { static getInstance() { return terminalStore; } + static createInstance() { return terminalStore; } + static resetInstance() { console.warn("TerminalStore.resetInstance() does nothing"); } diff --git a/src/main/shell-session/shell-env-modifier/terminal-shell-env-modify.injectable.ts b/src/main/shell-session/shell-env-modifier/terminal-shell-env-modify.injectable.ts index d0c6e2c54b..c9d345c3b2 100644 --- a/src/main/shell-session/shell-env-modifier/terminal-shell-env-modify.injectable.ts +++ b/src/main/shell-session/shell-env-modifier/terminal-shell-env-modify.injectable.ts @@ -3,7 +3,7 @@ * Licensed under MIT License. See LICENSE in root directory for more information. */ -import { getInjectable, lifecycleEnum } from "@ogre-tools/injectable"; +import { getInjectable } from "@ogre-tools/injectable"; import mainExtensionsInjectable from "../../../extensions/main-extensions.injectable"; import { terminalShellEnvModify } from "./terminal-shell-env-modifiers"; @@ -14,8 +14,6 @@ const terminalShellEnvModifyInjectable = getInjectable({ terminalShellEnvModify({ extensions: di.inject(mainExtensionsInjectable), }), - - lifecycle: lifecycleEnum.singleton, }); export default terminalShellEnvModifyInjectable; diff --git a/src/renderer/components/+workloads-overview/detail-components.injectable.ts b/src/renderer/components/+workloads-overview/detail-components.injectable.ts index 53b0a8c344..cdb625a03c 100644 --- a/src/renderer/components/+workloads-overview/detail-components.injectable.ts +++ b/src/renderer/components/+workloads-overview/detail-components.injectable.ts @@ -2,7 +2,7 @@ * Copyright (c) OpenLens Authors. All rights reserved. * Licensed under MIT License. See LICENSE in root directory for more information. */ -import { getInjectable, lifecycleEnum } from "@ogre-tools/injectable"; +import { getInjectable } from "@ogre-tools/injectable"; import { computed } from "mobx"; import rendererExtensionsInjectable from "../../../extensions/renderer-extensions.injectable"; import { OverviewStatuses } from "./overview-statuses"; @@ -31,8 +31,6 @@ const detailComponentsInjectable = getInjectable({ ); }); }, - - lifecycle: lifecycleEnum.singleton, }); const coreRegistrations = [ diff --git a/src/renderer/components/kube-object-status-icon/status-registrations.injectable.ts b/src/renderer/components/kube-object-status-icon/status-registrations.injectable.ts index c75aa85236..2e5f302382 100644 --- a/src/renderer/components/kube-object-status-icon/status-registrations.injectable.ts +++ b/src/renderer/components/kube-object-status-icon/status-registrations.injectable.ts @@ -2,7 +2,7 @@ * Copyright (c) OpenLens Authors. All rights reserved. * Licensed under MIT License. See LICENSE in root directory for more information. */ -import { getInjectable, lifecycleEnum } from "@ogre-tools/injectable"; +import { getInjectable } from "@ogre-tools/injectable"; import { computed } from "mobx"; import rendererExtensionsInjectable from "../../../extensions/renderer-extensions.injectable"; @@ -16,8 +16,6 @@ const statusRegistrationsInjectable = getInjectable({ extensions.get().flatMap((extension) => extension.kubeObjectStatusTexts), ); }, - - lifecycle: lifecycleEnum.singleton, }); export default statusRegistrationsInjectable; diff --git a/src/renderer/components/status-bar/registered-status-bar-items.injectable.tsx b/src/renderer/components/status-bar/registered-status-bar-items.injectable.tsx index 14c5f4af14..803e5b1800 100644 --- a/src/renderer/components/status-bar/registered-status-bar-items.injectable.tsx +++ b/src/renderer/components/status-bar/registered-status-bar-items.injectable.tsx @@ -3,9 +3,12 @@ * Licensed under MIT License. See LICENSE in root directory for more information. */ import React from "react"; -import { getInjectable, lifecycleEnum } from "@ogre-tools/injectable"; +import { getInjectable } from "@ogre-tools/injectable"; import { computed, IComputedValue } from "mobx"; -import type { StatusBarItemProps, StatusBarRegistration } from "./status-bar-registration"; +import type { + StatusBarItemProps, + StatusBarRegistration, +} from "./status-bar-registration"; import statusBarItemsInjectable from "./status-bar-items.injectable"; export interface RegisteredStatusBarItems { @@ -69,7 +72,6 @@ const registeredStatusBarItemsInjectable = getInjectable({ registrations: di.inject(statusBarItemsInjectable), }), - lifecycle: lifecycleEnum.singleton, }); export default registeredStatusBarItemsInjectable; diff --git a/src/renderer/components/status-bar/status-bar-items.injectable.ts b/src/renderer/components/status-bar/status-bar-items.injectable.ts index 193ac027d8..05a22b86a7 100644 --- a/src/renderer/components/status-bar/status-bar-items.injectable.ts +++ b/src/renderer/components/status-bar/status-bar-items.injectable.ts @@ -2,7 +2,7 @@ * Copyright (c) OpenLens Authors. All rights reserved. * Licensed under MIT License. See LICENSE in root directory for more information. */ -import { getInjectable, lifecycleEnum } from "@ogre-tools/injectable"; +import { getInjectable } from "@ogre-tools/injectable"; import { computed } from "mobx"; import rendererExtensionsInjectable from "../../../extensions/renderer-extensions.injectable"; @@ -12,12 +12,10 @@ const statusBarItemsInjectable = getInjectable({ instantiate: (di) => { const extensions = di.inject(rendererExtensionsInjectable); - return computed(() => ( - extensions.get() - .flatMap(ext => ext.statusBarItems) - )); + return computed(() => + extensions.get().flatMap((ext) => ext.statusBarItems), + ); }, - lifecycle: lifecycleEnum.singleton, }); export default statusBarItemsInjectable;