From cc4bd9a00b390d192b6cbe9c4e0699b971a370b9 Mon Sep 17 00:00:00 2001
From: Sebastian Malton <sebastian@malton.name>
Date: Tue, 20 Jul 2021 16:51:32 -0400
Subject: [PATCH] Fix typings for KubeObjectDetailsRegistration

- Allows correct subtyping of component props

Signed-off-by: Sebastian Malton <sebastian@malton.name>
---
 src/extensions/registries/kube-object-detail-registry.ts    | 6 +++---
 src/renderer/components/kube-object/kube-object-details.tsx | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/extensions/registries/kube-object-detail-registry.ts b/src/extensions/registries/kube-object-detail-registry.ts
index 844f5fc0ee..9df1d094f1 100644
--- a/src/extensions/registries/kube-object-detail-registry.ts
+++ b/src/extensions/registries/kube-object-detail-registry.ts
@@ -24,14 +24,14 @@ import type { KubeObjectDetailsProps } from "../renderer-api/components";
 import type { KubeObject } from "../renderer-api/k8s-api";
 import { BaseRegistry } from "./base-registry";
 
-export interface KubeObjectDetailComponents {
-  Details: React.ComponentType<KubeObjectDetailsProps<KubeObject>>;
+export interface KubeObjectDetailComponents<T extends KubeObject> {
+  Details: React.ComponentType<KubeObjectDetailsProps<T>>;
 }
 
 export interface KubeObjectDetailRegistration {
   kind: string;
   apiVersions: string[];
-  components: KubeObjectDetailComponents;
+  components: KubeObjectDetailComponents<KubeObject>;
   priority?: number;
 }
 
diff --git a/src/renderer/components/kube-object/kube-object-details.tsx b/src/renderer/components/kube-object/kube-object-details.tsx
index 1f0c494b4e..4075361368 100644
--- a/src/renderer/components/kube-object/kube-object-details.tsx
+++ b/src/renderer/components/kube-object/kube-object-details.tsx
@@ -82,7 +82,7 @@ export function getDetailsUrl(selfLink: string, resetSelected = false, mergeGlob
   return `?${params}`;
 }
 
-export interface KubeObjectDetailsProps<T = KubeObject> {
+export interface KubeObjectDetailsProps<T extends KubeObject> {
   className?: string;
   object: T;
 }