From cc94b698604ac562906a4304161fa5c0cf0167cb Mon Sep 17 00:00:00 2001 From: Gabriel Date: Fri, 12 May 2023 18:27:43 +0200 Subject: [PATCH] chore: half remove unoverride, more to follow Signed-off-by: Gabriel --- .../application-update/analytics-for-installing-update.test.ts | 2 +- .../get-electron-app-path/get-electron-app-path.test.ts | 2 +- packages/core/src/main/helm/__tests__/helm-service.test.ts | 2 +- .../monaco-editor/get-editor-height-from-lines-number.test.ts | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/core/src/features/application-update/analytics-for-installing-update.test.ts b/packages/core/src/features/application-update/analytics-for-installing-update.test.ts index 710c4b8e49..a342f67c82 100644 --- a/packages/core/src/features/application-update/analytics-for-installing-update.test.ts +++ b/packages/core/src/features/application-update/analytics-for-installing-update.test.ts @@ -52,7 +52,7 @@ describe("analytics for installing update", () => { mainDi.override(publishIsConfiguredInjectable, () => true); - mainDi.unoverride(emitEventInjectable); + // mainDi.unoverride(emitEventInjectable); const eventBus = mainDi.inject(appEventBusInjectable); diff --git a/packages/core/src/main/app-paths/get-electron-app-path/get-electron-app-path.test.ts b/packages/core/src/main/app-paths/get-electron-app-path/get-electron-app-path.test.ts index f6255cdf99..d7a79241f6 100644 --- a/packages/core/src/main/app-paths/get-electron-app-path/get-electron-app-path.test.ts +++ b/packages/core/src/main/app-paths/get-electron-app-path/get-electron-app-path.test.ts @@ -13,7 +13,7 @@ describe("get-electron-app-path", () => { beforeEach(() => { const di = getDiForUnitTesting(); - di.unoverride(getElectronAppPathInjectable); + // di.unoverride(getElectronAppPathInjectable); const appStub = { name: "some-app-name", diff --git a/packages/core/src/main/helm/__tests__/helm-service.test.ts b/packages/core/src/main/helm/__tests__/helm-service.test.ts index 7740533570..e0c7c7d812 100644 --- a/packages/core/src/main/helm/__tests__/helm-service.test.ts +++ b/packages/core/src/main/helm/__tests__/helm-service.test.ts @@ -27,7 +27,7 @@ describe("Helm Service tests", () => { di.override(getActiveHelmRepositoriesInjectable, () => getActiveHelmRepositoriesMock); - di.unoverride(listHelmChartsInjectable); + // di.unoverride(listHelmChartsInjectable); di.permitSideEffects(listHelmChartsInjectable); listHelmCharts = di.inject(listHelmChartsInjectable); diff --git a/packages/core/src/renderer/components/monaco-editor/get-editor-height-from-lines-number.test.ts b/packages/core/src/renderer/components/monaco-editor/get-editor-height-from-lines-number.test.ts index 6a0b82a83d..58d9ea3381 100644 --- a/packages/core/src/renderer/components/monaco-editor/get-editor-height-from-lines-number.test.ts +++ b/packages/core/src/renderer/components/monaco-editor/get-editor-height-from-lines-number.test.ts @@ -12,7 +12,7 @@ describe("get-editor-height-from-lines-number", () => { beforeEach(() => { const di = getDiForUnitTesting(); - di.unoverride(getEditorHeightFromLinesCountInjectable); + // di.unoverride(getEditorHeightFromLinesCountInjectable); getEditorHeightFromLinesNumber = di.inject(getEditorHeightFromLinesCountInjectable); });