hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Fix <Switch/> checked callback attribute value (#5360)

Browse Source
This commit is contained in:
Alex Andreev 2022-05-11 17:33:01 +03:00 committed by GitHub
parent d99cc5a015
commit cc9ee67dc2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 27 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/renderer/components/switch/__tests__/switch.test.tsx
View File

@ -48,4 +48,24 @@ describe("<Switch/>", () => {
expect(onClick).not.toHaveBeenCalled();
});
it("returns true checked attribute in a onChange callback", () => {
const onClick = jest.fn();
const { getByTestId } = render(<Switch onChange={onClick} checked={true}/>);
const switcher = getByTestId("switch");
fireEvent.click(switcher);
expect(onClick).toHaveBeenCalledWith(false, expect.any(Object));
});
it("returns false checked attribute in a onChange callback", () => {
const onClick = jest.fn();
const { getByTestId } = render(<Switch onChange={onClick}/>);
const switcher = getByTestId("switch");
fireEvent.click(switcher);
expect(onClick).toHaveBeenCalledWith(true, expect.any(Object));
});
});

8
src/renderer/components/switch/switch.tsx
View File

@ -17,7 +17,13 @@ export function Switch({ children, disabled, onChange, ...props }: SwitchProps)
return (
<label className={cssNames(styles.Switch, { [styles.disabled]: disabled })} data-testid="switch">
{children}
<input type="checkbox" role="switch" disabled={disabled} onChange={(event) => onChange?.(props.checked, event)} {...props}/>
<input
type="checkbox"
role="switch"
disabled={disabled}
onChange={(event) => onChange?.(event.target.checked, event)}
{...props}
/>
</label>
);
}