Get rid of this.disposers while registering stuff in extensions #1145

Signed-off-by: Roman <ixrock@gmail.com>
This commit is contained in:
Roman committed 2020-10-26 17:59:24 +02:00
1 parent e9ebd06664
commit cee4d1ea1f
16 files changed
+91 -82

No files matched your search

+6 -6
View File
@@ -1,6 +1,6 @@
import { Registry, LensRendererExtension } from "@k8slens/extensions";
import React from "react"
import { NodeMenu } from "./src/node-menu"
import { NodeMenu, NodeMenuProps } from "./src/node-menu"
export default class NodeMenuRendererExtension extends LensRendererExtension {
async onActivate() {
@@ -8,14 +8,14 @@ export default class NodeMenuRendererExtension extends LensRendererExtension {
}
registerKubeObjectMenus(registry: Registry.KubeObjectMenuRegistry) {
this.disposers.push(
registry.add({
return [
{
kind: "Node",
apiVersions: ["v1"],
components: {
MenuItem: (props) => <NodeMenu {...props} />
MenuItem: (props: NodeMenuProps) => <NodeMenu {...props} />
}
})
)
}
]
}
}
+4 -1
View File
@@ -1,7 +1,10 @@
import React from "react";
import { Component, K8sApi, Navigation} from "@k8slens/extensions"
export function NodeMenu(props: Component.KubeObjectMenuProps<K8sApi.Node>) {
export interface NodeMenuProps extends Component.KubeObjectMenuProps<K8sApi.Node> {
}
export function NodeMenu(props: NodeMenuProps) {
const { object: node, toolbar } = props;
if (!node) return null;
const nodeName = node.getName();