mirror of
https://github.com/lensapp/lens.git
synced 2025-05-20 05:10:56 +00:00
Get rid of this.disposers while registering stuff in extensions #1145
Signed-off-by: Roman <ixrock@gmail.com>
This commit is contained in:
1 parent
e9ebd06664
commit
cee4d1ea1f
16 files changed
+91
-82
No files matched your search
@@ -6,9 +6,9 @@ export default class SupportPageMainExtension extends LensMainExtension {
|
||||
console.log("support page extension activated")
|
||||
}
|
||||
|
||||
async registerAppMenus(registry: Registry.MenuRegistry) {
|
||||
this.disposers.push(
|
||||
registry.add({
|
||||
registerAppMenus(registry: Registry.MenuRegistry) {
|
||||
return [
|
||||
{
|
||||
parentId: "help",
|
||||
label: "Support",
|
||||
click() {
|
||||
@@ -17,7 +17,7 @@ export default class SupportPageMainExtension extends LensMainExtension {
|
||||
url: supportPageURL(),
|
||||
});
|
||||
}
|
||||
})
|
||||
)
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
@@ -8,22 +8,22 @@ export default class SupportPageRendererExtension extends LensRendererExtension
|
||||
console.log("support page extension activated")
|
||||
}
|
||||
|
||||
registerGlobalPage(registry: Registry.GlobalPageRegistry) {
|
||||
this.disposers.push(
|
||||
registry.add({
|
||||
registerGlobalPages(registry: Registry.GlobalPageRegistry) {
|
||||
return [
|
||||
{
|
||||
...supportPageRoute,
|
||||
url: supportPageURL(),
|
||||
hideInMenu: true,
|
||||
components: {
|
||||
Page: Support,
|
||||
}
|
||||
})
|
||||
)
|
||||
}
|
||||
]
|
||||
}
|
||||
|
||||
registerStatusBarItem(registry: Registry.StatusBarRegistry) {
|
||||
this.disposers.push(
|
||||
registry.add({
|
||||
registerStatusBarItems(registry: Registry.StatusBarRegistry) {
|
||||
return [
|
||||
{
|
||||
item: (
|
||||
<div
|
||||
className="flex align-center gaps hover-highlight"
|
||||
@@ -33,7 +33,7 @@ export default class SupportPageRendererExtension extends LensRendererExtension
|
||||
<span>Support</span>
|
||||
</div>
|
||||
)
|
||||
})
|
||||
)
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
Reference in new issue
Block a user