Get rid of this.disposers while registering stuff in extensions #1145

Signed-off-by: Roman <ixrock@gmail.com>
This commit is contained in:
Roman committed 2020-10-26 17:59:24 +02:00
1 parent e9ebd06664
commit cee4d1ea1f
16 files changed
+91 -82

No files matched your search

+5 -5
View File
@@ -6,9 +6,9 @@ export default class SupportPageMainExtension extends LensMainExtension {
console.log("support page extension activated")
}
async registerAppMenus(registry: Registry.MenuRegistry) {
this.disposers.push(
registry.add({
registerAppMenus(registry: Registry.MenuRegistry) {
return [
{
parentId: "help",
label: "Support",
click() {
@@ -17,7 +17,7 @@ export default class SupportPageMainExtension extends LensMainExtension {
url: supportPageURL(),
});
}
})
)
}
]
}
}
+10 -10
View File
@@ -8,22 +8,22 @@ export default class SupportPageRendererExtension extends LensRendererExtension
console.log("support page extension activated")
}
registerGlobalPage(registry: Registry.GlobalPageRegistry) {
this.disposers.push(
registry.add({
registerGlobalPages(registry: Registry.GlobalPageRegistry) {
return [
{
...supportPageRoute,
url: supportPageURL(),
hideInMenu: true,
components: {
Page: Support,
}
})
)
}
]
}
registerStatusBarItem(registry: Registry.StatusBarRegistry) {
this.disposers.push(
registry.add({
registerStatusBarItems(registry: Registry.StatusBarRegistry) {
return [
{
item: (
<div
className="flex align-center gaps hover-highlight"
@@ -33,7 +33,7 @@ export default class SupportPageRendererExtension extends LensRendererExtension
<span>Support</span>
</div>
)
})
)
}
]
}
}