From d0116b3b626eeb91c4966e0e93cbcf7a925d071c Mon Sep 17 00:00:00 2001 From: Janne Savolainen Date: Wed, 5 Apr 2023 12:08:41 +0300 Subject: [PATCH] fix: Dispose the kubeconfig watcher when application quits Signed-off-by: Janne Savolainen --- .../main/catalog-sources/kubeconfig-sync/manager.ts | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/packages/core/src/main/catalog-sources/kubeconfig-sync/manager.ts b/packages/core/src/main/catalog-sources/kubeconfig-sync/manager.ts index cf05577ae7..238857db4c 100644 --- a/packages/core/src/main/catalog-sources/kubeconfig-sync/manager.ts +++ b/packages/core/src/main/catalog-sources/kubeconfig-sync/manager.ts @@ -98,11 +98,19 @@ export class KubeconfigSyncManager { @action protected stopOldSync(filePath: string): void { - if (!this.sources.delete(filePath)) { - // already stopped + const source = this.sources.get(filePath); + + // already stopped + if (!source) { return this.dependencies.logger.debug(`no syncing file/folder to stop`, { filePath }); } + const [, disposer] = source; + + disposer(); + + this.sources.delete(filePath); + this.dependencies.logger.info(`stopping sync of file/folder`, { filePath }); this.dependencies.logger.debug(`${this.sources.size} files/folders watched`, { files: Array.from(this.sources.keys()) }); }