hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Fix nodes view observability (#3630)

Browse Source 
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
This commit is contained in:
Jari Kolehmainen 2021-08-18 11:50:40 +03:00 committed by GitHub
parent 016d012439
commit d1cfb5fed9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/renderer/components/+nodes/nodes.tsx
View File

@ -21,12 +21,11 @@
import "./nodes.scss"; import "./nodes.scss";
import React from "react"; import React from "react";
import { disposeOnUnmount, observer } from "mobx-react"; import { observer } from "mobx-react";
import type { RouteComponentProps } from "react-router"; import type { RouteComponentProps } from "react-router";
import { cssNames, interval } from "../../utils"; import { cssNames, interval } from "../../utils";
import { TabLayout } from "../layout/tab-layout"; import { TabLayout } from "../layout/tab-layout";
import { nodesStore } from "./nodes.store"; import { nodesStore } from "./nodes.store";
import { podsStore } from "../+workloads-pods/pods.store";
import { KubeObjectListLayout } from "../kube-object-list-layout"; import { KubeObjectListLayout } from "../kube-object-list-layout";
import { getMetricsForAllNodes, INodeMetrics, Node } from "../../../common/k8s-api/endpoints/nodes.api"; import { getMetricsForAllNodes, INodeMetrics, Node } from "../../../common/k8s-api/endpoints/nodes.api";
import { LineProgress } from "../line-progress"; import { LineProgress } from "../line-progress";
@ -36,10 +35,9 @@ import kebabCase from "lodash/kebabCase";
import upperFirst from "lodash/upperFirst"; import upperFirst from "lodash/upperFirst";
import { KubeObjectStatusIcon } from "../kube-object-status-icon"; import { KubeObjectStatusIcon } from "../kube-object-status-icon";
import { Badge } from "../badge/badge"; import { Badge } from "../badge/badge";
import { kubeWatchApi } from "../../../common/k8s-api/kube-watch-api";
import { eventStore } from "../+events/event.store"; import { eventStore } from "../+events/event.store";
import type { NodesRouteParams } from "../../../common/routes"; import type { NodesRouteParams } from "../../../common/routes";
import { observable } from "mobx"; import { makeObservable, observable } from "mobx";
import isEmpty from "lodash/isEmpty"; import isEmpty from "lodash/isEmpty";
enum columnId { enum columnId {
@ -60,16 +58,16 @@ interface Props extends RouteComponentProps<NodesRouteParams> {
@observer @observer
export class Nodes extends React.Component<Props> { export class Nodes extends React.Component<Props> {
@observable metrics: Partial<INodeMetrics> = {}; @observable.ref metrics: Partial<INodeMetrics> = {};
private metricsWatcher = interval(30, async () => this.metrics = await getMetricsForAllNodes()); private metricsWatcher = interval(30, async () => this.metrics = await getMetricsForAllNodes());
componentDidMount() { constructor(props: Props) {
super(props);
makeObservable(this);
}
async componentDidMount() {
this.metricsWatcher.start(true); this.metricsWatcher.start(true);
disposeOnUnmount(this, [
kubeWatchApi.subscribeStores([nodesStore, podsStore, eventStore], {
preload: true,
})
]);
} }
componentWillUnmount() { componentWillUnmount() {
@ -195,7 +193,7 @@ export class Nodes extends React.Component<Props> {
className="Nodes" className="Nodes"
store={nodesStore} store={nodesStore}
isReady={nodesStore.isLoaded} isReady={nodesStore.isLoaded}
dependentStores={[podsStore]} dependentStores={[eventStore]}
isSelectable={false} isSelectable={false}
sortingCallbacks={{ sortingCallbacks={{
[columnId.name]: node => node.getName(), [columnId.name]: node => node.getName(),