reverting dashboard rendering to webview, part 1

src/main/cluster-manager.ts

@@ -12,6 +12,7 @@ import { promises } from "fs"
 import  { ensureDir } from "fs-extra"
 import filenamify from "filenamify"
 import { v4 as uuid } from "uuid"
+import { apiPrefix } from "../common/vars";
 
 export type FeatureInstallRequest = {
   name: string;
@@ -261,7 +262,7 @@ export class ClusterManager {
         cluster = this.clusters.get(clusterId)
         if (cluster) {
           // we need to swap path prefix so that request is proxied to kube api
-          req.url = req.url.replace(`/${clusterId}`, "/api-kube")
+          req.url = req.url.replace(`/${clusterId}`, apiPrefix.KUBE_BASE)
         }
       }
     } else {

src/main/cluster.ts

@@ -9,6 +9,7 @@ import { Kubectl } from "./kubectl";
 import { PromiseIpc } from "electron-promise-ipc"
 import request from "request-promise-native"
 import { KubeconfigManager } from "./kubeconfig-manager"
+import { apiPrefix } from "../common/vars";
 
 enum ClusterStatus {
   AccessGranted = 2,
@@ -180,7 +181,8 @@ export class Cluster implements ClusterInfo {
   }
 
   protected async k8sRequest(path: string, opts: request.RequestPromiseOptions = {}) {
-    const url = `http://127.0.0.1:${this.port}/api-kube${path}`; // fixme: remove hardcoded api prefix
+    const prefix = apiPrefix.KUBE_BASE;
+    const url = `http://127.0.0.1:${this.port}${prefix}${path}`;
     opts.json = true;
     opts.timeout = 10000;
     opts.headers = Object.assign({}, opts.headers, {

src/main/index.ts

@@ -1,23 +1,139 @@
 // Main process
 
 import "../common/system-ca"
-import { app, BrowserWindow } from "electron"
+import "../common/prometheus-providers"
+import { app, dialog, protocol } from "electron"
+import { PromiseIpc } from "electron-promise-ipc"
+import path from "path"
+import { format as formatUrl } from "url"
+import logger from "./logger"
+import initMenu from "./menu"
+import * as proxy from "./proxy"
+import { WindowManager } from "./window-manager";
+import { clusterStore } from "../common/cluster-store"
+import { tracker } from "./tracker"
+import { ClusterManager } from "./cluster-manager";
+import AppUpdater from "./app-updater"
+import { shellSync } from "./shell-sync"
+import { getFreePort } from "./port"
+import { mangleProxyEnv } from "./proxy-env"
+import { findMainWebContents } from "./webcontents"
+import { registerStaticProtocol } from "../common/register-static";
+import { isMac } from "../common/vars";
 
-console.log('MAIN', process.resourcesPath)
-console.log('userData', app.getPath("userData"))
+mangleProxyEnv()
+if (app.commandLine.getSwitchValue("proxy-server") !== "") {
+  process.env.HTTPS_PROXY = app.commandLine.getSwitchValue("proxy-server")
+}
 
-app.whenReady().then(async function start() {
-  var mainWindow = new BrowserWindow({
-    width: 1024,
-    height: 768,
-    show: false,
-    webPreferences: {
-      devTools: true,
-      nodeIntegration: true,
-    }
-  });
+const promiseIpc = new PromiseIpc({ timeout: 2000 })
+let windowManager: WindowManager = null;
+let clusterManager: ClusterManager = null;
 
-  await mainWindow.loadFile("dist/index.html");
-  mainWindow.show();
-  mainWindow.focus();
-});
+const vmURL = formatUrl({
+  pathname: path.join(__dirname, "dist/index.html"),
+  protocol: "file",
+  slashes: true,
+})
+
+async function main() {
+  await shellSync()
+
+  const updater = new AppUpdater()
+  updater.start();
+
+  tracker.event("app", "start");
+
+  registerStaticProtocol();
+  protocol.registerFileProtocol('store', (request, callback) => {
+    const url = request.url.substr(8)
+    callback(path.normalize(`${app.getPath("userData")}/${url}`))
+  }, (error) => {
+    if (error) console.error('Failed to register protocol')
+  })
+
+  let port: number = null
+  // find free port
+  try {
+    port = await getFreePort()
+  } catch (error) {
+    logger.error(error)
+    await dialog.showErrorBox("Lens Error", "Could not find a free port for the cluster proxy")
+    app.quit();
+  }
+
+  // create cluster manager
+  clusterManager = new ClusterManager(clusterStore.getAllClusterObjects(), port)
+
+  // run proxy
+  try {
+    proxy.listen(port, clusterManager)
+  } catch (error) {
+    logger.error(`Could not start proxy (127.0.0:${port}): ${error.message}`)
+    await dialog.showErrorBox("Lens Error", `Could not start proxy (127.0.0:${port}): ${error.message || "unknown error"}`)
+    app.quit();
+  }
+
+  // boot windowmanager
+  windowManager = new WindowManager();
+  windowManager.showMain(vmURL)
+
+  initMenu({
+    logoutHook: async () => {
+      // IPC send needs webContents as we're sending it to renderer
+      promiseIpc.send('logout', findMainWebContents(), {}).then((data: any) => {
+        logger.debug("logout IPC sent");
+      })
+    },
+    showPreferencesHook: async () => {
+      // IPC send needs webContents as we're sending it to renderer
+      promiseIpc.send('navigate', findMainWebContents(), { name: 'preferences-page' }).then((data: any) => {
+        logger.debug("navigate: preferences IPC sent");
+      })
+    },
+    addClusterHook: async () => {
+      promiseIpc.send('navigate', findMainWebContents(), { name: "add-cluster-page" }).then((data: any) => {
+        logger.debug("navigate: add-cluster-page  IPC sent");
+      })
+    },
+    showWhatsNewHook: async () => {
+      promiseIpc.send('navigate', findMainWebContents(), { name: "whats-new-page" }).then((data: any) => {
+        logger.debug("navigate: whats-new-page  IPC sent");
+      })
+    },
+    clusterSettingsHook: async () => {
+      promiseIpc.send('navigate', findMainWebContents(), { name: "cluster-settings-page" }).then((data: any) => {
+        logger.debug("navigate: cluster-settings-page  IPC sent");
+      })
+    },
+  }, promiseIpc)
+}
+
+app.on("ready", main)
+app.on('window-all-closed', function () {
+  // On OS X it is common for applications and their menu bar
+  // to stay active until the user quits explicitly with Cmd + Q
+  if (!isMac) {
+    app.quit();
+  } else {
+    windowManager = null
+    if (clusterManager) clusterManager.stop()
+  }
+})
+app.on("activate", () => {
+  if (!windowManager) {
+    logger.debug("activate main window")
+    windowManager = new WindowManager(false)
+    windowManager.showMain(vmURL)
+  }
+})
+app.on("will-quit", async (event) => {
+  event.preventDefault(); // To allow mixpanel sending to be executed
+  if (clusterManager) clusterManager.stop()
+  app.exit(0);
+})
+
+// todo: auto-restart app in dev-mode
+// if (isDevelopment) {
+//   require('electron-reloader')(module);
+// }

src/main/index_backup.ts

@@ -1,139 +0,0 @@
-// Main process
-
-import "../common/system-ca"
-import "../common/prometheus-providers"
-import { app, dialog, protocol } from "electron"
-import { PromiseIpc } from "electron-promise-ipc"
-import path from "path"
-import { format as formatUrl } from "url"
-import logger from "./logger"
-import initMenu from "./menu"
-import * as proxy from "./proxy"
-import { WindowManager } from "./window-manager";
-import { clusterStore } from "../common/cluster-store"
-import { tracker } from "./tracker"
-import { ClusterManager } from "./cluster-manager";
-import AppUpdater from "./app-updater"
-import { shellSync } from "./shell-sync"
-import { getFreePort } from "./port"
-import { mangleProxyEnv } from "./proxy-env"
-import { findMainWebContents } from "./webcontents"
-import { registerStaticProtocol } from "../common/register-static";
-import { isDevelopment, isMac } from "../common/vars";
-
-mangleProxyEnv()
-if (app.commandLine.getSwitchValue("proxy-server") !== "") {
-  process.env.HTTPS_PROXY = app.commandLine.getSwitchValue("proxy-server")
-}
-const promiseIpc = new PromiseIpc({ timeout: 2000 })
-
-let windowManager: WindowManager = null;
-let clusterManager: ClusterManager = null;
-const vmURL = isDevelopment ? `http://localhost:${process.env.ELECTRON_WEBPACK_WDS_PORT}` : formatUrl({
-  pathname: path.join(__dirname, "index.html"),
-  protocol: "file",
-  slashes: true,
-})
-
-async function main() {
-  await shellSync()
-
-  const updater = new AppUpdater()
-  updater.start();
-
-  tracker.event("app", "start");
-
-  registerStaticProtocol();
-  protocol.registerFileProtocol('store', (request, callback) => {
-    const url = request.url.substr(8)
-    callback(path.normalize(`${app.getPath("userData")}/${url}`))
-  }, (error) => {
-    if (error) console.error('Failed to register protocol')
-  })
-
-  let port: number = null
-  // find free port
-  try {
-    port = await getFreePort()
-  } catch (error) {
-    logger.error(error)
-    await dialog.showErrorBox("Lens Error", "Could not find a free port for the cluster proxy")
-    app.quit();
-  }
-
-  // create cluster manager
-  clusterManager = new ClusterManager(clusterStore.getAllClusterObjects(), port)
-
-  // run proxy
-  try {
-    proxy.listen(port, clusterManager)
-  } catch (error) {
-    logger.error(`Could not start proxy (127.0.0:${port}): ${error.message}`)
-    await dialog.showErrorBox("Lens Error", `Could not start proxy (127.0.0:${port}): ${error.message || "unknown error"}`)
-    app.quit();
-  }
-
-  // boot windowmanager
-  windowManager = new WindowManager();
-  windowManager.showMain(vmURL)
-
-  initMenu({
-    logoutHook: async () => {
-      // IPC send needs webContents as we're sending it to renderer
-      promiseIpc.send('logout', findMainWebContents(), {}).then((data: any) => {
-        logger.debug("logout IPC sent");
-      })
-    },
-    showPreferencesHook: async () => {
-      // IPC send needs webContents as we're sending it to renderer
-      promiseIpc.send('navigate', findMainWebContents(), { name: 'preferences-page' }).then((data: any) => {
-        logger.debug("navigate: preferences IPC sent");
-      })
-    },
-    addClusterHook: async () => {
-      promiseIpc.send('navigate', findMainWebContents(), { name: "add-cluster-page" }).then((data: any) => {
-        logger.debug("navigate: add-cluster-page  IPC sent");
-      })
-    },
-    showWhatsNewHook: async () => {
-      promiseIpc.send('navigate', findMainWebContents(), { name: "whats-new-page" }).then((data: any) => {
-        logger.debug("navigate: whats-new-page  IPC sent");
-      })
-    },
-    clusterSettingsHook: async () => {
-      promiseIpc.send('navigate', findMainWebContents(), { name: "cluster-settings-page" }).then((data: any) => {
-        logger.debug("navigate: cluster-settings-page  IPC sent");
-      })
-    },
-  }, promiseIpc)
-}
-
-app.on("ready", main)
-app.on('window-all-closed', function () {
-  // On OS X it is common for applications and their menu bar
-  // to stay active until the user quits explicitly with Cmd + Q
-  if (!isMac) {
-    app.quit();
-  }
-  else {
-    windowManager = null
-    if (clusterManager) clusterManager.stop()
-  }
-})
-app.on("activate", () => {
-  if (!windowManager) {
-    logger.debug("activate main window")
-    windowManager = new WindowManager(false)
-    windowManager.showMain(vmURL)
-  }
-})
-app.on("will-quit", async (event) => {
-  event.preventDefault(); // To allow mixpanel sending to be executed
-  if (clusterManager) clusterManager.stop()
-  app.exit(0);
-})
-
-// todo: check auto-restart app in dev-mode
-// if (isDevelopment) {
-//   require('electron-reloader')(module);
-// }

src/main/proxy.ts

@@ -8,6 +8,7 @@ import logger from "./logger"
 import * as shell from "./node-shell-session"
 import { ClusterManager } from "./cluster-manager"
 import { Router } from "./router"
+import { apiPrefix } from "../common/vars";
 
 export class LensProxy {
   public static readonly localShellSessions = true
@@ -110,9 +111,10 @@ export class LensProxy {
   }
 
   protected async getProxyTarget(req: http.IncomingMessage, contextHandler: ContextHandler): Promise<httpProxy.ServerOptions> {
-    if (req.url.startsWith("/api-kube/")) {
+    const prefix = apiPrefix.KUBE_BASE;
+    if (req.url.startsWith(prefix)) {
       delete req.headers.authorization
-      req.url = req.url.replace("/api-kube", "")
+      req.url = req.url.replace(prefix, "")
       const isWatchRequest = req.url.includes("watch=")
       return await contextHandler.getApiTarget(isWatchRequest)
     }

src/main/routes/metrics.ts

@@ -2,6 +2,7 @@ import { LensApiRequest } from "../router"
 import { LensApi } from "../lens-api"
 import requestPromise from "request-promise-native"
 import { PrometheusProviderRegistry, PrometheusProvider, PrometheusNodeQuery, PrometheusClusterQuery, PrometheusPodQuery, PrometheusPvcQuery, PrometheusIngressQuery, PrometheusQueryOpts} from "../prometheus/provider-registry"
+import { apiPrefix } from "../../common/vars";
 
 export type IMetricsQuery = string | string[] | {
   [metricName: string]: string;
@@ -12,7 +13,7 @@ class MetricsRoute extends LensApi {
   public async routeMetrics(request: LensApiRequest) {
     const { response, cluster} = request
     const query: IMetricsQuery = request.payload;
-    const serverUrl = `http://127.0.0.1:${cluster.port}/api-kube`
+    const serverUrl = `http://127.0.0.1:${cluster.port}${apiPrefix.KUBE_BASE}`
     const headers = {
       "Host": `${cluster.id}.localhost:${cluster.port}`,
       "Content-type": "application/json",