From d4c12becfc9020009d64f48e4c8f9dd3b7725bb6 Mon Sep 17 00:00:00 2001 From: Sebastian Malton Date: Tue, 23 May 2023 09:09:13 -0400 Subject: [PATCH] Revert "chore: Improve title formatting for Horizontal/Vertical Pod Autoscalers" This reverts commit d51ccb5dd5bad07350bbbb325214d549424a4a34. --- open-lens/integration/__tests__/cluster-pages.tests.ts | 2 +- ...ar-item.injectable.ts => sidebar-items.injectable.tsx} | 8 ++++---- ...vertical-pod-auto-scalers-sidebar-item.injectable.tsx} | 8 ++++---- 3 files changed, 9 insertions(+), 9 deletions(-) rename packages/core/src/renderer/components/config-horizontal-pod-autoscalers/{sidebar-item.injectable.ts => sidebar-items.injectable.tsx} (84%) rename packages/core/src/renderer/components/config-vertical-pod-autoscalers/{sidebar-item.injectable.ts => vertical-pod-auto-scalers-sidebar-item.injectable.tsx} (85%) diff --git a/open-lens/integration/__tests__/cluster-pages.tests.ts b/open-lens/integration/__tests__/cluster-pages.tests.ts index d6ced33d25..5ecf7915af 100644 --- a/open-lens/integration/__tests__/cluster-pages.tests.ts +++ b/open-lens/integration/__tests__/cluster-pages.tests.ts @@ -256,7 +256,7 @@ const scenarios = [ { expectedSelector: "h5.title", parentSidebarItemTestId: "link-for-sidebar-item-config", - sidebarItemTestId: "link-for-sidebar-item-horizontal-pod-autoscalers", + sidebarItemTestId: "link-for-sidebar-item-horizontal-pod-auto-scalers", }, { diff --git a/packages/core/src/renderer/components/config-horizontal-pod-autoscalers/sidebar-item.injectable.ts b/packages/core/src/renderer/components/config-horizontal-pod-autoscalers/sidebar-items.injectable.tsx similarity index 84% rename from packages/core/src/renderer/components/config-horizontal-pod-autoscalers/sidebar-item.injectable.ts rename to packages/core/src/renderer/components/config-horizontal-pod-autoscalers/sidebar-items.injectable.tsx index 0e98331601..0dfdd7f6cc 100644 --- a/packages/core/src/renderer/components/config-horizontal-pod-autoscalers/sidebar-item.injectable.ts +++ b/packages/core/src/renderer/components/config-horizontal-pod-autoscalers/sidebar-items.injectable.tsx @@ -9,15 +9,15 @@ import { sidebarItemInjectionToken } from "@k8slens/cluster-sidebar"; import routeIsActiveInjectable from "../../routes/route-is-active.injectable"; import navigateToHorizontalPodAutoscalersInjectable from "../../../common/front-end-routing/routes/cluster/config/horizontal-pod-autoscalers/navigate-to-horizontal-pod-autoscalers.injectable"; -const horizontalPodAutoscalersSidebarItemInjectable = getInjectable({ - id: "sidebar-item-horizontal-pod-autoscalers", +const horizontalPodAutoScalersSidebarItemInjectable = getInjectable({ + id: "sidebar-item-horizontal-pod-auto-scalers", instantiate: (di) => { const route = di.inject(horizontalPodAutoscalersRouteInjectable); return { parentId: configSidebarItemInjectable.id, - title: "Horizontal Pod Autoscalers", + title: "HPA", onClick: di.inject(navigateToHorizontalPodAutoscalersInjectable), isActive: di.inject(routeIsActiveInjectable, route), isVisible: route.isEnabled, @@ -28,4 +28,4 @@ const horizontalPodAutoscalersSidebarItemInjectable = getInjectable({ injectionToken: sidebarItemInjectionToken, }); -export default horizontalPodAutoscalersSidebarItemInjectable; +export default horizontalPodAutoScalersSidebarItemInjectable; diff --git a/packages/core/src/renderer/components/config-vertical-pod-autoscalers/sidebar-item.injectable.ts b/packages/core/src/renderer/components/config-vertical-pod-autoscalers/vertical-pod-auto-scalers-sidebar-item.injectable.tsx similarity index 85% rename from packages/core/src/renderer/components/config-vertical-pod-autoscalers/sidebar-item.injectable.ts rename to packages/core/src/renderer/components/config-vertical-pod-autoscalers/vertical-pod-auto-scalers-sidebar-item.injectable.tsx index 46acbcc4a3..6d16e0c24c 100644 --- a/packages/core/src/renderer/components/config-vertical-pod-autoscalers/sidebar-item.injectable.ts +++ b/packages/core/src/renderer/components/config-vertical-pod-autoscalers/vertical-pod-auto-scalers-sidebar-item.injectable.tsx @@ -9,15 +9,15 @@ import { sidebarItemInjectionToken } from "@k8slens/cluster-sidebar"; import routeIsActiveInjectable from "../../routes/route-is-active.injectable"; import navigateToVerticalPodAutoscalersInjectable from "../../../common/front-end-routing/routes/cluster/config/vertical-pod-autoscalers/navigate-to-vertical-pod-autoscalers.injectable"; -const verticalPodAutoscalersSidebarItemInjectable = getInjectable({ - id: "sidebar-item-vertical-pod-autoscalers", +const verticalPodAutoScalersSidebarItemInjectable = getInjectable({ + id: "sidebar-item-vertical-pod-auto-scalers", instantiate: (di) => { const route = di.inject(verticalPodAutoscalersRouteInjectable); return { parentId: configSidebarItemInjectable.id, - title: "Vertical Pod Autoscalers", + title: "VPA", onClick: di.inject(navigateToVerticalPodAutoscalersInjectable), isActive: di.inject(routeIsActiveInjectable, route), isVisible: route.isEnabled, @@ -28,4 +28,4 @@ const verticalPodAutoscalersSidebarItemInjectable = getInjectable({ injectionToken: sidebarItemInjectionToken, }); -export default verticalPodAutoscalersSidebarItemInjectable; +export default verticalPodAutoScalersSidebarItemInjectable;